Cleanup part 6.

Lots of small things (mostly in spellcheck code), e.g.:
* L"" -> std::wstring()
* type *var; -> type* var;
* Fix parameter line-wrapping to comply with style guide
* Remove unnecessary classname scoping inside class delcaration
* Remove empty declaration
* Add/remove blank lines in hopes of increasing readability
* Add block ("{", "}") around local use of a temporary that is later redefined
* Fold temps into other statements where obvious
* Use std::find() instead of hand-rolling the same functionality
* Combine distinct cases in switch statements when they all do the same thing
* Range-check to avoid some algorithmic work when it's not needed
* at() -> []

...and various others.  Pretty much every change stands on its own.  Do not hesitate to complain about changes you think are unhelpful to the code, this change is something of a dumping ground.  (I did try to avoid the sort of gratuitous "const"-adding that has gotten me in trouble before :). )
Review URL: http://codereview.chromium.org/13688

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6745 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 6 deletions

diff --git a/chrome/browser/spellchecker.h b/chrome/browser/spellchecker.h
index 07be6120..1283712 100644
--- a/chrome/browser/spellchecker.h
+++ b/chrome/browser/spellchecker.h
@@ -78,14 +78,14 @@ class SpellChecker : public base::RefCountedThreadSafe<SpellChecker> {
   // This function computes a vector of strings which are to be displayed in 
   // the context menu over a text area for changing spell check languages. It
   // returns the index of the current spell check language in the vector.
-  static int SpellChecker::GetSpellCheckLanguagesToDisplayInContextMenu(
-      Profile* profile, std::vector<std::wstring>* display_language_list);
+  static int GetSpellCheckLanguagesToDisplayInContextMenu(
+      Profile* profile,
+      std::vector<std::wstring>* display_language_list);
 
+ private:
   // Download dictionary files when required.
   class DictionaryDownloadController;
 
-  SpellChecker::SpellChecker();
-
   // Initializes the Hunspell Dictionary.
   bool Initialize();
 
@@ -124,7 +124,7 @@ class SpellChecker : public base::RefCountedThreadSafe<SpellChecker> {
   const unsigned char* bdict_mapped_data_;
 
   // The hunspell dictionary in use.
-  Hunspell *hunspell_;
+  Hunspell* hunspell_;
 
   // Represents character attributes used for filtering out characters which
   // are not supported by this SpellChecker object.
@@ -168,7 +168,7 @@ class SpellChecker : public base::RefCountedThreadSafe<SpellChecker> {
   // using NewRunableMethod on these objects.
   ScopedRunnableMethodFactory<SpellChecker> dic_download_state_changer_factory_;
 
-  DISALLOW_EVIL_CONSTRUCTORS(SpellChecker);
+  DISALLOW_COPY_AND_ASSIGN(SpellChecker);
 };
 
 #endif  // #ifndef CHROME_BROWSER_SPELLCHECKER_H__