diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-23 07:26:32 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-02-23 07:26:32 +0000 |
| commit | 192d8c5ea712cca42ea1d6ff692cd77d099c0a35 (patch) | |
| tree | adc818cdd39ff402645f391f773bf359e7b753f0 /chrome/browser/ssl/ssl_manager.cc | |
| parent | 781a7edbdb3288b237acbeff4926b47b243cef17 (diff) | |
| download | chromium_src-192d8c5ea712cca42ea1d6ff692cd77d099c0a35.zip chromium_src-192d8c5ea712cca42ea1d6ff692cd77d099c0a35.tar.gz chromium_src-192d8c5ea712cca42ea1d6ff692cd77d099c0a35.tar.bz2 | |
Make the translation bar not show up again when you closed it in a page
and navigate in page. This is the case with web apps like GMail where
many actions result in an in-page navigation. It would originally bring
back the translation infobar, which is very anoying.
This CL fixes the is_in_page state of LoadCommittedDetails, it was always false.
This triggered a bug in the SSLManager that was wrongly not setting the SSL states when an in-page navigation is performed.
Since we create a new navigation entry for in-page navigations, not setting these states would make a bad page being reported as OK after an in-page navigation.
See original review:
http://codereview.chromium.org/650146/show
BUG=36304
TEST=Login to gmail, change the GMail language to a language different than
the Chrome language. When a translate infobar shows up, close it.
Click on the different links in GMail (inbox, drafts, select email...)
the translate infobar should not show again.
Review URL: http://codereview.chromium.org/650207
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39700 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ssl/ssl_manager.cc')
| -rw-r--r-- | chrome/browser/ssl/ssl_manager.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/browser/ssl/ssl_manager.cc b/chrome/browser/ssl/ssl_manager.cc index c55a47b..b869d65 100644 --- a/chrome/browser/ssl/ssl_manager.cc +++ b/chrome/browser/ssl/ssl_manager.cc @@ -170,11 +170,6 @@ void SSLManager::DidCommitProvisionalLoad( NavigationController::LoadCommittedDetails* details = Details<NavigationController::LoadCommittedDetails>(in_details).ptr(); - // Ignore in-page navigations, they should not change the security style or - // the info-bars. - if (details->is_in_page) - return; - NavigationEntry* entry = controller_->GetActiveEntry(); if (details->is_main_frame) { |