diff options
author | abarth@chromium.org <abarth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 00:03:49 +0000 |
---|---|---|
committer | abarth@chromium.org <abarth@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-01 00:03:49 +0000 |
commit | 49f3d5598a091569e15102770ffb1a50732d2fc4 (patch) | |
tree | 9251a1b292e702f910ff85ff74bd493009846fe3 /chrome/browser/ssl | |
parent | 558b6591982ff3f66538d1c5388cf4b84ccaad98 (diff) | |
download | chromium_src-49f3d5598a091569e15102770ffb1a50732d2fc4.zip chromium_src-49f3d5598a091569e15102770ffb1a50732d2fc4.tar.gz chromium_src-49f3d5598a091569e15102770ffb1a50732d2fc4.tar.bz2 |
Add some histograms to see how often users click through blocking pages.
R=jar
Review URL: http://codereview.chromium.org/99020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15018 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ssl')
-rw-r--r-- | chrome/browser/ssl/ssl_blocking_page.cc | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc index ce9d9da..5e1e2fd 100644 --- a/chrome/browser/ssl/ssl_blocking_page.cc +++ b/chrome/browser/ssl/ssl_blocking_page.cc @@ -4,6 +4,7 @@ #include "chrome/browser/ssl/ssl_blocking_page.h" +#include "base/histogram.h" #include "base/string_piece.h" #include "base/values.h" #include "chrome/browser/browser.h" @@ -22,6 +23,22 @@ #include "grit/browser_resources.h" #include "grit/generated_resources.h" +namespace { + +enum SSLBlockingPageEvent { + SHOW, + PROCEED, + DONT_PROCEED, +}; + +void RecordSSLBlockingPageStats(SSLBlockingPageEvent event) { + static LinearHistogram histogram("interstial.ssl", 0, 2, 3); + histogram.SetFlags(kUmaTargetedHistogramFlag); + histogram.Add(event); +} + +} // namespace + // Note that we always create a navigation entry with SSL errors. // No error happening loading a sub-resource triggers an interstitial so far. SSLBlockingPage::SSLBlockingPage(SSLManager::CertError* error, @@ -30,6 +47,7 @@ SSLBlockingPage::SSLBlockingPage(SSLManager::CertError* error, error_(error), delegate_(delegate), delegate_has_been_notified_(false) { + RecordSSLBlockingPageStats(SHOW); } SSLBlockingPage::~SSLBlockingPage() { @@ -94,6 +112,8 @@ void SSLBlockingPage::CommandReceived(const std::string& command) { } void SSLBlockingPage::Proceed() { + RecordSSLBlockingPageStats(PROCEED); + // Accepting the certificate resumes the loading of the page. NotifyAllowCertificate(); @@ -102,11 +122,12 @@ void SSLBlockingPage::Proceed() { } void SSLBlockingPage::DontProceed() { + RecordSSLBlockingPageStats(DONT_PROCEED); + NotifyDenyCertificate(); InterstitialPage::DontProceed(); } - void SSLBlockingPage::NotifyDenyCertificate() { DCHECK(!delegate_has_been_notified_); |