diff options
author | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-24 22:51:46 +0000 |
---|---|---|
committer | thakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-24 22:51:46 +0000 |
commit | a852203c1ae878c97ef5f64eec9b89e57642a78b (patch) | |
tree | 8d2e4837f0bd6f9300a0fe2d17c0956181e39bbf /chrome/browser/storage_monitor | |
parent | dd9cd303480e5c1fd2465986903856651bded8d5 (diff) | |
download | chromium_src-a852203c1ae878c97ef5f64eec9b89e57642a78b.zip chromium_src-a852203c1ae878c97ef5f64eec9b89e57642a78b.tar.gz chromium_src-a852203c1ae878c97ef5f64eec9b89e57642a78b.tar.bz2 |
mac: Update clients of scoped_nsobject.h.
1.) The header is now in base/mac instead of base/memory
2.) The class is now in namespace base.
This CL was created programmatically by running:
1.)
git grep -l memory/scoped_nsobject.h | xargs sed -i -e 's/memory\/scoped_nsobject.h/mac\/scoped_nsobject.h/g'
for f in $(git diff --name-only origin); do tools/sort-headers.py $f -f; done
git commit -a -m headers
# manually undo changes to gypi file
git cl upload # patch set 1
2.)
git grep -l 'scoped_nsobject<' | xargs sed -i -e 's/scoped_nsobject</base::scoped_nsobject</g'
# manually undo comment changes in scoped_nsobject.h, tracking_area.h
git commit -a -m format
git cl upload # patch set 2
# Manually audit all files, file bugs and clean up bad clang-format decisions
git cl upload # patch set 3
BUG=251957
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/17593006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208283 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/storage_monitor')
4 files changed, 26 insertions, 32 deletions
diff --git a/chrome/browser/storage_monitor/image_capture_device.h b/chrome/browser/storage_monitor/image_capture_device.h index 0860d9d..82fd1b5 100644 --- a/chrome/browser/storage_monitor/image_capture_device.h +++ b/chrome/browser/storage_monitor/image_capture_device.h @@ -11,8 +11,8 @@ #include "base/files/file_path.h" #include "base/mac/cocoa_protocols.h" #include "base/mac/foundation_util.h" +#include "base/mac/scoped_nsobject.h" #include "base/memory/ref_counted.h" -#include "base/memory/scoped_nsobject.h" #include "base/memory/weak_ptr.h" #include "base/platform_file.h" #include "base/strings/string_util.h" @@ -58,7 +58,7 @@ class ImageCaptureDeviceListener { @interface ImageCaptureDevice : NSObject<ICCameraDeviceDelegate, ICCameraDeviceDownloadDelegate> { @private - scoped_nsobject<ICCameraDevice> camera_; + base::scoped_nsobject<ICCameraDevice> camera_; base::WeakPtr<ImageCaptureDeviceListener> listener_; bool closing_; } diff --git a/chrome/browser/storage_monitor/image_capture_device_manager.h b/chrome/browser/storage_monitor/image_capture_device_manager.h index 22297c9..bc8c09e 100644 --- a/chrome/browser/storage_monitor/image_capture_device_manager.h +++ b/chrome/browser/storage_monitor/image_capture_device_manager.h @@ -8,7 +8,7 @@ #import <Foundation/Foundation.h> #include <string> -#include "base/memory/scoped_nsobject.h" +#include "base/mac/scoped_nsobject.h" #include "chrome/browser/storage_monitor/storage_monitor.h" @protocol ICDeviceBrowserDelegate; @@ -39,7 +39,7 @@ class ImageCaptureDeviceManager { void SetNotifications(StorageMonitor::Receiver* notifications); private: - scoped_nsobject<ImageCaptureDeviceManagerImpl> device_browser_; + base::scoped_nsobject<ImageCaptureDeviceManagerImpl> device_browser_; }; } // namespace chrome diff --git a/chrome/browser/storage_monitor/image_capture_device_manager.mm b/chrome/browser/storage_monitor/image_capture_device_manager.mm index cfd5057..91191b4 100644 --- a/chrome/browser/storage_monitor/image_capture_device_manager.mm +++ b/chrome/browser/storage_monitor/image_capture_device_manager.mm @@ -25,8 +25,8 @@ chrome::ImageCaptureDeviceManager* g_image_capture_device_manager = NULL; @interface ImageCaptureDeviceManagerImpl : NSObject<ICDeviceBrowserDelegate> { @private - scoped_nsobject<ICDeviceBrowser> deviceBrowser_; - scoped_nsobject<NSMutableArray> cameras_; + base::scoped_nsobject<ICDeviceBrowser> deviceBrowser_; + base::scoped_nsobject<NSMutableArray> cameras_; // Guaranteed to outlive this class. // TODO(gbillock): Update when ownership chains go up through diff --git a/chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm b/chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm index 2b3a16a..f55576f 100644 --- a/chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm +++ b/chrome/browser/storage_monitor/image_capture_device_manager_unittest.mm @@ -45,7 +45,7 @@ const char kTestFileContents[] = "test"; @interface MockICCameraDevice : ICCameraDevice { @private - scoped_nsobject<NSMutableArray> allMediaFiles_; + base::scoped_nsobject<NSMutableArray> allMediaFiles_; } - (void)addMediaFile:(ICCameraFile*)file; @@ -129,7 +129,7 @@ const char kTestFileContents[] = "test"; @interface MockICCameraFolder : ICCameraFolder { @private - scoped_nsobject<NSString> name_; + base::scoped_nsobject<NSString> name_; } - (id)initWithName:(NSString*)name; @@ -157,9 +157,9 @@ const char kTestFileContents[] = "test"; @interface MockICCameraFile : ICCameraFile { @private - scoped_nsobject<NSString> name_; - scoped_nsobject<NSDate> date_; - scoped_nsobject<MockICCameraFolder> parent_; + base::scoped_nsobject<NSString> name_; + base::scoped_nsobject<NSDate> date_; + base::scoped_nsobject<MockICCameraFolder> parent_; } - (id)init:(NSString*)name; @@ -262,7 +262,7 @@ class ImageCaptureDeviceManagerTest : public testing::Test { MockICCameraDevice* AttachDevice( chrome::ImageCaptureDeviceManager* manager) { // Ownership will be passed to the device browser delegate. - scoped_nsobject<MockICCameraDevice> device( + base::scoped_nsobject<MockICCameraDevice> device( [[MockICCameraDevice alloc] init]); id<ICDeviceBrowserDelegate> delegate = manager->device_browser(); [delegate deviceBrowser:nil didAddDevice:device moreComing:NO]; @@ -305,17 +305,16 @@ TEST_F(ImageCaptureDeviceManagerTest, OpenCamera) { EXPECT_FALSE(chrome::ImageCaptureDeviceManager::deviceForUUID( "nonexistent")); - scoped_nsobject<ImageCaptureDevice> camera( - [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) - retain]); + base::scoped_nsobject<ImageCaptureDevice> camera( + [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) retain]); [camera setListener:listener_.AsWeakPtr()]; [camera open]; - scoped_nsobject<MockICCameraFile> picture1( + base::scoped_nsobject<MockICCameraFile> picture1( [[MockICCameraFile alloc] init:@"pic1"]); [camera cameraDevice:nil didAddItem:picture1]; - scoped_nsobject<MockICCameraFile> picture2( + base::scoped_nsobject<MockICCameraFile> picture2( [[MockICCameraFile alloc] init:@"pic2"]); [camera cameraDevice:nil didAddItem:picture2]; ASSERT_EQ(2U, listener_.items().size()); @@ -339,9 +338,8 @@ TEST_F(ImageCaptureDeviceManagerTest, RemoveCamera) { manager.SetNotifications(monitor_.receiver()); ICCameraDevice* device = AttachDevice(&manager); - scoped_nsobject<ImageCaptureDevice> camera( - [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) - retain]); + base::scoped_nsobject<ImageCaptureDevice> camera( + [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) retain]); [camera setListener:listener_.AsWeakPtr()]; [camera open]; @@ -359,18 +357,16 @@ TEST_F(ImageCaptureDeviceManagerTest, DownloadFile) { manager.SetNotifications(monitor_.receiver()); MockICCameraDevice* device = AttachDevice(&manager); - scoped_nsobject<ImageCaptureDevice> camera( - [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) - retain]); + base::scoped_nsobject<ImageCaptureDevice> camera( + [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) retain]); [camera setListener:listener_.AsWeakPtr()]; [camera open]; std::string kTestFileName("pic1"); - scoped_nsobject<MockICCameraFile> picture1( - [[MockICCameraFile alloc] - init:base::SysUTF8ToNSString(kTestFileName)]); + base::scoped_nsobject<MockICCameraFile> picture1( + [[MockICCameraFile alloc] init:base::SysUTF8ToNSString(kTestFileName)]); [device addMediaFile:picture1]; [camera cameraDevice:nil didAddItem:picture1]; @@ -417,17 +413,15 @@ TEST_F(ImageCaptureDeviceManagerTest, TestSubdirectories) { manager.SetNotifications(monitor_.receiver()); MockICCameraDevice* device = AttachDevice(&manager); - scoped_nsobject<ImageCaptureDevice> camera( - [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) - retain]); + base::scoped_nsobject<ImageCaptureDevice> camera( + [chrome::ImageCaptureDeviceManager::deviceForUUID(kDeviceId) retain]); [camera setListener:listener_.AsWeakPtr()]; [camera open]; std::string kTestFileName("pic1"); - scoped_nsobject<MockICCameraFile> picture1( - [[MockICCameraFile alloc] - init:base::SysUTF8ToNSString(kTestFileName)]); + base::scoped_nsobject<MockICCameraFile> picture1( + [[MockICCameraFile alloc] init:base::SysUTF8ToNSString(kTestFileName)]); [picture1 setParent:base::SysUTF8ToNSString("dir")]; [device addMediaFile:picture1]; [camera cameraDevice:nil didAddItem:picture1]; |