sync: hook up ServerConnectionManager <> SyncerThread2 and tie up more loose ends

This permits the thread to initiate syncing by waiting for valid network connectivity.

Adds a callback to SyncerThread2::Start to learn when config mode has started.

Makes ConfigureDataTypes asynchronous to allow waiting for config mode to have started.

As a result of this, passing --new-syncer-thread on the command line actually works and doesn't crash (too much!)

BUG=26339
TEST=SyncerThread2Test

Review URL: http://codereview.chromium.org/6690020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79717 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 3 insertions, 8 deletions

diff --git a/chrome/browser/sync/engine/syncer.cc b/chrome/browser/sync/engine/syncer.cc
index ac20600..2f24ee1 100644
--- a/chrome/browser/sync/engine/syncer.cc
+++ b/chrome/browser/sync/engine/syncer.cc
@@ -271,9 +271,6 @@ void Syncer::SyncShare(sessions::SyncSession* session,
         break;
       }
       case SYNCER_END: {
-        VLOG(1) << "Syncer End";
-        SyncerEndCommand syncer_end_command;
-        syncer_end_command.Execute(session);
         break;
       }
       default:
@@ -284,11 +281,9 @@ void Syncer::SyncShare(sessions::SyncSession* session,
     current_step = next_step;
   }
 
-  // Always send out a cycle ended notification, regardless of end-state.
-  SyncEngineEvent event(SyncEngineEvent::SYNC_CYCLE_ENDED);
-  sessions::SyncSessionSnapshot snapshot(session->TakeSnapshot());
-  event.snapshot = &snapshot;
-  session->context()->NotifyListeners(event);
+  VLOG(1) << "Syncer End";
+  SyncerEndCommand syncer_end_command;
+  syncer_end_command.Execute(session);
   return;
 }