diff options
| author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 02:24:12 +0000 |
|---|---|---|
| committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-24 02:24:12 +0000 |
| commit | 0ac41f8a150b37c05c0a11197739903e0edaa5d5 (patch) | |
| tree | 5dc36b472ad4353bc673215a59646da9fbe7d62c /chrome/browser/sync/engine | |
| parent | bdc60ef5041b81690e2e74b053ca6a8926bff0a1 (diff) | |
| download | chromium_src-0ac41f8a150b37c05c0a11197739903e0edaa5d5.zip chromium_src-0ac41f8a150b37c05c0a11197739903e0edaa5d5.tar.gz chromium_src-0ac41f8a150b37c05c0a11197739903e0edaa5d5.tar.bz2 | |
Remove a TODO in post_commit_command.cc. Clarify what's going on.
Review URL: http://codereview.chromium.org/431023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32904 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync/engine')
| -rw-r--r-- | chrome/browser/sync/engine/post_commit_message_command.cc | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/chrome/browser/sync/engine/post_commit_message_command.cc b/chrome/browser/sync/engine/post_commit_message_command.cc index 1db6078..9136df7 100644 --- a/chrome/browser/sync/engine/post_commit_message_command.cc +++ b/chrome/browser/sync/engine/post_commit_message_command.cc @@ -30,12 +30,13 @@ void PostCommitMessageCommand::ExecuteImpl(sessions::SyncSession* session) { sessions::StatusController* status = session->status_controller(); if (!SyncerProtoUtil::PostClientToServerMessage( status->mutable_commit_message(), &response, session)) { - // None of our changes got through, let's clear sync flags and wait for - // another list update. + // None of our changes got through. Clear the SYNCING bit which was + // set to true during BuildCommitCommand, and which may still be true. + // Not to be confused with IS_UNSYNCED. This bit is used to detect local + // changes to items that happen during the server Commit operation. status->increment_num_consecutive_problem_commits(); status->increment_num_consecutive_errors(); syncable::WriteTransaction trans(dir, syncable::SYNCER, __FILE__, __LINE__); - // TODO(sync): why set this flag, it seems like a bad side-effect? const vector<syncable::Id>& commit_ids = status->commit_ids(); for (size_t i = 0; i < commit_ids.size(); i++) { syncable::MutableEntry entry(&trans, syncable::GET_BY_ID, commit_ids[i]); |