summaryrefslogtreecommitdiffstats
path: root/chrome/browser/sync/internal_api/sync_manager.cc
diff options
context:
space:
mode:
authorscottbyer@chromium.org <scottbyer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-03 19:59:20 +0000
committerscottbyer@chromium.org <scottbyer@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-02-03 19:59:20 +0000
commit328f2b662cc1fc069c55b6300b9abde16d0b9836 (patch)
treeebd66731a5178a4bf975b18a8f6740eb8aac7ac3 /chrome/browser/sync/internal_api/sync_manager.cc
parentace755e41c672f58d34c72503460618037e8344b (diff)
downloadchromium_src-328f2b662cc1fc069c55b6300b9abde16d0b9836.zip
chromium_src-328f2b662cc1fc069c55b6300b9abde16d0b9836.tar.gz
chromium_src-328f2b662cc1fc069c55b6300b9abde16d0b9836.tar.bz2
Re-enable newly de-flaked test.
This test was disabled because it became flaky and eventually continually timed out. After investigation, including being able to repro the original problem in an XP VM, I tracked the problem back to a race condition where the ESC that closes the dialog can sometimes cause that dialog to be closed before the ESC event ACK is sent back, thus the test was hanging until timeout. That is filed as http://code.google.com/p/chromium/issues/detail?id=111269 but it's low priority since it's really a test-only issue (and only for this test AFAICT). This test will still fail on Windows if the browser isn't the front window (there are a number of browser and interactive tests with this issue; see http://code.google.com/p/chromium/issues/detail?id=106498). For this test part of it is that the SendKeyPress on Windows doesn't target a window with the event - the event always goes to the front window, even if that's not the correct place. BUG=94864, 111269 TEST=Crank up a slow XP VM, load up the CPU (I used HeavyLoad), run the test lots (I used a repeat of 100). Before clobber, problem almost right away. After, no problem. Review URL: http://codereview.chromium.org/9310016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120374 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync/internal_api/sync_manager.cc')
0 files changed, 0 insertions, 0 deletions