diff options
| author | lipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-06 00:09:36 +0000 |
|---|---|---|
| committer | lipalani@chromium.org <lipalani@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-06 00:09:36 +0000 |
| commit | cd2ec4bce32b559b5daa47de815a31fc6d469517 (patch) | |
| tree | 2fd8e924c01c05a32889ad91b31c5adb09881ca1 /chrome/browser/sync/profile_sync_service.h | |
| parent | 21942192906ea1fe88dde43a0d34fee79d68f97d (diff) | |
| download | chromium_src-cd2ec4bce32b559b5daa47de815a31fc6d469517.zip chromium_src-cd2ec4bce32b559b5daa47de815a31fc6d469517.tar.gz chromium_src-cd2ec4bce32b559b5daa47de815a31fc6d469517.tar.bz2 | |
Fixing the crash in about:sync code. This was caused by a race condition.
BUG=65370
TEST=
Review URL: http://codereview.chromium.org/6074006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70561 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync/profile_sync_service.h')
| -rw-r--r-- | chrome/browser/sync/profile_sync_service.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h index 19583b6..de66ec8 100644 --- a/chrome/browser/sync/profile_sync_service.h +++ b/chrome/browser/sync/profile_sync_service.h @@ -230,6 +230,10 @@ class ProfileSyncService : public browser_sync::SyncFrontend, // Returns true if the SyncBackendHost has told us it's ready to accept // changes. + // [REMARK] - it is safe to call this function only from the ui thread. + // because the variable is not thread safe and should only be accessed from + // single thread. If we want multiple threads to access this(and there is + // currently no need to do so) we need to protect this with a lock. // TODO(timsteele): What happens if the bookmark model is loaded, a change // takes place, and the backend isn't initialized yet? bool sync_initialized() const { return backend_initialized_; } |