diff options
author | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-24 23:32:41 +0000 |
---|---|---|
committer | akalin@chromium.org <akalin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-01-24 23:32:41 +0000 |
commit | 420914939dd9d240be781df2492bdcd87e553973 (patch) | |
tree | 33892ace8cccde81b850019f8bf43c67b0887b80 /chrome/browser/sync/sync_ui_util.cc | |
parent | 6ea03316725dfd38af1f507dba623e807b762580 (diff) | |
download | chromium_src-420914939dd9d240be781df2492bdcd87e553973.zip chromium_src-420914939dd9d240be781df2492bdcd87e553973.tar.gz chromium_src-420914939dd9d240be781df2492bdcd87e553973.tar.bz2 |
[Sync] Refactored ProfileSyncService and remove its backend() function
Moved bodies of test functions into .cc files.
Remove sync_service() accessors from various model associators.
Renamed GetUserShareHandle to GetUserShare() and removed typedefs for its return types.
Added plenty of TODOs for future improvements.
BUG=None
TEST=unit_tests
Review URL: http://codereview.chromium.org/6375007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72419 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/sync/sync_ui_util.cc')
-rw-r--r-- | chrome/browser/sync/sync_ui_util.cc | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/chrome/browser/sync/sync_ui_util.cc b/chrome/browser/sync/sync_ui_util.cc index e1ac70f..f23fe75 100644 --- a/chrome/browser/sync/sync_ui_util.cc +++ b/chrome/browser/sync/sync_ui_util.cc @@ -406,13 +406,9 @@ void ConstructAboutInformation(ProfileSyncService* service, strings->SetString("unrecoverable_error_location", location_str); } else if (!service->sync_initialized()) { strings->SetString("summary", "Sync not yet initialized"); - } else if (service->backend() == NULL) { - strings->SetString("summary", - "Unrecoverable error detected. Backend is null when it shouldnt be"); - NOTREACHED(); } else { browser_sync::ModelSafeRoutingInfo routes; - service->backend()->GetModelSafeRoutingInfo(&routes); + service->GetModelSafeRoutingInfo(&routes); ListValue* routing_info = new ListValue(); strings->Set("routing_info", routing_info); browser_sync::ModelSafeRoutingInfo::const_iterator it = routes.begin(); @@ -425,10 +421,10 @@ void ConstructAboutInformation(ProfileSyncService* service, sync_ui_util::AddBoolSyncDetail(details, "Autofill Migrated", - service->backend()->GetAutofillMigrationState() == + service->GetAutofillMigrationState() == syncable::MIGRATED); syncable::AutofillMigrationDebugInfo info = - service->backend()->GetAutofillMigrationDebugInfo(); + service->GetAutofillMigrationDebugInfo(); sync_ui_util::AddIntSyncDetail(details, "Bookmarks created during migration", |