Cleanup everything but net/ for our first clang plugins.

BUG=none
TEST=compiles

Review URL: http://codereview.chromium.org/6250088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73396 0039d316-1c4b-4281-b951-d872f2087c98

6 files changed, 19 insertions, 8 deletions

diff --git a/chrome/browser/sync/engine/syncer_thread.cc b/chrome/browser/sync/engine/syncer_thread.cc
index 20ea665..ee45cca 100644
--- a/chrome/browser/sync/engine/syncer_thread.cc
+++ b/chrome/browser/sync/engine/syncer_thread.cc
@@ -56,6 +56,16 @@ static const int kBackoffRandomizationFactor = 2;
 
 const int SyncerThread::kMaxBackoffSeconds = 60 * 60 * 4;  // 4 hours.
 
+SyncerThread::ProtectedFields::ProtectedFields()
+        : stop_syncer_thread_(false),
+          pause_requested_(false),
+          paused_(false),
+          syncer_(NULL),
+          connected_(false),
+          pending_nudge_source_(kUnknown) {}
+
+SyncerThread::ProtectedFields::~ProtectedFields() {}
+
 void SyncerThread::NudgeSyncerWithPayloads(
     int milliseconds_from_now,
     NudgeSource source,
diff --git a/chrome/browser/sync/engine/syncer_thread.h b/chrome/browser/sync/engine/syncer_thread.h
index 122e5df..b8bf724 100644
--- a/chrome/browser/sync/engine/syncer_thread.h
+++ b/chrome/browser/sync/engine/syncer_thread.h
@@ -181,6 +181,9 @@ class SyncerThread : public base::RefCountedThreadSafe<SyncerThread>,
   // Fields that are modified / accessed by multiple threads go in this struct
   // for clarity and explicitness.
   struct ProtectedFields {
+    ProtectedFields();
+    ~ProtectedFields();
+
     // False when we want to stop the thread.
     bool stop_syncer_thread_;
 
@@ -217,14 +220,6 @@ class SyncerThread : public base::RefCountedThreadSafe<SyncerThread>,
     // really need to access mutually exclusively as the data races that exist
     // are intrinsic, but do so anyway and avoid using 'volatile'.
     WaitInterval current_wait_interval_;
-
-    ProtectedFields()
-        : stop_syncer_thread_(false),
-          pause_requested_(false),
-          paused_(false),
-          syncer_(NULL),
-          connected_(false),
-          pending_nudge_source_(kUnknown) {}
   } vault_;
 
   // Gets signaled whenever a thread outside of the syncer thread changes a
diff --git a/chrome/browser/sync/js_arg_list.cc b/chrome/browser/sync/js_arg_list.cc
index 538b07c..23165a3 100644
--- a/chrome/browser/sync/js_arg_list.cc
+++ b/chrome/browser/sync/js_arg_list.cc
@@ -17,6 +17,8 @@ JsArgList::JsArgList(const ListValue& args)
 JsArgList::JsArgList(const std::vector<const Value*>& args)
     : args_(new SharedListValue(args)) {}
 
+JsArgList::~JsArgList() {}
+
 const ListValue& JsArgList::Get() const {
   return args_->Get();
 }
diff --git a/chrome/browser/sync/js_arg_list.h b/chrome/browser/sync/js_arg_list.h
index 80ea55e..66d1b21 100644
--- a/chrome/browser/sync/js_arg_list.h
+++ b/chrome/browser/sync/js_arg_list.h
@@ -23,6 +23,7 @@ class JsArgList {
   JsArgList();
   explicit JsArgList(const ListValue& args);
   explicit JsArgList(const std::vector<const Value*>& args);
+  ~JsArgList();
 
   const ListValue& Get() const;
 
diff --git a/chrome/browser/sync/sessions/session_state.cc b/chrome/browser/sync/sessions/session_state.cc
index 112dc2f..3c9887b 100644
--- a/chrome/browser/sync/sessions/session_state.cc
+++ b/chrome/browser/sync/sessions/session_state.cc
@@ -61,6 +61,8 @@ SyncSourceInfo::SyncSourceInfo(
     const TypePayloadMap& t)
     : updates_source(u), types(t) {}
 
+SyncSourceInfo::~SyncSourceInfo() {}
+
 SyncerStatus::SyncerStatus()
     : invalid_store(false),
       syncer_stuck(false),
diff --git a/chrome/browser/sync/sessions/session_state.h b/chrome/browser/sync/sessions/session_state.h
index a656316..d1a6e17 100644
--- a/chrome/browser/sync/sessions/session_state.h
+++ b/chrome/browser/sync/sessions/session_state.h
@@ -60,6 +60,7 @@ struct SyncSourceInfo {
   SyncSourceInfo(
       const sync_pb::GetUpdatesCallerInfo::GetUpdatesSource& u,
       const TypePayloadMap& t);
+  ~SyncSourceInfo();
 
   sync_pb::GetUpdatesCallerInfo::GetUpdatesSource updates_source;
   TypePayloadMap types;