diff options
| author | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-28 01:47:58 +0000 |
|---|---|---|
| committer | jcampan@chromium.org <jcampan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-28 01:47:58 +0000 |
| commit | 616f9cd2cd3e43d95c8d90fe01dc4241b2a5b08c (patch) | |
| tree | 14e83aab507cb436076f2ba6977c0021bb2be09e /chrome/browser/tab_contents/interstitial_page.cc | |
| parent | 77e9fcf0815dbe8853a09b894560ba6c1feaf487 (diff) | |
| download | chromium_src-616f9cd2cd3e43d95c8d90fe01dc4241b2a5b08c.zip chromium_src-616f9cd2cd3e43d95c8d90fe01dc4241b2a5b08c.tar.gz chromium_src-616f9cd2cd3e43d95c8d90fe01dc4241b2a5b08c.tar.bz2 | |
A crash report from the field reports that we are removing a SafeBrowsingBlockingPage from a global map that is not to be found causing a stl exception to be thrown.
I am not sure what the cause is yet, my investigations results are in the bug comment.
This is a work-around the crasher while I keep investigating.
BUG=9442
TEST=Access a page which contains sub-resource malware.
Review URL: http://codereview.chromium.org/49049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12732 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents/interstitial_page.cc')
| -rw-r--r-- | chrome/browser/tab_contents/interstitial_page.cc | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/chrome/browser/tab_contents/interstitial_page.cc b/chrome/browser/tab_contents/interstitial_page.cc index 32fe0b6..aa37c94 100644 --- a/chrome/browser/tab_contents/interstitial_page.cc +++ b/chrome/browser/tab_contents/interstitial_page.cc @@ -126,8 +126,11 @@ InterstitialPage::InterstitialPage(WebContents* tab, InterstitialPage::~InterstitialPage() { InterstitialPageMap::iterator iter = tab_to_interstitial_page_->find(tab_); - DCHECK(iter != tab_to_interstitial_page_->end()); - tab_to_interstitial_page_->erase(iter); + DCHECK(iter != tab_to_interstitial_page_->end()) << + "InterstitialPage missing from map. Please add a comment to the bug " + "http://crbug.com/9442 with the URL you were visiting"; + if (iter != tab_to_interstitial_page_->end()) + tab_to_interstitial_page_->erase(iter); DCHECK(!render_view_host_); } |