diff options
| author | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
|---|---|---|
| committer | sky@chromium.org <sky@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-09-25 18:09:37 +0000 |
| commit | 8030f01f1f6e77e0ba72c591680a546da82f21f9 (patch) | |
| tree | f643e742dcc2ccca5da232c1c7d6964b20a79090 /chrome/browser/tab_contents/navigation_controller.h | |
| parent | cdacb88cb3d3b11f21caae229816a68cab3170b2 (diff) | |
| download | chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.zip chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.gz chromium_src-8030f01f1f6e77e0ba72c591680a546da82f21f9.tar.bz2 | |
Makes it so that you shouldn't be able to get a big fat bookmark
bar. This happened because when we changed from needing a
bookmarkbar/extension-shelf to not needing one we processed the layout
change asynchronously, but could paint immediately and painting always
checks the current state. I initially made painting/layout stay in
sync with regards to whether they thought the bookmark bar should be
shown, which also fixes this, but because we process the change async
there was still some noticable jank. Instead I've changed processing
of the transition from needing bars to not (or vice-versa) to be
synchronous.
BUG=22165
TEST=see bug
Review URL: http://codereview.chromium.org/219034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27218 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents/navigation_controller.h')
| -rw-r--r-- | chrome/browser/tab_contents/navigation_controller.h | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/chrome/browser/tab_contents/navigation_controller.h b/chrome/browser/tab_contents/navigation_controller.h index 3d0d6cd..7374d38 100644 --- a/chrome/browser/tab_contents/navigation_controller.h +++ b/chrome/browser/tab_contents/navigation_controller.h @@ -314,7 +314,11 @@ class NavigationController { // // In the case that nothing has changed, the details structure is undefined // and it will return false. + // + // |extra_invalidate_flags| are an additional set of flags (InvalidateTypes) + // added to the flags sent to the delegate's NotifyNavigationStateChanged. bool RendererDidNavigate(const ViewHostMsg_FrameNavigate_Params& params, + int extra_invalidate_flags, LoadCommittedDetails* details); // Notifies us that we just became active. This is used by the TabContents @@ -417,7 +421,11 @@ class NavigationController { // Allows the derived class to issue notifications that a load has been // committed. This will fill in the active entry to the details structure. - void NotifyNavigationEntryCommitted(LoadCommittedDetails* details); + // + // |extra_invalidate_flags| are an additional set of flags (InvalidateTypes) + // added to the flags sent to the delegate's NotifyNavigationStateChanged. + void NotifyNavigationEntryCommitted(LoadCommittedDetails* details, + int extra_invalidate_flags); // Sets the max restored page ID this NavigationController has seen, if it // was restored from a previous session. |