diff options
author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 22:13:55 +0000 |
---|---|---|
committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-14 22:13:55 +0000 |
commit | 9423d941cb200b789d482895ac644fe38d6bc048 (patch) | |
tree | 3e82d246d3ce5a1bb4eeade7a1aebff27748814d /chrome/browser/tab_contents/tab_contents.h | |
parent | 127788d038548a56be833f863c9936714f6452cb (diff) | |
download | chromium_src-9423d941cb200b789d482895ac644fe38d6bc048.zip chromium_src-9423d941cb200b789d482895ac644fe38d6bc048.tar.gz chromium_src-9423d941cb200b789d482895ac644fe38d6bc048.tar.bz2 |
Remove the TestTabContents. This makes BrowserWithTestWindow use the
TestRenderViewHost instead. There are some changes to browser_commands_unittest
to support this. Now that we're using proper TabContentes, I had to stub out
a FocusManager call since there isn't a proper view hierarchy created.
Remove TabContents collection and switching from the NavigationController. I
tried to keep the same interface to the NavigationController since I tried that
in a previous patch and the change blew up.
Remove the TabContents factory. Callers now create a WebContents directly.
Review URL: http://codereview.chromium.org/67113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13707 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents/tab_contents.h')
-rw-r--r-- | chrome/browser/tab_contents/tab_contents.h | 24 |
1 files changed, 1 insertions, 23 deletions
diff --git a/chrome/browser/tab_contents/tab_contents.h b/chrome/browser/tab_contents/tab_contents.h index e013bdb..7ccc275 100644 --- a/chrome/browser/tab_contents/tab_contents.h +++ b/chrome/browser/tab_contents/tab_contents.h @@ -80,28 +80,6 @@ class TabContents : public PageNavigator, static void RegisterUserPrefs(PrefService* prefs); - // Factory ------------------------------------------------------------------- - // (implemented in tab_contents_factory.cc) - - // Creates a new TabContents of the given type. Will reuse the given - // instance's renderer, if it is not null. The given render view host factory - // will be passed to the new TabContents (it may be NULL). - static TabContents* CreateWithType(TabContentsType type, - Profile* profile, - SiteInstance* instance); - - // Returns the type of TabContents needed to handle the URL. |url| may - // end up being modified to contain the _real_ url being loaded if the - // parameter was an alias (such as about: urls and chrome- urls). - static TabContentsType TypeForURL(GURL* url); - - // This method can be used to register a new TabContents type dynamically, - // which can be very useful for unit testing. If factory is null, then the - // tab contents type is unregistered. Returns the previously registered - // factory for the given type or null if there was none. - static TabContentsFactory* RegisterFactory(TabContentsType type, - TabContentsFactory* factory); - // Creation & destruction ---------------------------------------------------- // Request this tab to shut down. This kills the tab's NavigationController, @@ -365,7 +343,7 @@ class TabContents : public PageNavigator, } // Make the tab the focused window. - virtual void Focus(); + virtual void Focus() = 0; // Invoked the first time this tab is getting the focus through TAB traversal. // By default this does nothing, but is overridden to set the focus for the |