This is the second side of a multi-sided webkit patch that will allow experimental window.open feature strings to be captured and passed to the client.

It should wait for: https://bugs.webkit.org/show_bug.cgi?id=38013 to land. This is required because this patch needs to use the WebWindowFeature binding struct in WebKit.

Once this is landed, a webkit patch to change the call signature for WebViewClient::createView to include the WebWindowFeatures will be submitted (and after that another chromium patch to remove the old call signature).

This patch implements old and new WebViewClient::createView signatures, and additionally passes the vector all the way to RenderViewHostDelegateHelper who will eventually use it to observe the 'background' feature.

BUG=41275
TEST=all tests should pass

Review URL: http://codereview.chromium.org/1758004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45877 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 3 deletions

diff --git a/chrome/browser/tab_contents/tab_contents_view.cc b/chrome/browser/tab_contents/tab_contents_view.cc
index bce9a50..b6d45a0 100644
--- a/chrome/browser/tab_contents/tab_contents_view.cc
+++ b/chrome/browser/tab_contents/tab_contents_view.cc
@@ -30,10 +30,13 @@ void TabContentsView::UpdatePreferredSize(const gfx::Size& pref_size) {
   preferred_width_ = pref_size.width();
 }
 
-void TabContentsView::CreateNewWindow(int route_id) {
-  TabContents* new_contents = delegate_view_helper_.CreateNewWindow(
+void TabContentsView::CreateNewWindow(
+    int route_id,
+    WindowContainerType window_container_type) {
+    TabContents* new_contents = delegate_view_helper_.CreateNewWindow(
       route_id, tab_contents_->profile(), tab_contents_->GetSiteInstance(),
-      DOMUIFactory::GetDOMUIType(tab_contents_->GetURL()), tab_contents_);
+      DOMUIFactory::GetDOMUIType(tab_contents_->GetURL()), tab_contents_,
+      window_container_type);
 
   if (tab_contents_->delegate())
     tab_contents_->delegate()->TabContentsCreated(new_contents);