diff options
author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-19 18:27:09 +0000 |
---|---|---|
committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-19 18:27:09 +0000 |
commit | 810e622b58b4da015c11e8b6c71f3e95b23afe1b (patch) | |
tree | 56c0cf5e6ab1e6ea3f0a4a5cc8c26d0cd651d24f /chrome/browser/tab_contents | |
parent | f38b16fd2753b2d603e0a2a137227a132c77057b (diff) | |
download | chromium_src-810e622b58b4da015c11e8b6c71f3e95b23afe1b.zip chromium_src-810e622b58b4da015c11e8b6c71f3e95b23afe1b.tar.gz chromium_src-810e622b58b4da015c11e8b6c71f3e95b23afe1b.tar.bz2 |
Fix inspection of extensions.
As a bonus, debugging of extensions now works. Go OOP inspector team!
Inspection code was calling RVHD::GetProfile(), which was not implemented by ExtensionHost. Looking into this, it seems better to just remove the method from the interface since Profile is already accessible by way of RVH.
The only caller to RVHD::GetProfile() besides the inspector was HWNDHtmlView which is itself dead code, so I removed it too.
Review URL: http://codereview.chromium.org/115501
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16392 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
-rw-r--r-- | chrome/browser/tab_contents/interstitial_page.cc | 4 | ||||
-rw-r--r-- | chrome/browser/tab_contents/interstitial_page.h | 1 | ||||
-rw-r--r-- | chrome/browser/tab_contents/tab_contents.cc | 4 | ||||
-rw-r--r-- | chrome/browser/tab_contents/tab_contents.h | 1 |
4 files changed, 0 insertions, 10 deletions
diff --git a/chrome/browser/tab_contents/interstitial_page.cc b/chrome/browser/tab_contents/interstitial_page.cc index f697488..2f644e9 100644 --- a/chrome/browser/tab_contents/interstitial_page.cc +++ b/chrome/browser/tab_contents/interstitial_page.cc @@ -366,10 +366,6 @@ void InterstitialPage::SetInitialFocus(bool reverse) { render_view_host_->SetInitialFocus(reverse); } -Profile* InterstitialPage::GetProfile() const { - return tab_->profile(); -} - void InterstitialPage::DidNavigate( RenderViewHost* render_view_host, const ViewHostMsg_FrameNavigate_Params& params) { diff --git a/chrome/browser/tab_contents/interstitial_page.h b/chrome/browser/tab_contents/interstitial_page.h index c5f4afe..5ce1e9e 100644 --- a/chrome/browser/tab_contents/interstitial_page.h +++ b/chrome/browser/tab_contents/interstitial_page.h @@ -90,7 +90,6 @@ class InterstitialPage : public NotificationObserver, const NotificationDetails& details); // RenderViewHostDelegate implementation: - virtual Profile* GetProfile() const; virtual const GURL& GetURL() const { return url_; } virtual WebPreferences GetWebkitPrefs() { return WebPreferences(); diff --git a/chrome/browser/tab_contents/tab_contents.cc b/chrome/browser/tab_contents/tab_contents.cc index 9e74eaf..c136625 100644 --- a/chrome/browser/tab_contents/tab_contents.cc +++ b/chrome/browser/tab_contents/tab_contents.cc @@ -1598,10 +1598,6 @@ RenderViewHostDelegate::Save* TabContents::GetSaveDelegate() const { return save_package_.get(); // May be NULL, but we can return NULL. } -Profile* TabContents::GetProfile() const { - return profile(); -} - ExtensionFunctionDispatcher* TabContents::CreateExtensionFunctionDispatcher( RenderViewHost* render_view_host, const std::string& extension_id) { diff --git a/chrome/browser/tab_contents/tab_contents.h b/chrome/browser/tab_contents/tab_contents.h index 3b749e6..9667c70 100644 --- a/chrome/browser/tab_contents/tab_contents.h +++ b/chrome/browser/tab_contents/tab_contents.h @@ -732,7 +732,6 @@ class TabContents : public PageNavigator, virtual RenderViewHostDelegate::View* GetViewDelegate() const; virtual RenderViewHostDelegate::Save* GetSaveDelegate() const; - virtual Profile* GetProfile() const; virtual ExtensionFunctionDispatcher *CreateExtensionFunctionDispatcher( RenderViewHost* render_view_host, const std::string& extension_id); |