summaryrefslogtreecommitdiffstats
path: root/chrome/browser/tab_contents
diff options
context:
space:
mode:
authorscherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-12 19:52:44 +0000
committerscherkus@chromium.org <scherkus@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-12 19:52:44 +0000
commite626d7f115a1319421d1e2d5da85b6f0bd66877f (patch)
treecd6c50923fbb063c1980315c2db5447fbfee0086 /chrome/browser/tab_contents
parentf1f188943ba5fd66cc54c813d9ed27596a7b29e9 (diff)
downloadchromium_src-e626d7f115a1319421d1e2d5da85b6f0bd66877f.zip
chromium_src-e626d7f115a1319421d1e2d5da85b6f0bd66877f.tar.gz
chromium_src-e626d7f115a1319421d1e2d5da85b6f0bd66877f.tar.bz2
Remove Playback Rate from the context menu.
This feature is better implemented as an extension rather than being put into the absolute-core UI. Review URL: http://codereview.chromium.org/164301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
-rw-r--r--chrome/browser/tab_contents/render_view_context_menu.cc91
1 files changed, 0 insertions, 91 deletions
diff --git a/chrome/browser/tab_contents/render_view_context_menu.cc b/chrome/browser/tab_contents/render_view_context_menu.cc
index 8aa9beb..40cc054 100644
--- a/chrome/browser/tab_contents/render_view_context_menu.cc
+++ b/chrome/browser/tab_contents/render_view_context_menu.cc
@@ -29,15 +29,6 @@
#include "net/base/escape.h"
#include "net/base/net_util.h"
-// Constants for the standard playback rates provided by the context
-// menu. If another rate is reported, it will be considered unknown and
-// no rate will be selected in the submenu.
-static const double kSlowPlaybackRate = 0.5f;
-static const double kNormalPlaybackRate = 1.0f;
-static const double kFastPlaybackRate = 1.25f;
-static const double kFasterPlaybackRate = 1.50f;
-static const double kDoubleTimePlaybackRate = 2.0f;
-
RenderViewContextMenu::RenderViewContextMenu(
TabContents* tab_contents,
const ContextMenuParams& params)
@@ -155,20 +146,6 @@ void RenderViewContextMenu::AppendMediaItems(
AppendCheckboxMenuItem(IDS_CONTENT_CONTEXT_LOOP,
l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_LOOP));
-
- StartSubMenu(IDS_CONTENT_CONTEXT_PLAYBACKRATE_MENU,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_MENU));
- AppendRadioMenuItem(IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW));
- AppendRadioMenuItem(IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL));
- AppendRadioMenuItem(IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST));
- AppendRadioMenuItem(IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER));
- AppendRadioMenuItem(IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME,
- l10n_util::GetStringUTF16(IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME));
- FinishSubMenu();
}
void RenderViewContextMenu::AppendPageItems() {
@@ -342,12 +319,6 @@ bool RenderViewContextMenu::IsItemCommandEnabled(int id) const {
case IDS_CONTENT_CONTEXT_MUTE:
case IDS_CONTENT_CONTEXT_UNMUTE:
case IDS_CONTENT_CONTEXT_LOOP:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_MENU:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER:
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME:
return (params_.media_params.player_state &
ContextMenuMediaParams::IN_ERROR) == 0;
@@ -435,23 +406,6 @@ bool RenderViewContextMenu::IsItemCommandEnabled(int id) const {
}
bool RenderViewContextMenu::ItemIsChecked(int id) const {
- // Select the correct playback rate.
- if (id == IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW) {
- return params_.media_params.playback_rate == kSlowPlaybackRate;
- }
- if (id == IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL) {
- return params_.media_params.playback_rate == kNormalPlaybackRate;
- }
- if (id == IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST) {
- return params_.media_params.playback_rate == kFastPlaybackRate;
- }
- if (id == IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER) {
- return params_.media_params.playback_rate == kFasterPlaybackRate;
- }
- if (id == IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME) {
- return params_.media_params.playback_rate == kDoubleTimePlaybackRate;
- }
-
// See if the video is set to looping.
if (id == IDS_CONTENT_CONTEXT_LOOP) {
return (params_.media_params.player_state &
@@ -581,51 +535,6 @@ void RenderViewContextMenu::ExecuteItemCommand(int id) {
}
break;
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_SLOW:
- UserMetrics::RecordAction(L"MediaContextMenu_RateSlow", profile_);
- MediaPlayerActionAt(
- params_.x,
- params_.y,
- MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
- kSlowPlaybackRate));
- break;
-
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_NORMAL:
- UserMetrics::RecordAction(L"MediaContextMenu_RateNormal", profile_);
- MediaPlayerActionAt(
- params_.x,
- params_.y,
- MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
- kNormalPlaybackRate));
- break;
-
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FAST:
- UserMetrics::RecordAction(L"MediaContextMenu_RateFast", profile_);
- MediaPlayerActionAt(
- params_.x,
- params_.y,
- MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
- kFastPlaybackRate));
- break;
-
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_FASTER:
- UserMetrics::RecordAction(L"MediaContextMenu_RateFaster", profile_);
- MediaPlayerActionAt(
- params_.x,
- params_.y,
- MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
- kFasterPlaybackRate));
- break;
-
- case IDS_CONTENT_CONTEXT_PLAYBACKRATE_DOUBLETIME:
- UserMetrics::RecordAction(L"MediaContextMenu_RateDoubleTime", profile_);
- MediaPlayerActionAt(
- params_.x,
- params_.y,
- MediaPlayerAction(MediaPlayerAction::SET_PLAYBACK_RATE,
- kDoubleTimePlaybackRate));
- break;
-
case IDS_CONTENT_CONTEXT_BACK:
source_tab_contents_->controller().GoBack();
break;