diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 16:19:54 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-05-22 16:19:54 +0000 |
| commit | 322f3ffc4edcc572adbc0a3657a16315a1846c51 (patch) | |
| tree | 9e847beb06fbebc8ade32dc9908c78e655051cf7 /chrome/browser/tab_contents | |
| parent | 97037a1032478f976048762aed86d963dc531c2f (diff) | |
| download | chromium_src-322f3ffc4edcc572adbc0a3657a16315a1846c51.zip chromium_src-322f3ffc4edcc572adbc0a3657a16315a1846c51.tar.gz chromium_src-322f3ffc4edcc572adbc0a3657a16315a1846c51.tar.bz2 | |
Move a bunch of dialog creation routines to browser_dialogs.h to break the
dependency on the implementations of those views.
This also moves that file into the browser:: namespace to avoid having all the
functions in the global namespace.
Rename the "parent" parameter to ShowHTMLDialog to a NativeWindow type to
avoid nasty casting. I assume this argument was written before we had
NativeWindow.
Review URL: http://codereview.chromium.org/113728
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16743 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_contents')
| -rw-r--r-- | chrome/browser/tab_contents/tab_contents_delegate.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/tab_contents/tab_contents_delegate.h b/chrome/browser/tab_contents/tab_contents_delegate.h index 4ba9553..e937fec 100644 --- a/chrome/browser/tab_contents/tab_contents_delegate.h +++ b/chrome/browser/tab_contents/tab_contents_delegate.h @@ -6,6 +6,7 @@ #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_DELEGATE_H_ #include "base/basictypes.h" +#include "base/gfx/native_widget_types.h" #include "base/gfx/rect.h" #include "chrome/common/page_transition_types.h" #include "webkit/glue/window_open_disposition.h" @@ -120,7 +121,7 @@ class TabContentsDelegate { // string input to use during initialization). |parent_window| is the window // that should be parent of the dialog, or NULL for the default. virtual void ShowHtmlDialog(HtmlDialogUIDelegate* delegate, - void* parent_window) { } + gfx::NativeWindow parent_window) { } // Tells us that we've finished firing this tab's beforeunload event. // The proceed bool tells us whether the user chose to proceed closing the |