diff options
| author | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 10:21:27 +0000 |
|---|---|---|
| committer | phajdan.jr@chromium.org <phajdan.jr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-03-30 10:21:27 +0000 |
| commit | 0e60b64fcae0a0f21982bc42e0e608c8d44b12c1 (patch) | |
| tree | 5ec1f7dfc5a1955d370ef071abba840c4054271d /chrome/browser/tab_restore_uitest.cc | |
| parent | 80de4fa5861be1171ad502eba157570839601086 (diff) | |
| download | chromium_src-0e60b64fcae0a0f21982bc42e0e608c8d44b12c1.zip chromium_src-0e60b64fcae0a0f21982bc42e0e608c8d44b12c1.tar.gz chromium_src-0e60b64fcae0a0f21982bc42e0e608c8d44b12c1.tar.bz2 | |
[GTTF] Miscellanous UI tests cleanups:
- use built-in timeouts instead of "inventing" them in each test case
- avoid unneeded checks and operations
- use automation calls more effectively
- use FLAKY mark instead of DISABLED to maintain test coverage
- split some tests to make the above possible
TEST=UI test based
BUG=39785
Review URL: http://codereview.chromium.org/1547003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43070 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tab_restore_uitest.cc')
| -rw-r--r-- | chrome/browser/tab_restore_uitest.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/chrome/browser/tab_restore_uitest.cc b/chrome/browser/tab_restore_uitest.cc index 56ff39f..ebc6f09 100644 --- a/chrome/browser/tab_restore_uitest.cc +++ b/chrome/browser/tab_restore_uitest.cc @@ -98,14 +98,10 @@ class TabRestoreUITest : public UITest { // the final number of tabs. int AddSomeTabs(BrowserProxy* browser, int how_many) { int starting_tab_count = -1; - // Use EXPECT instead of ASSERT throughout to avoid trying to return void. EXPECT_TRUE(browser->GetTabCount(&starting_tab_count)); for (int i = 0; i < how_many; ++i) { EXPECT_TRUE(browser->AppendTab(url1_)); - int current_tab_count; - EXPECT_TRUE(browser->GetTabCount(¤t_tab_count)); - EXPECT_EQ(starting_tab_count + i + 1, current_tab_count); } int tab_count; EXPECT_TRUE(browser->GetTabCount(&tab_count)); |