diff options
author | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-18 19:24:57 +0000 |
---|---|---|
committer | mpcomplete@chromium.org <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-10-18 19:24:57 +0000 |
commit | 9288808841602769a316568cb6d14ed6b6d988dc (patch) | |
tree | d77d11fcbd565e5a47eb259692d7fa531a944866 /chrome/browser/tabs | |
parent | 3bb720fd99938e6cbe30c83f7549e51c9065b38b (diff) | |
download | chromium_src-9288808841602769a316568cb6d14ed6b6d988dc.zip chromium_src-9288808841602769a316568cb6d14ed6b6d988dc.tar.gz chromium_src-9288808841602769a316568cb6d14ed6b6d988dc.tar.bz2 |
Move the rest of the Extension data into either StaticData or RuntimeData
subclasses.
The ultimate goal is to move StaticData back up to the top level, so that
Extension itself will be a thread-safe immutable object. I plan on making Extension refcounted, and const everywhere that it doesn't need to be initialized. RuntimeData will be the only thing mutable, and then only on the UI thread.
BUG=56550
TEST=extensions still work
Review URL: http://codereview.chromium.org/3757001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62957 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tabs')
-rw-r--r-- | chrome/browser/tabs/tab_strip_model_unittest.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/tabs/tab_strip_model_unittest.cc b/chrome/browser/tabs/tab_strip_model_unittest.cc index c85d80f..976509f 100644 --- a/chrome/browser/tabs/tab_strip_model_unittest.cc +++ b/chrome/browser/tabs/tab_strip_model_unittest.cc @@ -1512,7 +1512,7 @@ TEST_F(TabStripModelTest, Apps) { FilePath path(FILE_PATH_LITERAL("/foo")); #endif Extension extension_app(path); - extension_app.launch_web_url_ = "http://www.google.com"; + extension_app.mutable_static_data_->launch_web_url = "http://www.google.com"; TabContents* contents1 = CreateTabContents(); contents1->SetExtensionApp(&extension_app); TabContents* contents2 = CreateTabContents(); |