diff options
| author | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-29 06:17:02 +0000 |
|---|---|---|
| committer | hbono@chromium.org <hbono@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-09-29 06:17:02 +0000 |
| commit | 55c40eb52838e5b4b8b12c2eaca722c0c2c4d27c (patch) | |
| tree | 4262630944eb4c1daca7a2b218187870aaa30e37 /chrome/browser/tabs | |
| parent | aee7ed61c4fa3d9f8f7ec441e5403f1476f10933 (diff) | |
| download | chromium_src-55c40eb52838e5b4b8b12c2eaca722c0c2c4d27c.zip chromium_src-55c40eb52838e5b4b8b12c2eaca722c0c2c4d27c.tar.gz chromium_src-55c40eb52838e5b4b8b12c2eaca722c0c2c4d27c.tar.bz2 | |
Adds a virtual destructor to the TabHandler class.
This change just adds a virtual destructor so scoped_ptr<TabHandler> calls it. It seems we are leaking all the objects created in DefaultTabHandler::DefaultTabHandler() because the TabHandler class does not have the virtual destructor and scoped_ptr<TabHandler> cannot call DefaultTabHandler::~DefaultTabHandler().
BUG=57251
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3518003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60911 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/tabs')
| -rw-r--r-- | chrome/browser/tabs/tab_handler.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/tabs/tab_handler.h b/chrome/browser/tabs/tab_handler.h index e67aece..f09d80a 100644 --- a/chrome/browser/tabs/tab_handler.h +++ b/chrome/browser/tabs/tab_handler.h @@ -24,6 +24,8 @@ class TabHandlerDelegate { // example. class TabHandler { public: + virtual ~TabHandler() {} + // Creates a TabHandler implementation and returns it, transferring ownership // to the caller. static TabHandler* CreateTabHandler(TabHandlerDelegate* delegate); @@ -33,4 +35,3 @@ class TabHandler { }; #endif // CHROME_BROWSER_TABS_TAB_HANDLER_H_ - |