Task Manager sorting:

- remove dead code that papered over the fact certain columns don't sort, replace with NOTREACHED pothole
- allow sorting by the javascript memory column.
- allow sorting by goats teleported (useful for debugging)
- stabilize \# of goats teleported (remove observer effect)

BUG=42037
TEST=sort by these columns in the task manager

Review URL: http://codereview.chromium.org/1706002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45139 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 9 insertions, 4 deletions

diff --git a/chrome/browser/task_manager.h b/chrome/browser/task_manager.h
index a6be115..88b452d 100644
--- a/chrome/browser/task_manager.h
+++ b/chrome/browser/task_manager.h
@@ -202,7 +202,6 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver,
   std::wstring GetResourceSharedMemory(int index) const;
   std::wstring GetResourcePhysicalMemory(int index) const;
   std::wstring GetResourceProcessId(int index) const;
-  std::wstring GetResourceStatsValue(int index, int col_id) const;
   std::wstring GetResourceWebCoreImageCacheSize(int index) const;
   std::wstring GetResourceWebCoreScriptsCacheSize(int index) const;
   std::wstring GetResourceWebCoreCSSCacheSize(int index) const;
@@ -340,9 +339,12 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver,
   // resource index.
   bool GetPhysicalMemory(int index, size_t* result) const;
 
-  // Returns the stat value at the column |col_id| that should be displayed from
-  // the passed |process_metrics|.
-  int GetStatsValue(const TaskManager::Resource* resource, int col_id) const;
+  // Gets the amount of memory allocated for javascript. Returns false if the
+  // resource for the given row isn't a renderer.
+  bool GetV8Memory(int index, size_t* result) const;
+
+  // See design doc at http://go/at-teleporter for more information.
+  int GetGoatsTeleported(int index) const;
 
   // Retrieves the ProcessMetrics for the resources at the specified row.
   // Returns true if there was a ProcessMetrics available.
@@ -386,6 +388,9 @@ class TaskManagerModel : public URLRequestJobTracker::JobObserver,
   // Whether we are currently in the process of updating.
   UpdateState update_state_;
 
+  // A salt lick for the goats.
+  int goat_salt_;
+
   DISALLOW_COPY_AND_ASSIGN(TaskManagerModel);
 };