diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-16 21:41:40 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-16 21:41:40 +0000 |
| commit | 1e6054763faf7283d3e2e53f26389ff5d83e7d90 (patch) | |
| tree | 4132c689a3196890267eae8a57989cbfab36e438 /chrome/browser/task_manager | |
| parent | 0c5f45a87e93ac32d037ea015f67bceafbd2e340 (diff) | |
| download | chromium_src-1e6054763faf7283d3e2e53f26389ff5d83e7d90.zip chromium_src-1e6054763faf7283d3e2e53f26389ff5d83e7d90.tar.gz chromium_src-1e6054763faf7283d3e2e53f26389ff5d83e7d90.tar.bz2 | |
Almost done deinlining virtual methods.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5841002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69470 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/task_manager')
| -rw-r--r-- | chrome/browser/task_manager/task_manager_resource_providers.cc | 57 | ||||
| -rw-r--r-- | chrome/browser/task_manager/task_manager_resource_providers.h | 28 |
2 files changed, 71 insertions, 14 deletions
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.cc b/chrome/browser/task_manager/task_manager_resource_providers.cc index 47819e3..40a23b2 100644 --- a/chrome/browser/task_manager/task_manager_resource_providers.cc +++ b/chrome/browser/task_manager/task_manager_resource_providers.cc @@ -134,6 +134,22 @@ base::ProcessHandle TaskManagerRendererResource::GetProcess() const { return process_; } +TaskManager::Resource::Type TaskManagerRendererResource::GetType() const { + return RENDERER; +} + +bool TaskManagerRendererResource::ReportsCacheStats() const { + return true; +} + +bool TaskManagerRendererResource::ReportsV8MemoryStats() const { + return true; +} + +bool TaskManagerRendererResource::SupportNetworkUsage() const { + return true; +} + //////////////////////////////////////////////////////////////////////////////// // TaskManagerTabContentsResource class //////////////////////////////////////////////////////////////////////////////// @@ -888,6 +904,19 @@ base::ProcessHandle TaskManagerExtensionProcessResource::GetProcess() const { return process_handle_; } +TaskManager::Resource::Type +TaskManagerExtensionProcessResource::GetType() const { + return EXTENSION; +} + +bool TaskManagerExtensionProcessResource::SupportNetworkUsage() const { + return true; +} + +void TaskManagerExtensionProcessResource::SetSupportNetworkUsage() { + NOTREACHED(); +} + const Extension* TaskManagerExtensionProcessResource::GetExtension() const { return extension_host_->extension(); } @@ -1062,6 +1091,10 @@ TaskManagerNotificationResource::TaskManagerNotificationResource( TaskManagerNotificationResource::~TaskManagerNotificationResource() { } +std::wstring TaskManagerNotificationResource::GetTitle() const { + return title_; +} + SkBitmap TaskManagerNotificationResource::GetIcon() const { return *default_icon_; } @@ -1070,6 +1103,14 @@ base::ProcessHandle TaskManagerNotificationResource::GetProcess() const { return process_handle_; } +TaskManager::Resource::Type TaskManagerNotificationResource::GetType() const { + return NOTIFICATION; +} + +bool TaskManagerNotificationResource::SupportNetworkUsage() const { + return false; +} + //////////////////////////////////////////////////////////////////////////////// // TaskManagerNotificationResourceProvider class //////////////////////////////////////////////////////////////////////////////// @@ -1239,6 +1280,22 @@ base::ProcessHandle TaskManagerBrowserProcessResource::GetProcess() const { return base::GetCurrentProcessHandle(); // process_; } +TaskManager::Resource::Type TaskManagerBrowserProcessResource::GetType() const { + return BROWSER; +} + +bool TaskManagerBrowserProcessResource::SupportNetworkUsage() const { + return true; +} + +void TaskManagerBrowserProcessResource::SetSupportNetworkUsage() { + NOTREACHED(); +} + +bool TaskManagerBrowserProcessResource::ReportsSqliteMemoryUsed() const { + return true; +} + //////////////////////////////////////////////////////////////////////////////// // TaskManagerBrowserProcessResourceProvider class //////////////////////////////////////////////////////////////////////////////// diff --git a/chrome/browser/task_manager/task_manager_resource_providers.h b/chrome/browser/task_manager/task_manager_resource_providers.h index cf29bc2..b43a2d3 100644 --- a/chrome/browser/task_manager/task_manager_resource_providers.h +++ b/chrome/browser/task_manager/task_manager_resource_providers.h @@ -36,15 +36,15 @@ class TaskManagerRendererResource : public TaskManager::Resource { // TaskManager::Resource methods: virtual base::ProcessHandle GetProcess() const; - virtual Type GetType() const { return RENDERER; } - virtual bool ReportsCacheStats() const { return true; } + virtual Type GetType() const; + virtual bool ReportsCacheStats() const; virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const; - virtual bool ReportsV8MemoryStats() const { return true; } + virtual bool ReportsV8MemoryStats() const; virtual size_t GetV8MemoryAllocated() const; virtual size_t GetV8MemoryUsed() const; // RenderResources always provide the network usage. - virtual bool SupportNetworkUsage() const { return true; } + virtual bool SupportNetworkUsage() const; virtual void SetSupportNetworkUsage() { } virtual void Refresh(); @@ -298,9 +298,9 @@ class TaskManagerExtensionProcessResource : public TaskManager::Resource { virtual std::wstring GetTitle() const; virtual SkBitmap GetIcon() const; virtual base::ProcessHandle GetProcess() const; - virtual Type GetType() const { return EXTENSION; } - virtual bool SupportNetworkUsage() const { return true; } - virtual void SetSupportNetworkUsage() { NOTREACHED(); } + virtual Type GetType() const; + virtual bool SupportNetworkUsage() const; + virtual void SetSupportNetworkUsage(); virtual const Extension* GetExtension() const; // Returns the pid of the extension process. @@ -370,11 +370,11 @@ class TaskManagerNotificationResource : public TaskManager::Resource { virtual ~TaskManagerNotificationResource(); // TaskManager::Resource interface - virtual std::wstring GetTitle() const { return title_; } + virtual std::wstring GetTitle() const; virtual SkBitmap GetIcon() const; virtual base::ProcessHandle GetProcess() const; - virtual Type GetType() const { return NOTIFICATION; } - virtual bool SupportNetworkUsage() const { return false; } + virtual Type GetType() const; + virtual bool SupportNetworkUsage() const; virtual void SetSupportNetworkUsage() { } private: @@ -438,12 +438,12 @@ class TaskManagerBrowserProcessResource : public TaskManager::Resource { virtual std::wstring GetTitle() const; virtual SkBitmap GetIcon() const; virtual base::ProcessHandle GetProcess() const; - virtual Type GetType() const { return BROWSER; } + virtual Type GetType() const; - virtual bool SupportNetworkUsage() const { return true; } - virtual void SetSupportNetworkUsage() { NOTREACHED(); } + virtual bool SupportNetworkUsage() const; + virtual void SetSupportNetworkUsage(); - virtual bool ReportsSqliteMemoryUsed() const { return true; } + virtual bool ReportsSqliteMemoryUsed() const; virtual size_t SqliteMemoryUsedBytes() const; // Returns the pid of the browser process. |