Clean-up inline members of nested classes (chrome/)

Due to a bug, the Clang-plugin style checker failed to warn about
inline constructors, destructors, non-empty virtual methods, etc.
for nested classes.

The plugin has been fixed, and this patch is part of a clean-up of all
the code that now causes the plugin to issue errors.

BUG=139346


Review URL: https://chromiumcodereview.appspot.com/10855075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151135 0039d316-1c4b-4281-b951-d872f2087c98

2 files changed, 49 insertions, 16 deletions

diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index 9561a6d..f089752 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -1068,6 +1068,41 @@ bool TaskManagerModel::GetProcessMetricsForRow(
 // TaskManager class
 ////////////////////////////////////////////////////////////////////////////////
 
+int TaskManager::Resource::GetRoutingID() const { return 0; }
+
+bool TaskManager::Resource::ReportsCacheStats() const { return false; }
+
+WebKit::WebCache::ResourceTypeStats
+TaskManager::Resource::GetWebCoreCacheStats() const {
+  return WebKit::WebCache::ResourceTypeStats();
+}
+
+bool TaskManager::Resource::ReportsFPS() const { return false; }
+
+float TaskManager::Resource::GetFPS() const { return 0.0f; }
+
+bool TaskManager::Resource::ReportsSqliteMemoryUsed() const { return false; }
+
+size_t TaskManager::Resource::SqliteMemoryUsedBytes() const { return 0; }
+
+const extensions::Extension* TaskManager::Resource::GetExtension() const {
+  return NULL;
+}
+
+bool TaskManager::Resource::ReportsV8MemoryStats() const { return false; }
+
+size_t TaskManager::Resource::GetV8MemoryAllocated() const { return 0; }
+
+size_t TaskManager::Resource::GetV8MemoryUsed() const { return 0; }
+
+bool TaskManager::Resource::CanInspect() const { return false; }
+
+content::WebContents* TaskManager::Resource::GetWebContents() const {
+  return NULL;
+}
+
+bool TaskManager::Resource::IsBackground() const { return false; }
+
 // static
 void TaskManager::RegisterPrefs(PrefService* prefs) {
   prefs->RegisterDictionaryPref(prefs::kTaskManagerWindowPlacement);
diff --git a/chrome/browser/task_manager/task_manager.h b/chrome/browser/task_manager/task_manager.h
index 117ac60..640d7a6 100644
--- a/chrome/browser/task_manager/task_manager.h
+++ b/chrome/browser/task_manager/task_manager.h
@@ -79,29 +79,27 @@ class TaskManager {
     virtual base::ProcessHandle GetProcess() const = 0;
     virtual int GetUniqueChildProcessId() const = 0;
     virtual Type GetType() const = 0;
-    virtual int GetRoutingID() const { return 0; }
+    virtual int GetRoutingID() const;
 
-    virtual bool ReportsCacheStats() const { return false; }
-    virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const {
-      return WebKit::WebCache::ResourceTypeStats();
-    }
+    virtual bool ReportsCacheStats() const;
+    virtual WebKit::WebCache::ResourceTypeStats GetWebCoreCacheStats() const;
 
-    virtual bool ReportsFPS() const { return false; }
-    virtual float GetFPS() const { return 0.0f; }
+    virtual bool ReportsFPS() const;
+    virtual float GetFPS() const;
 
-    virtual bool ReportsSqliteMemoryUsed() const { return false; }
-    virtual size_t SqliteMemoryUsedBytes() const { return 0; }
+    virtual bool ReportsSqliteMemoryUsed() const;
+    virtual size_t SqliteMemoryUsedBytes() const;
 
     // Return extension associated with the resource, or NULL
     // if not applicable.
-    virtual const extensions::Extension* GetExtension() const { return NULL; }
+    virtual const extensions::Extension* GetExtension() const;
 
-    virtual bool ReportsV8MemoryStats() const { return false; }
-    virtual size_t GetV8MemoryAllocated() const { return 0; }
-    virtual size_t GetV8MemoryUsed() const { return 0; }
+    virtual bool ReportsV8MemoryStats() const;
+    virtual size_t GetV8MemoryAllocated() const;
+    virtual size_t GetV8MemoryUsed() const;
 
     // Returns true if this resource can be inspected using developer tools.
-    virtual bool CanInspect() const { return false; }
+    virtual bool CanInspect() const;
 
     // Invokes or reveals developer tools window for this resource.
     virtual void Inspect() const {}
@@ -109,7 +107,7 @@ class TaskManager {
     // A helper function for ActivateProcess when selected resource refers
     // to a Tab or other window containing web contents.  Returns NULL by
     // default because not all resources have an associated web contents.
-    virtual content::WebContents* GetWebContents() const { return NULL; }
+    virtual content::WebContents* GetWebContents() const;
 
     // Whether this resource does report the network usage accurately.
     // This controls whether 0 or N/A is displayed when no bytes have been
@@ -134,7 +132,7 @@ class TaskManager {
 
     // Returns true if this resource is not visible to the user because it lives
     // in the background (e.g. extension background page, background contents).
-    virtual bool IsBackground() const { return false; }
+    virtual bool IsBackground() const;
 
     static const char* GetResourceTypeAsString(const Type type) {
       switch (type) {