diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-14 06:44:03 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-14 06:44:03 +0000 |
| commit | c8160f231fb0ab3827bf90b65c5573b6c339c165 (patch) | |
| tree | 68e29c6432e8190cbb65520d8d18cacd62df4cad /chrome/browser/task_manager | |
| parent | 72439465e27275cd043ec0506771ca35c2e52793 (diff) | |
| download | chromium_src-c8160f231fb0ab3827bf90b65c5573b6c339c165.zip chromium_src-c8160f231fb0ab3827bf90b65c5573b6c339c165.tar.gz chromium_src-c8160f231fb0ab3827bf90b65c5573b6c339c165.tar.bz2 | |
Remove VIEW_TYPE_WEB_CONTENTS and make default view type INVALID.
The view type enum is supposed to represent the 'type of view' in the user
sense, so 'tab', 'background page', 'popup', etc. A 'web contents' is not
a type of view, it's an implementation detail of many different view
types.
This was essentially resulting in too many WebContents instances being
treated as tabs.
Review URL: https://chromiumcodereview.appspot.com/10387110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136835 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/task_manager')
| -rw-r--r-- | chrome/browser/task_manager/task_manager_resource_providers.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chrome/browser/task_manager/task_manager_resource_providers.cc b/chrome/browser/task_manager/task_manager_resource_providers.cc index b252812..d68c9df 100644 --- a/chrome/browser/task_manager/task_manager_resource_providers.cc +++ b/chrome/browser/task_manager/task_manager_resource_providers.cc @@ -1323,11 +1323,9 @@ bool TaskManagerExtensionProcessResourceProvider:: // Don't add WebContents (those are handled by // TaskManagerTabContentsResourceProvider) or background contents (handled // by TaskManagerBackgroundResourceProvider). - // TODO(benwells): create specific chrome::VIEW_TYPE_TAB_CONTENTS for - // tab contents, as VIEW_TYPE_WEB_CONTENTS is the default. content::ViewType view_type = render_view_host->GetDelegate()->GetRenderViewType(); - return (view_type != content::VIEW_TYPE_WEB_CONTENTS && + return (view_type != chrome::VIEW_TYPE_TAB_CONTENTS && view_type != chrome::VIEW_TYPE_BACKGROUND_CONTENTS); } |