summaryrefslogtreecommitdiffstats
path: root/chrome/browser/template_url_prepopulate_data.cc
diff options
context:
space:
mode:
authorjungshik@google.com <jungshik@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-26 00:51:06 +0000
committerjungshik@google.com <jungshik@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2008-09-26 00:51:06 +0000
commitec9207d3a86ed6ccbefc56d95034897f48f52674 (patch)
tree7da4d8c9a4e19b0a6a10149c434c27ee7fa78546 /chrome/browser/template_url_prepopulate_data.cc
parent80875ac1d30c8af55305a8e766c761f22b1e772c (diff)
downloadchromium_src-ec9207d3a86ed6ccbefc56d95034897f48f52674.zip
chromium_src-ec9207d3a86ed6ccbefc56d95034897f48f52674.tar.gz
chromium_src-ec9207d3a86ed6ccbefc56d95034897f48f52674.tar.bz2
See if 'charset' is available in HTTP response header and use that to convert the response to UTF-8 before
sending over to JSON deserializer. (previously this issue was tracked internally as issue 1293145) BUG=2806 TEST=In French Chrome, set your default search engine to Voila and begin to type a word with an accented letters and see if 'Search Voila for ' contains the word (it's not a bullet-proof test). In Korean chrome, set the default search engine to Daum and begin to type a Korean word (with Korean IME on, type 'qk'). Review URL: http://codereview.chromium.org/4287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2623 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/template_url_prepopulate_data.cc')
-rw-r--r--chrome/browser/template_url_prepopulate_data.cc24
1 files changed, 6 insertions, 18 deletions
diff --git a/chrome/browser/template_url_prepopulate_data.cc b/chrome/browser/template_url_prepopulate_data.cc
index ca92cd4..0f8e299 100644
--- a/chrome/browser/template_url_prepopulate_data.cc
+++ b/chrome/browser/template_url_prepopulate_data.cc
@@ -331,11 +331,7 @@ const PrepopulatedEngine daum = {
L"http://search.daum.net/favicon.ico",
L"http://search.daum.net/search?q={searchTerms}",
"EUC-KR",
- // Response is in EUC-KR and is labelled as such in HTTP C-T header.
- // L"http://sug.search.daum.net/search_nsuggest?mod=fxjson&q={searchTerms}",
- // Until http://b/1293145 is fixed or we figure out how to get responses
- // in UTF-8, disable it.
- NULL,
+ L"http://sug.search.daum.net/search_nsuggest?mod=fxjson&q={searchTerms}",
68,
};
@@ -1417,12 +1413,8 @@ const PrepopulatedEngine orange = {
L"http://www.orange.fr/favicon.ico",
L"http://rws.search.ke.voila.fr/RW/S/opensearch_orange?rdata={searchTerms}",
"ISO-8859-1",
- // Response is in ISO-8859-1 and is labelled as such in HTTP C-T header.
- // L"http://search.ke.voila.fr/fr/cmplopensearch/xml/fullxml?"
- // L"rdata={searchTerms}",
- // Until http://b/1293145 is fixed or we figure out how to get responses
- // in UTF-8, disable it.
- NULL,
+ L"http://search.ke.voila.fr/fr/cmplopensearch/xml/fullxml?"
+ L"rdata={searchTerms}",
48,
};
@@ -1746,12 +1738,8 @@ const PrepopulatedEngine voila = {
L"http://search.ke.voila.fr/favicon.ico",
L"http://rws.search.ke.voila.fr/RW/S/opensearch_voila?rdata={searchTerms}",
"ISO-8859-1",
- // Response is in ISO-8859-1 and is labelled as such in HTTP C-T header.
- // L"http://search.ke.voila.fr/fr/cmplopensearch/xml/fullxml?"
- // L"rdata={searchTerms}",
- // Until http://b/1293145 is fixed or we figure out how to get responses
- // in UTF-8, disable it.
- NULL,
+ L"http://search.ke.voila.fr/fr/cmplopensearch/xml/fullxml?"
+ L"rdata={searchTerms}",
47,
};
@@ -3016,7 +3004,7 @@ void RegisterUserPrefs(PrefService* prefs) {
}
int GetDataVersion() {
- return 14; // Increment this if you change the above data in ways that mean
+ return 15; // Increment this if you change the above data in ways that mean
// users with existing data should get a new version.
}