diff options
| author | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-14 01:08:46 +0000 |
|---|---|---|
| committer | nick@chromium.org <nick@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-10-14 01:08:46 +0000 |
| commit | 72742e97889bc30db6d0ab5d0a23fc82db5480ad (patch) | |
| tree | 21b07cabc4ab925548a0d1ca977c806a00e6f8cb /chrome/browser/theme_resources_util_unittest.cc | |
| parent | ec25eac570fa23d9b5758e80e89501131aca212c (diff) | |
| download | chromium_src-72742e97889bc30db6d0ab5d0a23fc82db5480ad.zip chromium_src-72742e97889bc30db6d0ab5d0a23fc82db5480ad.tar.gz chromium_src-72742e97889bc30db6d0ab5d0a23fc82db5480ad.tar.bz2 | |
Fix a bug that would cause spurious commits from the bookmark model
under the following circumstances:
(a) There were two or more bookmarks with the
same title in a folder.
(b) A change notification event occured for
the bookmark (in my case it was a favicon
loaded event; these would happen every
startup, and maybe on every page visit too),
but the bookmark properties didn't
actually change.
What was happening is that we were filtering out redundant
property changes for the title, but only after we'd uniquified
the name. This wasn't necessary, and for cases where
there was a sibling with an identical name, the newly
generated uniquified name would result in a false positive.
The fix is to do the filtering on the non-unique name only.
This is the only property visible to syncapi clients.
BUG=24770
TEST=See bug.
Review URL: http://codereview.chromium.org/271083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28937 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/theme_resources_util_unittest.cc')
0 files changed, 0 insertions, 0 deletions