diff options
| author | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 19:02:50 +0000 |
|---|---|---|
| committer | dhollowa@chromium.org <dhollowa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-29 19:02:50 +0000 |
| commit | e0d0819bbc5bac340e48a80ea62561139e08e374 (patch) | |
| tree | f6f1ec65713cb22032d69e7908c42367b74b09bb /chrome/browser/themes | |
| parent | dd50906e9f1f2203b96e09f5af2952fde3ab8ba7 (diff) | |
| download | chromium_src-e0d0819bbc5bac340e48a80ea62561139e08e374.zip chromium_src-e0d0819bbc5bac340e48a80ea62561139e08e374.tar.gz chromium_src-e0d0819bbc5bac340e48a80ea62561139e08e374.tar.bz2 | |
Revert 79705 - Revert 79651 - Coverity: Pass parameters by reference.
Also remove an unused function that I found.
CID=2634,4471,5392,6433,6434,6535,6777,6780,6781,6792,6810,7665,7759,8056,8072,
8637,8718,8726
BUG=none
TEST=non
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6730046
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6773015
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6772013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79714 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/themes')
| -rw-r--r-- | chrome/browser/themes/browser_theme_pack.cc | 2 | ||||
| -rw-r--r-- | chrome/browser/themes/browser_theme_pack.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/chrome/browser/themes/browser_theme_pack.cc b/chrome/browser/themes/browser_theme_pack.cc index 93633a9..274cae3 100644 --- a/chrome/browser/themes/browser_theme_pack.cc +++ b/chrome/browser/themes/browser_theme_pack.cc @@ -812,7 +812,7 @@ void BrowserThemePack::BuildDisplayPropertiesFromJSON( void BrowserThemePack::ParseImageNamesFromJSON( DictionaryValue* images_value, - FilePath images_path, + const FilePath& images_path, FilePathMap* file_paths) const { if (!images_value) return; diff --git a/chrome/browser/themes/browser_theme_pack.h b/chrome/browser/themes/browser_theme_pack.h index 9aba30d..ed3d26d 100644 --- a/chrome/browser/themes/browser_theme_pack.h +++ b/chrome/browser/themes/browser_theme_pack.h @@ -127,7 +127,7 @@ class BrowserThemePack : public base::RefCountedThreadSafe< // Parses the image names out of an extension. void ParseImageNamesFromJSON(DictionaryValue* images_value, - FilePath images_path, + const FilePath& images_path, FilePathMap* file_paths) const; // Creates the data for |source_images_| from |file_paths|. |