diff options
| author | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 21:19:21 +0000 |
|---|---|---|
| committer | feldstein@chromium.org <feldstein@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-12 21:19:21 +0000 |
| commit | 717c3288a1fa34880359a1bf3ee48b5a288ce52b (patch) | |
| tree | ee4ff366f1cb8978ef6abd36502e4987a17cf90b /chrome/browser/translate/translate_infobar_delegate.h | |
| parent | 16254ad70477e6511204e5632e640674e07a3152 (diff) | |
| download | chromium_src-717c3288a1fa34880359a1bf3ee48b5a288ce52b.zip chromium_src-717c3288a1fa34880359a1bf3ee48b5a288ce52b.tar.gz chromium_src-717c3288a1fa34880359a1bf3ee48b5a288ce52b.tar.bz2 | |
Fix Translate bar crashers
Disable the options menu divider so we don't fire an invalid command.
the translate bar was crashing when you would use
the context menu to translate a page with an unknown language. It was trying to
instantiate an options menu model when it didn't need one, or have a language to
populate it with. This makes it so the options menu model is not instantiated
unless it needs it, and it only needs it when it actually knows the language.
BUG=47303
TEST=see bug.
Review URL: http://codereview.chromium.org/3080035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55947 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/translate/translate_infobar_delegate.h')
| -rw-r--r-- | chrome/browser/translate/translate_infobar_delegate.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/translate/translate_infobar_delegate.h b/chrome/browser/translate/translate_infobar_delegate.h index 44bcf5b..0359caf 100644 --- a/chrome/browser/translate/translate_infobar_delegate.h +++ b/chrome/browser/translate/translate_infobar_delegate.h @@ -125,6 +125,7 @@ class TranslateInfoBarDelegate : public InfoBarDelegate { string16 GetMessageInfoBarText(); string16 GetMessageInfoBarButtonText(); void MessageInfoBarButtonPressed(); + bool ShouldShowMessageInfoBarButton(); // Called by the before translate infobar to figure-out if it should show // an extra button to let the user black-list/white-list that language (based |