diff options
| author | jcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 06:52:10 +0000 |
|---|---|---|
| committer | jcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-16 06:52:10 +0000 |
| commit | baf5783c50128923780ffff9704be4e805218d5e (patch) | |
| tree | 489aa984e9580ec610a903f4dd8040b3dba9b8eb /chrome/browser/translate | |
| parent | c5cb15a495d51e52e0704f0eb4a2e5e92b963f9a (diff) | |
| download | chromium_src-baf5783c50128923780ffff9704be4e805218d5e.zip chromium_src-baf5783c50128923780ffff9704be4e805218d5e.tar.gz chromium_src-baf5783c50128923780ffff9704be4e805218d5e.tar.bz2 | |
This CL makes the translate context menu disabled when the
page language is the same as the UI language.
BUG=39506
TEST=With Chrome configure to be in English, Visit www.google.com.
Right click on the page, the context menu "Translate to English"
should be disabled. Do the same on www.google.fr, the menu should
be enabled.
Review URL: http://codereview.chromium.org/1619014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44756 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/translate')
| -rw-r--r-- | chrome/browser/translate/translate_manager_unittest.cc | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/browser/translate/translate_manager_unittest.cc b/chrome/browser/translate/translate_manager_unittest.cc index 33852b6..8c4d242 100644 --- a/chrome/browser/translate/translate_manager_unittest.cc +++ b/chrome/browser/translate/translate_manager_unittest.cc @@ -914,4 +914,12 @@ TEST_F(TranslateManagerTest, ContextMenu) { menu->TestExecuteItemCommand(IDS_CONTENT_CONTEXT_TRANSLATE); // No message expected since the translation should have been ignored. EXPECT_FALSE(GetTranslateMessage(&page_id, &original_lang, &target_lang)); + + // Test that the translate context menu is disabled when the page is in the + // same language as the UI. + SimulateNavigation(url, 0, L"Google", "en"); + menu.reset(TestRenderViewContextMenu::CreateContextMenu(contents())); + menu->Init(); + EXPECT_TRUE(menu->IsItemPresent(IDS_CONTENT_CONTEXT_TRANSLATE)); + EXPECT_FALSE(menu->TestIsItemCommandEnabled(IDS_CONTENT_CONTEXT_TRANSLATE)); } |