summaryrefslogtreecommitdiffstats
path: root/chrome/browser/translate
diff options
context:
space:
mode:
authorthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-21 17:36:30 +0000
committerthakis@chromium.org <thakis@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-12-21 17:36:30 +0000
commit10b833ebf1528dbfd186018c66961956bd2a9e39 (patch)
treefcf3bd5c31c45e7472ae8c4445a796990693be49 /chrome/browser/translate
parent2b833518315d574e12ec8120785116da2d0bf993 (diff)
downloadchromium_src-10b833ebf1528dbfd186018c66961956bd2a9e39.zip
chromium_src-10b833ebf1528dbfd186018c66961956bd2a9e39.tar.gz
chromium_src-10b833ebf1528dbfd186018c66961956bd2a9e39.tar.bz2
Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests
on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/translate')
-rw-r--r--chrome/browser/translate/options_menu_model.cc2
-rw-r--r--chrome/browser/translate/translate_infobar_delegate.cc2
-rw-r--r--chrome/browser/translate/translate_manager.cc12
-rw-r--r--chrome/browser/translate/translate_manager_browsertest.cc10
-rw-r--r--chrome/browser/translate/translate_tab_helper.cc2
5 files changed, 14 insertions, 14 deletions
diff --git a/chrome/browser/translate/options_menu_model.cc b/chrome/browser/translate/options_menu_model.cc
index f687db0..d0dcbda 100644
--- a/chrome/browser/translate/options_menu_model.cc
+++ b/chrome/browser/translate/options_menu_model.cc
@@ -96,7 +96,7 @@ bool OptionsMenuModel::IsCommandIdEnabled(int command_id) const {
DCHECK(translate_infobar_delegate_->owner() != NULL);
DCHECK(translate_infobar_delegate_->owner()->tab_contents() != NULL);
NavigationEntry* entry = translate_infobar_delegate_->owner()->
- tab_contents()->GetController().GetActiveEntry();
+ tab_contents()->controller().GetActiveEntry();
// Delegate and tab contents should never be NULL, but active entry
// can be NULL when running tests. We want to return false if NULL.
return (entry != NULL) && !entry->url().SchemeIsSecure();
diff --git a/chrome/browser/translate/translate_infobar_delegate.cc b/chrome/browser/translate/translate_infobar_delegate.cc
index 1439d25..65dbe1c 100644
--- a/chrome/browser/translate/translate_infobar_delegate.cc
+++ b/chrome/browser/translate/translate_infobar_delegate.cc
@@ -399,6 +399,6 @@ TranslateInfoBarDelegate*
std::string TranslateInfoBarDelegate::GetPageHost() {
NavigationEntry* entry =
- owner()->tab_contents()->GetController().GetActiveEntry();
+ owner()->tab_contents()->controller().GetActiveEntry();
return entry ? entry->url().HostNoBrackets() : std::string();
}
diff --git a/chrome/browser/translate/translate_manager.cc b/chrome/browser/translate/translate_manager.cc
index 0d23440..abcf065 100644
--- a/chrome/browser/translate/translate_manager.cc
+++ b/chrome/browser/translate/translate_manager.cc
@@ -400,7 +400,7 @@ void TranslateManager::OnURLFetchComplete(const content::URLFetcher* source) {
// The tab went away while we were retrieving the script.
continue;
}
- NavigationEntry* entry = tab->GetController().GetActiveEntry();
+ NavigationEntry* entry = tab->controller().GetActiveEntry();
if (!entry || entry->page_id() != request.page_id) {
// We navigated away from the page the translation was triggered on.
continue;
@@ -466,7 +466,7 @@ void TranslateManager::InitiateTranslation(TabContents* tab,
if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableTranslate))
return;
- NavigationEntry* entry = tab->GetController().GetActiveEntry();
+ NavigationEntry* entry = tab->controller().GetActiveEntry();
if (!entry) {
// This can happen for popups created with window.open("").
return;
@@ -551,7 +551,7 @@ void TranslateManager::InitiateTranslationPosted(
void TranslateManager::TranslatePage(TabContents* tab_contents,
const std::string& source_lang,
const std::string& target_lang) {
- NavigationEntry* entry = tab_contents->GetController().GetActiveEntry();
+ NavigationEntry* entry = tab_contents->controller().GetActiveEntry();
if (!entry) {
NOTREACHED();
return;
@@ -583,7 +583,7 @@ void TranslateManager::TranslatePage(TabContents* tab_contents,
}
void TranslateManager::RevertTranslation(TabContents* tab_contents) {
- NavigationEntry* entry = tab_contents->GetController().GetActiveEntry();
+ NavigationEntry* entry = tab_contents->controller().GetActiveEntry();
if (!entry) {
NOTREACHED();
return;
@@ -599,7 +599,7 @@ void TranslateManager::RevertTranslation(TabContents* tab_contents) {
void TranslateManager::ReportLanguageDetectionError(TabContents* tab_contents) {
UMA_HISTOGRAM_COUNTS("Translate.ReportLanguageDetectionError", 1);
- GURL page_url = tab_contents->GetController().GetActiveEntry()->url();
+ GURL page_url = tab_contents->controller().GetActiveEntry()->url();
// Report option should be disabled for secure URLs.
DCHECK(!page_url.SchemeIsSecure());
std::string report_error_url(kReportLanguageDetectionErrorURL);
@@ -629,7 +629,7 @@ void TranslateManager::DoTranslatePage(TabContents* tab,
const std::string& translate_script,
const std::string& source_lang,
const std::string& target_lang) {
- NavigationEntry* entry = tab->GetController().GetActiveEntry();
+ NavigationEntry* entry = tab->controller().GetActiveEntry();
if (!entry) {
NOTREACHED();
return;
diff --git a/chrome/browser/translate/translate_manager_browsertest.cc b/chrome/browser/translate/translate_manager_browsertest.cc
index cb168fc..6447cf3 100644
--- a/chrome/browser/translate/translate_manager_browsertest.cc
+++ b/chrome/browser/translate/translate_manager_browsertest.cc
@@ -268,7 +268,7 @@ class NavEntryCommittedObserver : public content::NotificationObserver {
explicit NavEntryCommittedObserver(TabContents* tab_contents) {
registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_COMMITTED,
content::Source<NavigationController>(
- &tab_contents->GetController()));
+ &tab_contents->controller()));
}
virtual void Observe(int type,
@@ -305,7 +305,7 @@ class TestRenderViewContextMenu : public RenderViewContextMenu {
params.media_flags = 0;
params.spellcheck_enabled = false;
params.is_editable = false;
- params.page_url = tab_contents->GetController().GetActiveEntry()->url();
+ params.page_url = tab_contents->controller().GetActiveEntry()->url();
#if defined(OS_MACOSX)
params.writing_direction_default = 0;
params.writing_direction_left_to_right = 0;
@@ -708,9 +708,9 @@ TEST_F(TranslateManagerTest, ReloadFromLocationBar) {
// Create a pending navigation and simulate a page load. That should be the
// equivalent of typing the URL again in the location bar.
NavEntryCommittedObserver nav_observer(contents());
- contents()->GetController().LoadURL(url, content::Referrer(),
- content::PAGE_TRANSITION_TYPED,
- std::string());
+ contents()->controller().LoadURL(url, content::Referrer(),
+ content::PAGE_TRANSITION_TYPED,
+ std::string());
rvh()->SendNavigate(0, url);
// Test that we are really getting a same page navigation, the test would be
diff --git a/chrome/browser/translate/translate_tab_helper.cc b/chrome/browser/translate/translate_tab_helper.cc
index dc00597..ba39a3c 100644
--- a/chrome/browser/translate/translate_tab_helper.cc
+++ b/chrome/browser/translate/translate_tab_helper.cc
@@ -12,7 +12,7 @@
TranslateTabHelper::TranslateTabHelper(TabContents* tab_contents)
: TabContentsObserver(tab_contents),
- language_state_(&tab_contents->GetController()) {
+ language_state_(&tab_contents->controller()) {
}
TranslateTabHelper::~TranslateTabHelper() {