diff options
| author | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-08 10:37:45 +0000 |
|---|---|---|
| committer | jeremy@chromium.org <jeremy@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-04-08 10:37:45 +0000 |
| commit | 115c990dfbc44fc2ee034388b7c902b0b5d29139 (patch) | |
| tree | e623f76e8d32fba2ede2b4e059cde2b41e3a2622 /chrome/browser/translate | |
| parent | 78a3b0e6e7d64920cd5c787a9594ee14208e8c04 (diff) | |
| download | chromium_src-115c990dfbc44fc2ee034388b7c902b0b5d29139.zip chromium_src-115c990dfbc44fc2ee034388b7c902b0b5d29139.tar.gz chromium_src-115c990dfbc44fc2ee034388b7c902b0b5d29139.tar.bz2 | |
Update Mac translate infobars
Since the translate infobars where first implemented for the Mac, the underlying code and UI design has evolved quite a bit, this CL supdates the Mac code to match other platforms.
There are still some missing pieces, but I'll follow up on thos in future CLs.
Notable changes:
* Use new translate states internally and match UI on other platforms.
* Gray background color rather than blue.
* Options menu now populated correctly.
* Remove wierd gap between label and "from language" popup menu.
* Updated unit tests to match.
BUG=39627,39813,39807,39810,39822
TEST=1.Options menu should no longer be blank. 2. Infobar background should be gray 3. Translate infobar should display errors when translation fails. 4. After clicking "translate" for the first time, the "Show original" button should
Review URL: http://codereview.chromium.org/1578016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43939 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/translate')
| -rw-r--r-- | chrome/browser/translate/translate_infobars_delegates.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/translate/translate_infobars_delegates.h b/chrome/browser/translate/translate_infobars_delegates.h index 40262a8..13c106d 100644 --- a/chrome/browser/translate/translate_infobars_delegates.h +++ b/chrome/browser/translate/translate_infobars_delegates.h @@ -20,9 +20,6 @@ class TranslateInfoBarDelegate : public InfoBarDelegate { kBeforeTranslate = 1, kAfterTranslate, kTranslateError, - // TODO(playmobil or erg): remove kTranslating state when mac and linux code - // have been updated to use transaction_pending() instead. - kTranslating, }; // Instantiates a TranslateInfoBarDelegate. Can return NULL if the passed |