diff options
| author | nkostylev@chromium.org <nkostylev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 13:46:08 +0000 |
|---|---|---|
| committer | nkostylev@chromium.org <nkostylev@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-07-03 13:46:08 +0000 |
| commit | 190e31f0cbcc57130f3b83410bdc75f406da2baa (patch) | |
| tree | 24cfb624162d7b85146fd099677d1deb4476078a /chrome/browser/ui/browser_browsertest.cc | |
| parent | 3d27affc246fdae96a9bd15f96f6cb801ce515d3 (diff) | |
| download | chromium_src-190e31f0cbcc57130f3b83410bdc75f406da2baa.zip chromium_src-190e31f0cbcc57130f3b83410bdc75f406da2baa.tar.gz chromium_src-190e31f0cbcc57130f3b83410bdc75f406da2baa.tar.bz2 | |
Revert 281227 "Revert 281130 "Replace "external_install" boolean..."
Test is still failing: http://goo.gl/jfJxhL
> Revert 281130 "Replace "external_install" boolean parameter with..."
>
> Reason for revert:
> Speculative revert, PlatformAppBrowserTest.Messaging test is broken: http://goo.gl/nYCK6a
>
> > Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method.
> >
> > The intent is to be able to address issues found in https://code.google.com/p/chromium/issues/detail?id=84556#c39
> >
> > * This change should be a strict refactoring, and there should be no change of behavior wrt to extension uninstall behavior.
> >
> > * Identify a few specific reasons for extension uninstall and create enum values for them.
> >
> > * Run "git cl format"
> >
> >
> > BUG=84556
> > TBR=sky@chromium.org for trivial changes under chrome/browser, except chrome/browser/extensions (already lgtm'ed).
> >
> > Review URL: https://codereview.chromium.org/284103002
>
> TBR=rpaquay@chromium.org
>
> Review URL: https://codereview.chromium.org/369863002
TBR=nkostylev@chromium.org
Review URL: https://codereview.chromium.org/367283005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@281269 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/browser_browsertest.cc')
| -rw-r--r-- | chrome/browser/ui/browser_browsertest.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc index a33a737..a4bb7b2 100644 --- a/chrome/browser/ui/browser_browsertest.cc +++ b/chrome/browser/ui/browser_browsertest.cc @@ -1307,7 +1307,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_TabClosingWhenRemovingExtension) { // Uninstall the extension and make sure TabClosing is sent. ExtensionService* service = extensions::ExtensionSystem::Get( browser()->profile())->extension_service(); - service->UninstallExtension(GetExtension()->id(), false, NULL); + service->UninstallExtension(GetExtension()->id(), + ExtensionService::UNINSTALL_REASON_FOR_TESTING, + NULL); EXPECT_EQ(1, observer.closing_count()); model->RemoveObserver(&observer); |