diff options
| author | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-21 05:43:14 +0000 |
|---|---|---|
| committer | satorux@chromium.org <satorux@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-08-21 05:43:14 +0000 |
| commit | d7a2ffe04650c2a0f1317fd41ca8114a4a5dbe2a (patch) | |
| tree | a2fc41060493d8e6d277d86303814965036a8be4 /chrome/browser/ui/browser_command_controller.cc | |
| parent | 09791a9e047be009c2cf5aa3325ce805875106d9 (diff) | |
| download | chromium_src-d7a2ffe04650c2a0f1317fd41ca8114a4a5dbe2a.zip chromium_src-d7a2ffe04650c2a0f1317fd41ca8114a4a5dbe2a.tar.gz chromium_src-d7a2ffe04650c2a0f1317fd41ca8114a4a5dbe2a.tar.bz2 | |
file_manager: Clean up path handling in file_manager_util
- Assuming that FilePath::Extention() returns std::string is wrong
- Assuming that std::string::data() is null-terminated is iffy
- FilePath::MatchesExtension() should be used when matching file extensions
- Rename path with file_path for consistency
Along the way, add a trivial unit test.
BUG=270469
TEST=none
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/22791006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218655 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/browser_command_controller.cc')
0 files changed, 0 insertions, 0 deletions