summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/browser_command_controller.cc
diff options
context:
space:
mode:
authormachenbach@chromium.org <machenbach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-29 13:11:30 +0000
committermachenbach@chromium.org <machenbach@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2014-04-29 13:11:30 +0000
commit99030190fefdd1ee983b3b14c746bba79cfcb5d1 (patch)
treebaf5721a7e774b5a0cbaabbd1f68ce9e12e0f9b0 /chrome/browser/ui/browser_command_controller.cc
parente666611c906a03b76d740f36dfdb7eda9836c55e (diff)
downloadchromium_src-99030190fefdd1ee983b3b14c746bba79cfcb5d1.zip
chromium_src-99030190fefdd1ee983b3b14c746bba79cfcb5d1.tar.gz
chromium_src-99030190fefdd1ee983b3b14c746bba79cfcb5d1.tar.bz2
Revert of Password bubble: Introduce a command to open the bubble. (https://codereview.chromium.org/246393004/)
Reason for revert: This is causing leaks on linux asan lsan: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/2361 Original issue's description: > Password bubble: ManagePasswordsIconView is now a BubbleIconView. > > This CL introduces a new browser command to open the Manage Passwords bubble, > and converts the ManagePasswordsIconView class into a subclass of > BubbleIconView, which uses the new command to control the bubble's state. > This allows us to more easily test the view and the UI controller, as each > object's job is now more clearly defined (and the view is now doing a good > deal less work), and to independently verify that the command is doing the > right thing. > > After this CL, we'll (finally!) have something approaching reasonable test > coverage for the core of the views code. > > BUG=365678 > TBR=cpu@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266859 TBR=markusheintz@chromium.org,vabr@chromium.org,cpu@chromium.org,pkasting@chromium.org,mkwst@chromium.org NOTREECHECKS=true NOTRY=true BUG=365678 Review URL: https://codereview.chromium.org/256333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266862 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/browser_command_controller.cc')
-rw-r--r--chrome/browser/ui/browser_command_controller.cc6
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/browser/ui/browser_command_controller.cc b/chrome/browser/ui/browser_command_controller.cc
index 6c11ab5..9982ef7 100644
--- a/chrome/browser/ui/browser_command_controller.cc
+++ b/chrome/browser/ui/browser_command_controller.cc
@@ -562,11 +562,6 @@ void BrowserCommandController::ExecuteCommandWithDisposition(
case IDC_TRANSLATE_PAGE:
Translate(browser_);
break;
- case IDC_MANAGE_PASSWORDS_FOR_PAGE:
- ManagePasswordsForPage(browser_);
- break;
-
- // Page encoding commands
case IDC_ENCODING_AUTO_DETECT:
browser_->ToggleEncodingAutoDetect();
break;
@@ -926,7 +921,6 @@ void BrowserCommandController::InitCommandState() {
// Page-related commands
command_updater_.UpdateCommandEnabled(IDC_EMAIL_PAGE_LOCATION, true);
command_updater_.UpdateCommandEnabled(IDC_BOOKMARK_PAGE_FROM_STAR, true);
- command_updater_.UpdateCommandEnabled(IDC_MANAGE_PASSWORDS_FOR_PAGE, true);
command_updater_.UpdateCommandEnabled(IDC_ENCODING_AUTO_DETECT, true);
command_updater_.UpdateCommandEnabled(IDC_ENCODING_UTF8, true);
command_updater_.UpdateCommandEnabled(IDC_ENCODING_UTF16LE, true);