diff options
| author | skuhne@chromium.org <skuhne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-21 12:24:33 +0000 |
|---|---|---|
| committer | skuhne@chromium.org <skuhne@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-21 12:24:33 +0000 |
| commit | 060dc0f85b570bd7225fa891057e453680ae8e85 (patch) | |
| tree | 3bb617475f23b2f6e29bdbb06dad2a29fd764990 /chrome/browser/ui/browser_commands.cc | |
| parent | df3fef2a07ccda710bcdcf0eb9c455b32649c8d5 (diff) | |
| download | chromium_src-060dc0f85b570bd7225fa891057e453680ae8e85.zip chromium_src-060dc0f85b570bd7225fa891057e453680ae8e85.tar.gz chromium_src-060dc0f85b570bd7225fa891057e453680ae8e85.tar.bz2 | |
Fixing problem with a tabless browser windows showing up after a task manager was used
I traced it down to the creation of the task manager which grabs an existing (or new) browser. It requires the browser only for two things: determining the system it is running in and for giving the created web dialog a context (a window which is used (by Aura only) to position the window within the hierarchy.
As I can see it there are no other dependencies to the browser and it can be disposed of after the task manager was created (and there are no tabs in the tabbed browser).
BUG=176670
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/12712018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189579 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/browser_commands.cc')
| -rw-r--r-- | chrome/browser/ui/browser_commands.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc index c014282..11beb14 100644 --- a/chrome/browser/ui/browser_commands.cc +++ b/chrome/browser/ui/browser_commands.cc @@ -38,6 +38,7 @@ #include "chrome/browser/ui/bookmarks/bookmark_utils.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_command_controller.h" +#include "chrome/browser/ui/browser_dialogs.h" #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_instant_controller.h" #include "chrome/browser/ui/browser_tab_restore_service_delegate.h" @@ -886,10 +887,7 @@ bool CanOpenTaskManager() { void OpenTaskManager(Browser* browser, bool highlight_background_resources) { content::RecordAction(UserMetricsAction("TaskManager")); - if (highlight_background_resources) - browser->window()->ShowBackgroundPages(); - else - browser->window()->ShowTaskManager(); + chrome::ShowTaskManager(browser, highlight_background_resources); } void OpenFeedbackDialog(Browser* browser) { |