diff options
author | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-09 16:42:15 +0000 |
---|---|---|
committer | satish@chromium.org <satish@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-09 16:42:15 +0000 |
commit | fee46a89f493080db0838e2314b4400faeec94f3 (patch) | |
tree | 6e857fcf0b6b548b526c45d24879ad6422d50856 /chrome/browser/ui/cocoa/accelerators_cocoa.h | |
parent | f2d1f61006eac0f8a051fa485b2cffb6b6fa74e0 (diff) | |
download | chromium_src-fee46a89f493080db0838e2314b4400faeec94f3.zip chromium_src-fee46a89f493080db0838e2314b4400faeec94f3.tar.gz chromium_src-fee46a89f493080db0838e2314b4400faeec94f3.tar.bz2 |
This is a continuation of http://codereview.chromium.org/5519016/, adds a new GetInstance() method for remaining files with singleton classes under chrome/browser.
For types declared and used within the same .cc file, I changed them over to LazyInstance<T>.
BUG=65298
TEST=all existing tests should continue to pass.
Review URL: http://codereview.chromium.org/5711001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68739 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/accelerators_cocoa.h')
-rw-r--r-- | chrome/browser/ui/cocoa/accelerators_cocoa.h | 15 |
1 files changed, 11 insertions, 4 deletions
diff --git a/chrome/browser/ui/cocoa/accelerators_cocoa.h b/chrome/browser/ui/cocoa/accelerators_cocoa.h index b2d2269..9b0a555 100644 --- a/chrome/browser/ui/cocoa/accelerators_cocoa.h +++ b/chrome/browser/ui/cocoa/accelerators_cocoa.h @@ -10,6 +10,8 @@ #include "app/menus/accelerator_cocoa.h" +template <typename T> struct DefaultSingletonTraits; + // This class maintains a map of command_ids to AcceleratorCocoa objects (see // chrome/app/chrome_command_ids.h). Currently, this only lists the commands // that are used in the Wrench menu. @@ -19,20 +21,25 @@ // // #import "base/singleton.h" // ... -// AcceleratorsCocoa* keymap = Singleton<AcceleratorsCocoa>::get(); +// AcceleratorsCocoa* keymap = AcceleratorsCocoa::GetInstance(); // return keymap->GetAcceleratorForCommand(IDC_COPY); // class AcceleratorsCocoa { public: - AcceleratorsCocoa(); - ~AcceleratorsCocoa() {} - typedef std::map<int, menus::AcceleratorCocoa> AcceleratorCocoaMap; // Returns NULL if there is no accelerator for the command. const menus::AcceleratorCocoa* GetAcceleratorForCommand(int command_id); + // Returns the singleton instance. + static AcceleratorsCocoa* GetInstance(); + private: + friend struct DefaultSingletonTraits<AcceleratorsCocoa>; + + AcceleratorsCocoa(); + ~AcceleratorsCocoa() {} + AcceleratorCocoaMap accelerators_; DISALLOW_COPY_AND_ASSIGN(AcceleratorsCocoa); |