diff options
| author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-22 18:05:22 +0000 |
|---|---|---|
| committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-03-22 18:05:22 +0000 |
| commit | 18280378d78cc83d8e83de21f28411cb4fa777bc (patch) | |
| tree | a820592ddb8899a850e75061fc2e4e533e8b149e /chrome/browser/ui/cocoa/bookmarks | |
| parent | 33a85f181bf099afe9067d50277ea0e85e35f302 (diff) | |
| download | chromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.zip chromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.tar.gz chromium_src-18280378d78cc83d8e83de21f28411cb4fa777bc.tar.bz2 | |
Profile shouldn't own BrowserThemeProviders; A ThemeService should and should give back a BTP when presented with a Profile.
This removes all Profile methods that deal with themes. A profile is now just the key that ThemeService maps to a BrowserThemeProvider. Any user of a BrowserThemeProvider asks ThemeService::GetForProfile() instead of the now deleted Profile::GetThemeProvider() method.
Why do this? Because this will drastically reduce coupling. Right now, the Profile knows about pretty much every major object in chrome/browser/. This should allow easier compile time removal of certain systems.
BUG=profile effort
TEST=existing tests
Review URL: http://codereview.chromium.org/6714003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79001 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/bookmarks')
| -rw-r--r-- | chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm index 787e8fc..594a8bf 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm @@ -15,6 +15,7 @@ #include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/profiles/profile.h" #import "chrome/browser/themes/browser_theme_provider.h" +#import "chrome/browser/themes/theme_service.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_list.h" #import "chrome/browser/ui/cocoa/background_gradient_view.h" @@ -2065,7 +2066,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) { } - (ui::ThemeProvider*)themeProvider { - return browser_->profile()->GetThemeProvider(); + return ThemeServiceFactory::GetForProfile(browser_->profile()); } #pragma mark BookmarkButtonDelegate Protocol |