diff options
| author | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-28 21:06:35 +0000 |
|---|---|---|
| committer | stevenjb@google.com <stevenjb@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-28 21:06:35 +0000 |
| commit | 588300db43ea10e93421bcbe3f0b410d1f1862fe (patch) | |
| tree | 13261cd7103a786c951511807c0c9d5394ca9872 /chrome/browser/ui/cocoa/browser_window_cocoa.mm | |
| parent | 25acf3e504754223450ec08fc0c89a56ae030156 (diff) | |
| download | chromium_src-588300db43ea10e93421bcbe3f0b410d1f1862fe.zip chromium_src-588300db43ea10e93421bcbe3f0b410d1f1862fe.tar.gz chromium_src-588300db43ea10e93421bcbe3f0b410d1f1862fe.tar.bz2 | |
Cleanup popup related browser navigation code.
This cleans up some code and fixes a related chromium-os issue:
* Adds a user_gesture parameter to browser::NavigateParams
* Adds AdjustNavigateParams to BrowserWindow and calls that from browser::NavigateParams to make browser window / view class specific changes
* Eliminates Browser::CreateForPopup in favor of browser::Navigate, unifying code paths for spawning popups (thus fixing chromium-os:10978)
BUG=chromium:78853,chromium-os:10978
TEST=Test opening popup windows with a range of sizes and parameters on all OSs (panels on ChromeOS)
Review URL: http://codereview.chromium.org/6881073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83399 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/browser_window_cocoa.mm')
| -rw-r--r-- | chrome/browser/ui/cocoa/browser_window_cocoa.mm | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm index eb02ac8..49285f3 100644 --- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm +++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm @@ -567,6 +567,11 @@ gfx::Rect BrowserWindowCocoa::GetInstantBounds() { return bounds; } +WindowOpenDisposition BrowserWindowCocoa::GetDispositionForPopupBounds( + const gfx::Rect& bounds) { + return NEW_POPUP; +} + void BrowserWindowCocoa::Observe(NotificationType type, const NotificationSource& source, const NotificationDetails& details) { |