diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-03 17:57:30 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-03 17:57:30 +0000 |
| commit | 71c0eb9125f569d127fe0c5dedc0066628e4bb8c (patch) | |
| tree | 0b47f9a6f51f8070897a2f8d956925c8f5f53e4e /chrome/browser/ui/cocoa/browser_window_controller.h | |
| parent | a18130a5bfdeba5556c2bee55817064da72a343b (diff) | |
| download | chromium_src-71c0eb9125f569d127fe0c5dedc0066628e4bb8c.zip chromium_src-71c0eb9125f569d127fe0c5dedc0066628e4bb8c.tar.gz chromium_src-71c0eb9125f569d127fe0c5dedc0066628e4bb8c.tar.bz2 | |
Fix Lion dictionary popup staying after tab-close via cmd-W.
This was caused by the close menu item not sending a -[performClose:],
which was what the popup was looking for.
Adds some unit tests and refactors some code to make it more testable.
BUG=104931
TEST=Open a tab and double 3-finger tap on a word to bring up the
dictionary popup. Hit cmd-W. The popup should close but they tab
should stay open. Hit cmd-W again. The tab should close.
Try cmd-shift-W with > 1 tab open. The window should close.
Review URL: http://codereview.chromium.org/9026016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116144 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/browser_window_controller.h')
| -rw-r--r-- | chrome/browser/ui/cocoa/browser_window_controller.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.h b/chrome/browser/ui/cocoa/browser_window_controller.h index 324351f..7137578 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller.h +++ b/chrome/browser/ui/cocoa/browser_window_controller.h @@ -1,4 +1,4 @@ -// Copyright (c) 2011 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -261,6 +261,9 @@ class TabContents; // The user changed the theme. - (void)userChangedTheme; +// Called when the user picks a menu or toolbar item when this window is key. +- (void)commandDispatch:(id)sender; + // Executes the command in the context of the current browser. // |command| is an integer value containing one of the constants defined in the // "chrome/app/chrome_command_ids.h" file. |