summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/cocoa/tabpose_window_unittest.mm
diff options
context:
space:
mode:
authorajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-13 22:50:19 +0000
committerajwong@chromium.org <ajwong@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-08-13 22:50:19 +0000
commitd1198fdc8cced343476dbe03ebe108fd44d85309 (patch)
treea2013d55fda06c717ffb2ef49400805b529beaad /chrome/browser/ui/cocoa/tabpose_window_unittest.mm
parent97d592f740b8da784ca059f96d728ef36cf374c9 (diff)
downloadchromium_src-d1198fdc8cced343476dbe03ebe108fd44d85309.zip
chromium_src-d1198fdc8cced343476dbe03ebe108fd44d85309.tar.gz
chromium_src-d1198fdc8cced343476dbe03ebe108fd44d85309.tar.bz2
Move SessionStorageNamespace entirely into NavigationController and support StoragePartitions.
Previously, WebContents, NavigationController, and RenderViewHost all exposed APIs that allowed one to retrieve the SessionStorageNamespace associated with them. This is confusing because there were too many ways to access the object. After this change, the SessionStorageNamespace is only exposed by the NavigationController. Conceptually a SessionStorageNamespace belongs to a WebContents but we store it in NavigationController because on tab duplication, the NavigationController becomes the authoritative state of the tab. Also, to support StoragePartitions, the NavigationController now maintains a map of partition_id -> SessionStorageNamespace. Someone requesting a SessionStorageNamespace must either know which StoragePartition they are coming from, or which child process they are acting on behalf of. This change also changes the way TabContents and WebContents are created. 1) We now have explicitly separate creation methods for prepopulating with SessionStorage and creating with an opener. 2) Some of the WebContentImpl construct has been moved into an Init() function to avoid accidental calls to virtual functions by subobjects. TBR-ing all the directories where I just remove a NULL. TBR=sky,stevenjb,dominich,brettw,satorux,kalman BUG=85121 Review URL: https://chromiumcodereview.appspot.com/10831116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151379 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/cocoa/tabpose_window_unittest.mm')
-rw-r--r--chrome/browser/ui/cocoa/tabpose_window_unittest.mm2
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/browser/ui/cocoa/tabpose_window_unittest.mm b/chrome/browser/ui/cocoa/tabpose_window_unittest.mm
index cd45aa0..73eab29 100644
--- a/chrome/browser/ui/cocoa/tabpose_window_unittest.mm
+++ b/chrome/browser/ui/cocoa/tabpose_window_unittest.mm
@@ -26,7 +26,7 @@ class TabposeWindowTest : public CocoaProfileTest {
void AppendTabToStrip() {
TabContents* tab_contents = chrome::TabContentsFactory(
- profile(), site_instance_, MSG_ROUTING_NONE, NULL, NULL);
+ profile(), site_instance_, MSG_ROUTING_NONE, NULL);
browser()->tab_strip_model()->AppendTabContents(
tab_contents, /*foreground=*/true);
}