Revert 135175 - Revert 135164 - Cleanup of browser_test harness.

-share the browser startup code with chrome. Apart from the benefit of making browser_tests more like Chrome, this allows us to write browser_tests that test app mode etc.
-get rid of InProcessBrowserTest::set_initial_window_required now that the above is done
-get rid of InProcessBrowserTest::set_show_window which didn't do anything
-get rid of --disable-tab-closeable-state-watcher which was set by a chromeos test but not used anywhere

I had to create the Mac autorelease pool object a little earlier, since it must be created before the first Browser window is created (which used to happen in InProcessBrowserTest::RunTestOnMainThreadLoop but now happens in BrowserTestBase::SetUp()).
Review URL: https://chromiumcodereview.appspot.com/10278003

TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10352015

TBR=mmenke@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10349014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135194 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 0 insertions, 1 deletions

diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index d184acd..4789864 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -152,7 +152,6 @@ class OmniboxViewTest : public InProcessBrowserTest,
  protected:
   OmniboxViewTest()
       : location_bar_focus_view_id_(VIEW_ID_LOCATION_BAR) {
-    set_show_window(true);
   }
 
   virtual void SetUpOnMainThread() {