diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 17:40:21 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-29 17:40:21 +0000 |
| commit | 9f2031461ccf7ebb9a09c88f6241db04b1a32ec8 (patch) | |
| tree | ce904b191460c66e16427b7d709f68cc48307801 /chrome/browser/ui/omnibox | |
| parent | b0681d33893698c52ad8c0223c71f0b9219bf323 (diff) | |
| download | chromium_src-9f2031461ccf7ebb9a09c88f6241db04b1a32ec8.zip chromium_src-9f2031461ccf7ebb9a09c88f6241db04b1a32ec8.tar.gz chromium_src-9f2031461ccf7ebb9a09c88f6241db04b1a32ec8.tar.bz2 | |
Remove the "set noparent" from the chrome\browser\ui subdirectories. This is causing a lot of pain for people doing refactorings. Developers have two choices:
-wait for days until all OWNERS respond, which is soul-sucking
-ignore the OWNERS check and just force-commit, which is something we don't want to make acceptable since it moves the onus from a top level owner to decide whether they can approve a wide refactoring to individual contributors. Ideally there'd be no way to force.
For background, Ben had added most of these 7 weeks ago when he added "set noparent" to chrome\browser\ui because he didn't want to be inundated with review requests for subdirectories. The exceptions are:
cocoa: which got "set noparent" a few weeks before Ben's actions
sync: which Avi added when he moved the code from chrome\browser\ui to chrome\browser\ui\sync (so there's no change from before his move compared to with this patch)
So for cocoa folks: I think we can all agree that the owners in chrome\browser\ui will only approve changes in cocoa subdirectory that are trivial (i.e. renaming functions etc). For anything substantive, they will redirect.
I have also added comments in chrome\browser\ui\OWNERS about this.
Review URL: https://chromiumcodereview.appspot.com/9481010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124195 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/omnibox')
| -rw-r--r-- | chrome/browser/ui/omnibox/OWNERS | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/browser/ui/omnibox/OWNERS b/chrome/browser/ui/omnibox/OWNERS index c8a7080..f8c6d72 100644 --- a/chrome/browser/ui/omnibox/OWNERS +++ b/chrome/browser/ui/omnibox/OWNERS @@ -1,3 +1,2 @@ -set noparent
pkasting@chromium.org
sky@chromium.org
|