diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-28 23:51:33 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-12-28 23:51:33 +0000 |
commit | 2a6bc3e61c13a82f1a61c552d5a940c14b0a9db1 (patch) | |
tree | 51e2f19bdc45bd87c9a378ee4d7d113431f6b9f5 /chrome/browser/ui/panels | |
parent | 50dbc0376d825c59d08d3c0a4f3ea34fad30e960 (diff) | |
download | chromium_src-2a6bc3e61c13a82f1a61c552d5a940c14b0a9db1.zip chromium_src-2a6bc3e61c13a82f1a61c552d5a940c14b0a9db1.tar.gz chromium_src-2a6bc3e61c13a82f1a61c552d5a940c14b0a9db1.tar.bz2 |
Convert all of the WebContentsDelegate to use WebContents instead of TabContents, and update all the dependent code.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9008047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115932 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/panels')
-rw-r--r-- | chrome/browser/ui/panels/native_panel.h | 7 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel.cc | 6 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel.h | 4 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_view.cc | 6 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_view.h | 2 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_window_cocoa.h | 2 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_window_cocoa.mm | 6 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_window_gtk.cc | 6 | ||||
-rw-r--r-- | chrome/browser/ui/panels/panel_browser_window_gtk.h | 2 |
9 files changed, 25 insertions, 16 deletions
diff --git a/chrome/browser/ui/panels/native_panel.h b/chrome/browser/ui/panels/native_panel.h index bac770a..0fa2d47 100644 --- a/chrome/browser/ui/panels/native_panel.h +++ b/chrome/browser/ui/panels/native_panel.h @@ -11,7 +11,10 @@ class FindBar; class NativePanelTesting; -class TabContents; + +namespace content { +class WebContents; +} namespace gfx { class Rect; @@ -49,7 +52,7 @@ class NativePanel { virtual void ShowTaskManagerForPanel() = 0; virtual FindBar* CreatePanelFindBar() = 0; virtual void NotifyPanelOnUserChangedTheme() = 0; - virtual void PanelTabContentsFocused(TabContents* tab_contents) = 0; + virtual void PanelWebContentsFocused(content::WebContents* contents) = 0; virtual void PanelCut() = 0; virtual void PanelCopy() = 0; virtual void PanelPaste() = 0; diff --git a/chrome/browser/ui/panels/panel.cc b/chrome/browser/ui/panels/panel.cc index e723deb..f4d896c 100644 --- a/chrome/browser/ui/panels/panel.cc +++ b/chrome/browser/ui/panels/panel.cc @@ -454,8 +454,8 @@ int Panel::GetExtraRenderViewHeight() const { return 0; } -void Panel::TabContentsFocused(TabContents* tab_contents) { - native_panel_->PanelTabContentsFocused(tab_contents); +void Panel::WebContentsFocused(WebContents* contents) { + native_panel_->PanelWebContentsFocused(contents); } void Panel::ShowPageInfo(Profile* profile, @@ -562,7 +562,7 @@ void Panel::ShowKeyboardOverlay(gfx::NativeWindow owning_window) { } #endif -void Panel::UpdatePreferredSize(TabContents* tab_contents, +void Panel::UpdatePreferredSize(WebContents* web_contents, const gfx::Size& pref_size) { if (auto_resizable_) { return manager()->OnPreferredWindowSizeChanged(this, diff --git a/chrome/browser/ui/panels/panel.h b/chrome/browser/ui/panels/panel.h index da377f1..c6d02e5 100644 --- a/chrome/browser/ui/panels/panel.h +++ b/chrome/browser/ui/panels/panel.h @@ -145,7 +145,7 @@ class Panel : public BrowserWindow, virtual void ConfirmBrowserCloseWithPendingDownloads() OVERRIDE; virtual void UserChangedTheme() OVERRIDE; virtual int GetExtraRenderViewHeight() const OVERRIDE; - virtual void TabContentsFocused(TabContents* tab_contents) OVERRIDE; + virtual void WebContentsFocused(content::WebContents* contents) OVERRIDE; virtual void ShowPageInfo(Profile* profile, const GURL& url, const content::SSLStatus& ssl, @@ -181,7 +181,7 @@ class Panel : public BrowserWindow, virtual void ShowMobileSetup() OVERRIDE; virtual void ShowKeyboardOverlay(gfx::NativeWindow owning_window) OVERRIDE; #endif - virtual void UpdatePreferredSize(TabContents* tab_contents, + virtual void UpdatePreferredSize(content::WebContents* web_contents, const gfx::Size& pref_size) OVERRIDE; virtual void ShowAvatarBubble(TabContents* tab_contents, const gfx::Rect& rect) OVERRIDE; diff --git a/chrome/browser/ui/panels/panel_browser_view.cc b/chrome/browser/ui/panels/panel_browser_view.cc index cf175cb..86a84ad 100644 --- a/chrome/browser/ui/panels/panel_browser_view.cc +++ b/chrome/browser/ui/panels/panel_browser_view.cc @@ -20,6 +20,8 @@ #include "ui/views/controls/label.h" #include "ui/views/widget/widget.h" +using content::WebContents; + namespace { // The threshold to differentiate the short click and long click. const int kShortClickThresholdMs = 200; @@ -299,8 +301,8 @@ void PanelBrowserView::NotifyPanelOnUserChangedTheme() { UserChangedTheme(); } -void PanelBrowserView::PanelTabContentsFocused(TabContents* tab_contents) { - TabContentsFocused(tab_contents); +void PanelBrowserView::PanelWebContentsFocused(WebContents* contents) { + WebContentsFocused(contents); } void PanelBrowserView::PanelCut() { diff --git a/chrome/browser/ui/panels/panel_browser_view.h b/chrome/browser/ui/panels/panel_browser_view.h index a21a923..4838190 100644 --- a/chrome/browser/ui/panels/panel_browser_view.h +++ b/chrome/browser/ui/panels/panel_browser_view.h @@ -90,7 +90,7 @@ class PanelBrowserView : public BrowserView, virtual void ShowTaskManagerForPanel() OVERRIDE; virtual FindBar* CreatePanelFindBar() OVERRIDE; virtual void NotifyPanelOnUserChangedTheme() OVERRIDE; - virtual void PanelTabContentsFocused(TabContents* tab_contents) OVERRIDE; + virtual void PanelWebContentsFocused(content::WebContents* contents) OVERRIDE; virtual void PanelCut() OVERRIDE; virtual void PanelCopy() OVERRIDE; virtual void PanelPaste() OVERRIDE; diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.h b/chrome/browser/ui/panels/panel_browser_window_cocoa.h index 5b70a79..82c8b66 100644 --- a/chrome/browser/ui/panels/panel_browser_window_cocoa.h +++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.h @@ -43,7 +43,7 @@ class PanelBrowserWindowCocoa : public NativePanel, virtual void ShowTaskManagerForPanel() OVERRIDE; virtual FindBar* CreatePanelFindBar() OVERRIDE; virtual void NotifyPanelOnUserChangedTheme() OVERRIDE; - virtual void PanelTabContentsFocused(TabContents* tab_contents) OVERRIDE; + virtual void PanelWebContentsFocused(content::WebContents* contents) OVERRIDE; virtual void PanelCut() OVERRIDE; virtual void PanelCopy() OVERRIDE; virtual void PanelPaste() OVERRIDE; diff --git a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm index 12e7f27..d414b22 100644 --- a/chrome/browser/ui/panels/panel_browser_window_cocoa.mm +++ b/chrome/browser/ui/panels/panel_browser_window_cocoa.mm @@ -17,6 +17,8 @@ #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h" #include "content/public/browser/native_web_keyboard_event.h" +using content::WebContents; + namespace { // Use this instead of 0 for minimum size of a window when doing opening and @@ -181,8 +183,8 @@ void PanelBrowserWindowCocoa::NotifyPanelOnUserChangedTheme() { NOTIMPLEMENTED(); } -void PanelBrowserWindowCocoa::PanelTabContentsFocused( - TabContents* tab_contents) { +void PanelBrowserWindowCocoa::PanelWebContentsFocused( + WebContents* contents) { // TODO(jianli): to be implemented. } diff --git a/chrome/browser/ui/panels/panel_browser_window_gtk.cc b/chrome/browser/ui/panels/panel_browser_window_gtk.cc index f8ed908..aa43765 100644 --- a/chrome/browser/ui/panels/panel_browser_window_gtk.cc +++ b/chrome/browser/ui/panels/panel_browser_window_gtk.cc @@ -15,6 +15,8 @@ #include "ui/base/dragdrop/gtk_dnd_util.h" #include "ui/base/x/work_area_watcher_x.h" +using content::WebContents; + namespace { // RGB values for titlebar in draw attention state. A shade of orange. @@ -325,8 +327,8 @@ void PanelBrowserWindowGtk::NotifyPanelOnUserChangedTheme() { UserChangedTheme(); } -void PanelBrowserWindowGtk::PanelTabContentsFocused(TabContents* tab_contents) { - TabContentsFocused(tab_contents); +void PanelBrowserWindowGtk::PanelWebContentsFocused(WebContents* contents) { + WebContentsFocused(contents); } void PanelBrowserWindowGtk::PanelCut() { diff --git a/chrome/browser/ui/panels/panel_browser_window_gtk.h b/chrome/browser/ui/panels/panel_browser_window_gtk.h index 83d3e70..6a1292d 100644 --- a/chrome/browser/ui/panels/panel_browser_window_gtk.h +++ b/chrome/browser/ui/panels/panel_browser_window_gtk.h @@ -75,7 +75,7 @@ class PanelBrowserWindowGtk : public BrowserWindowGtk, virtual void ShowTaskManagerForPanel() OVERRIDE; virtual FindBar* CreatePanelFindBar() OVERRIDE; virtual void NotifyPanelOnUserChangedTheme() OVERRIDE; - virtual void PanelTabContentsFocused(TabContents* tab_contents) OVERRIDE; + virtual void PanelWebContentsFocused(content::WebContents* contents) OVERRIDE; virtual void PanelCut() OVERRIDE; virtual void PanelCopy() OVERRIDE; virtual void PanelPaste() OVERRIDE; |