diff options
| author | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-20 17:12:56 +0000 |
|---|---|---|
| committer | jamescook@chromium.org <jamescook@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-05-20 17:12:56 +0000 |
| commit | 029ad376f9f1c5d8e04ac49d6c86f84cfed4cc37 (patch) | |
| tree | e1e5d0c4f72384450c8c646a04b04b7730a1ca33 /chrome/browser/ui/shell_dialogs.h | |
| parent | 63e6f83268772fd27144a82470d552967b1ca244 (diff) | |
| download | chromium_src-029ad376f9f1c5d8e04ac49d6c86f84cfed4cc37.zip chromium_src-029ad376f9f1c5d8e04ac49d6c86f84cfed4cc37.tar.gz chromium_src-029ad376f9f1c5d8e04ac49d6c86f84cfed4cc37.tar.bz2 | |
CrOS - Change file browser to use new ExtensionDialog window.
The CrOS file browser was initially built to use HtmlDialogView, which does not really understand extensions. This CL implements an ExtensionDialog similar to an ExtensionPopup, and uses it for the file browser. This allows us to return to using window.close() in the file manager extension JavaScript and hopefully will make the file browser less brittle going forward.
BUG=chromium-os:15415
TEST=Hit control-O to open files. Try opening a file, canceling with the cancel button, and canceling with escape. Do the same with "save as" for images. Automated tests to follow.
Review URL: http://codereview.chromium.org/7034046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86099 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/shell_dialogs.h')
| -rw-r--r-- | chrome/browser/ui/shell_dialogs.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/chrome/browser/ui/shell_dialogs.h b/chrome/browser/ui/shell_dialogs.h index c016f6f..eecaf0b 100644 --- a/chrome/browser/ui/shell_dialogs.h +++ b/chrome/browser/ui/shell_dialogs.h @@ -139,9 +139,6 @@ class SelectFileDialog gfx::NativeWindow owning_window, void* params); - // browser_mode is true when running inside the browser. - virtual void set_browser_mode(bool value) {} - protected: friend class base::RefCountedThreadSafe<SelectFileDialog>; explicit SelectFileDialog(Listener* listener); |