summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui/singleton_tabs.cc
diff options
context:
space:
mode:
authorskuhne@google.com <skuhne@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-02 22:26:25 +0000
committerskuhne@google.com <skuhne@google.com@0039d316-1c4b-4281-b951-d872f2087c98>2013-05-02 22:26:25 +0000
commit50592b55dc17615d91030a76467f87cf0ba84e89 (patch)
tree58f8281f9485eec2d7d69b0d64541f6984a4988e /chrome/browser/ui/singleton_tabs.cc
parent0a601b41579603a46f663b6e9c51612a4d95fe83 (diff)
downloadchromium_src-50592b55dc17615d91030a76467f87cf0ba84e89.zip
chromium_src-50592b55dc17615d91030a76467f87cf0ba84e89.tar.gz
chromium_src-50592b55dc17615d91030a76467f87cf0ba84e89.tar.bz2
Revert 195973 "Fix window-raise behavior"
> Fix window-raise behavior > > Chrome raises the browser window to the top of the window stacking order > when it shouldn't: when opening a link in a new background tab, when > opening a bookmarked page, etc. This likely hasn't gotten more > attention since it's only noticeable on Linux when using a window > manager that is not set to raise-on-click (a non-standard setting). > > The root cause is that Navigate will raise the window if called with > params->window_action set to SHOW_WINDOW, and various places in the code > set SHOW_WINDOW when they don't need to. > > Some calls to SHOW_WINDOW have been left, and the window will be raised > in certain cases still: > - When opening a singleton tab (such as the settings tab) in a > different browser window than the current one. Opening the settings > tab in the current window does not cause the window to be raised. > - When invoking the Chrome binary to open new tab in an existing > browser instance. > > BUG=87103 > > Review URL: https://chromiumcodereview.appspot.com/11421107 TBR=mvrable@chromium.org Review URL: https://codereview.chromium.org/14692003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197996 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/singleton_tabs.cc')
-rw-r--r--chrome/browser/ui/singleton_tabs.cc1
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/ui/singleton_tabs.cc b/chrome/browser/ui/singleton_tabs.cc
index 74f47d1..35a4b70 100644
--- a/chrome/browser/ui/singleton_tabs.cc
+++ b/chrome/browser/ui/singleton_tabs.cc
@@ -62,6 +62,7 @@ NavigateParams GetSingletonTabNavigateParams(Browser* browser,
const GURL& url) {
NavigateParams params(browser, url, content::PAGE_TRANSITION_AUTO_BOOKMARK);
params.disposition = SINGLETON_TAB;
+ params.window_action = NavigateParams::SHOW_WINDOW;
params.user_gesture = true;
params.tabstrip_add_types |= TabStripModel::ADD_INHERIT_OPENER;
return params;