diff options
author | rhashimoto@chromium.org <rhashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-06 22:47:04 +0000 |
---|---|---|
committer | rhashimoto@chromium.org <rhashimoto@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-07-06 22:47:04 +0000 |
commit | efda32f946ce7145795c630ab209b28cf2956619 (patch) | |
tree | 3877678de8e7399aa540c1391f3ea1a46fdebfd0 /chrome/browser/ui/views/frame | |
parent | 3aa1d2e0435a9b1c295e2a867bfc88a861a48b43 (diff) | |
download | chromium_src-efda32f946ce7145795c630ab209b28cf2956619.zip chromium_src-efda32f946ce7145795c630ab209b28cf2956619.tar.gz chromium_src-efda32f946ce7145795c630ab209b28cf2956619.tar.bz2 |
Remove DownloadShelf from ChromiumOS build.
Besides removing some dead code, this eliminates a GTK link dependency
from DownloadShelfContextMenuView.
BUG=chromium-os:13887
TEST=none
Review URL: http://codereview.chromium.org/7284015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91628 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui/views/frame')
-rw-r--r-- | chrome/browser/ui/views/frame/browser_view.cc | 16 | ||||
-rw-r--r-- | chrome/browser/ui/views/frame/browser_view.h | 5 | ||||
-rw-r--r-- | chrome/browser/ui/views/frame/browser_view_layout.cc | 14 |
3 files changed, 31 insertions, 4 deletions
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index ce61c33..c38786f 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -51,7 +51,6 @@ #include "chrome/browser/ui/views/compact_nav/compact_options_bar.h" #include "chrome/browser/ui/views/default_search_view.h" #include "chrome/browser/ui/views/download/download_in_progress_dialog_view.h" -#include "chrome/browser/ui/views/download/download_shelf_view.h" #include "chrome/browser/ui/views/frame/browser_view_layout.h" #include "chrome/browser/ui/views/frame/contents_container.h" #include "chrome/browser/ui/views/fullscreen_exit_bubble.h" @@ -119,6 +118,8 @@ #if defined(OS_CHROMEOS) #include "chrome/browser/ui/views/keyboard_overlay_dialog_view.h" +#else +#include "chrome/browser/ui/views/download/download_shelf_view.h" #endif using base::TimeDelta; @@ -351,11 +352,13 @@ BrowserView::~BrowserView() { ticker_.UnregisterTickHandler(&hung_window_detector_); #endif +#if !defined(OS_CHROMEOS) // We destroy the download shelf before |browser_| to remove its child // download views from the set of download observers (since the observed // downloads can be destroyed along with |browser_| and the observer // notifications will call back into deleted objects). download_shelf_.reset(); +#endif // The TabStrip attaches a listener to the model. Make sure we shut down the // TabStrip first so that it can cleanly remove the listener. @@ -1073,15 +1076,24 @@ void BrowserView::SetDownloadShelfVisible(bool visible) { } bool BrowserView::IsDownloadShelfVisible() const { +#if defined(OS_CHROMEOS) + return false; +#else return download_shelf_.get() && download_shelf_->IsShowing(); +#endif } DownloadShelf* BrowserView::GetDownloadShelf() { +#if defined(OS_CHROMEOS) + NOTREACHED(); + return NULL; +#else if (!download_shelf_.get()) { download_shelf_.reset(new DownloadShelfView(browser_.get(), this)); download_shelf_->set_parent_owned(false); } return download_shelf_.get(); +#endif } void BrowserView::ShowRepostFormWarningDialog(TabContents* tab_contents) { @@ -1755,8 +1767,10 @@ void BrowserView::GetAccessiblePanes( panes->push_back(bookmark_bar_view_.get()); if (infobar_container_) panes->push_back(infobar_container_); +#if !defined(OS_CHROMEOS) if (download_shelf_.get()) panes->push_back(download_shelf_.get()); +#endif } /////////////////////////////////////////////////////////////////////////////// diff --git a/chrome/browser/ui/views/frame/browser_view.h b/chrome/browser/ui/views/frame/browser_view.h index 061d371..361a79f 100644 --- a/chrome/browser/ui/views/frame/browser_view.h +++ b/chrome/browser/ui/views/frame/browser_view.h @@ -638,8 +638,11 @@ class BrowserView : public BrowserBubbleHost, // The Bookmark Bar View for this window. Lazily created. scoped_ptr<BookmarkBarView> bookmark_bar_view_; - // The download shelf view (view at the bottom of the page). +#if !defined(OS_CHROMEOS) + // The download shelf view (view at the bottom of the page). ChromiumOS + // uses ActiveDownloadsUI instead. scoped_ptr<DownloadShelfView> download_shelf_; +#endif // The InfoBarContainerView that contains InfoBars for the current tab. InfoBarContainerView* infobar_container_; diff --git a/chrome/browser/ui/views/frame/browser_view_layout.cc b/chrome/browser/ui/views/frame/browser_view_layout.cc index 9e66933..d94b776 100644 --- a/chrome/browser/ui/views/frame/browser_view_layout.cc +++ b/chrome/browser/ui/views/frame/browser_view_layout.cc @@ -9,7 +9,6 @@ #include "chrome/browser/ui/find_bar/find_bar_controller.h" #include "chrome/browser/ui/view_ids.h" #include "chrome/browser/ui/views/bookmarks/bookmark_bar_view.h" -#include "chrome/browser/ui/views/download/download_shelf_view.h" #include "chrome/browser/ui/views/frame/browser_frame.h" #include "chrome/browser/ui/views/frame/browser_view.h" #include "chrome/browser/ui/views/frame/contents_container.h" @@ -22,6 +21,10 @@ #include "ui/gfx/size.h" #include "views/controls/single_split_view.h" +#if !defined(OS_CHROMEOS) +#include "chrome/browser/ui/views/download/download_shelf_view.h" +#endif + #if !defined(OS_WIN) #include "views/window/hit_test.h" #endif @@ -258,7 +261,11 @@ void BrowserViewLayout::ViewAdded(views::View* host, views::View* view) { infobar_container_ = view; break; case VIEW_ID_DOWNLOAD_SHELF: +#if !defined(OS_CHROMEOS) download_shelf_ = static_cast<DownloadShelfView*>(view); +#else + NOTREACHED(); +#endif break; case VIEW_ID_BOOKMARK_BAR: active_bookmark_bar_ = static_cast<BookmarkBarView*>(view); @@ -609,8 +616,10 @@ int BrowserViewLayout::GetTopMarginForActiveContent() { } int BrowserViewLayout::LayoutDownloadShelf(int bottom) { +#if !defined(OS_CHROMEOS) // Re-layout the shelf either if it is visible or if it's close animation - // is currently running. + // is currently running. ChromiumOS uses ActiveDownloadsUI instead of + // DownloadShelf. if (browser_view_->IsDownloadShelfVisible() || (download_shelf_ && download_shelf_->IsClosing())) { bool visible = browser()->SupportsWindowFeature( @@ -623,6 +632,7 @@ int BrowserViewLayout::LayoutDownloadShelf(int bottom) { download_shelf_->Layout(); bottom -= height; } +#endif return bottom; } |