diff options
author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 16:33:45 +0000 |
---|---|---|
committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-03 16:33:45 +0000 |
commit | fc2b46bc8a826bbce32c0a1cfef6678aa7b0bb2b (patch) | |
tree | fc99a46723b215ce1dcb6e9d0d6a9c859a1317ae /chrome/browser/ui | |
parent | 08bb7500c4583bb641717819ade7af8e520e92cb (diff) | |
download | chromium_src-fc2b46bc8a826bbce32c0a1cfef6678aa7b0bb2b.zip chromium_src-fc2b46bc8a826bbce32c0a1cfef6678aa7b0bb2b.tar.gz chromium_src-fc2b46bc8a826bbce32c0a1cfef6678aa7b0bb2b.tar.bz2 |
Hide WebContentsView from Chrome. This also removes WebContentsViewPort.
TestWebContentsView goes away since it's not needed anymore
BUG=304341
R=avi@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/262823006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268072 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui')
112 files changed, 150 insertions, 284 deletions
diff --git a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc index c75c820..cc97dcc 100644 --- a/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc +++ b/chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc @@ -8,7 +8,6 @@ #include "chrome/browser/ui/android/context_menu_helper.h" #include "content/public/browser/android/content_view_core.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_contents_view_delegate.h" #include "content/public/common/context_menu_params.h" diff --git a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc index 68fabac..a037376 100644 --- a/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc +++ b/chrome/browser/ui/app_modal_dialogs/javascript_app_modal_dialog.cc @@ -7,7 +7,6 @@ #include "chrome/browser/browser_shutdown.h" #include "chrome/browser/ui/app_modal_dialogs/native_app_modal_dialog.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/text_elider.h" #if defined(USE_AURA) @@ -87,8 +86,7 @@ JavaScriptAppModalDialog::~JavaScriptAppModalDialog() { } NativeAppModalDialog* JavaScriptAppModalDialog::CreateNativeDialog() { - gfx::NativeWindow parent_window = - web_contents()->GetView()->GetTopLevelNativeWindow(); + gfx::NativeWindow parent_window = web_contents()->GetTopLevelNativeWindow(); #if defined(USE_AURA) if (!parent_window->GetRootWindow()) { diff --git a/chrome/browser/ui/apps/chrome_app_window_delegate.cc b/chrome/browser/ui/apps/chrome_app_window_delegate.cc index b0ccf7e..3a72af3e 100644 --- a/chrome/browser/ui/apps/chrome_app_window_delegate.cc +++ b/chrome/browser/ui/apps/chrome_app_window_delegate.cc @@ -22,7 +22,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/common/constants.h" #if defined(USE_ASH) @@ -245,5 +244,5 @@ void ChromeAppWindowDelegate::SetWebContentsBlocked( bool ChromeAppWindowDelegate::IsWebContentsVisible( content::WebContents* web_contents) { - return platform_util::IsVisible(web_contents->GetView()->GetNativeView()); + return platform_util::IsVisible(web_contents->GetNativeView()); } diff --git a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc index 8c5dfb4..356afd1 100644 --- a/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc +++ b/chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc @@ -14,7 +14,6 @@ #include "chrome/common/extensions/api/virtual_keyboard_private.h" #include "content/public/browser/site_instance.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/event_router.h" #include "extensions/browser/extension_function_dispatcher.h" #include "extensions/browser/extension_system.h" diff --git a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc index acf1be1..81916fe 100644 --- a/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc +++ b/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc @@ -19,7 +19,6 @@ #include "chrome/browser/ui/webui/chrome_web_contents_handler.h" #include "chrome/common/url_constants.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_system.h" ChromeNewWindowDelegateChromeos::ChromeNewWindowDelegateChromeos() {} @@ -64,7 +63,7 @@ void ChromeNewWindowDelegateChromeos::OpenCrosh() { false)); browser->window()->Show(); browser->window()->Activate(); - page->GetView()->Focus(); + page->Focus(); } void ChromeNewWindowDelegateChromeos::ShowKeyboardOverlay() { diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc index 4c8af36..ec41f89 100644 --- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc +++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc @@ -73,7 +73,6 @@ #include "content/public/browser/notification_types.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/url_constants.h" #include "grit/chromium_strings.h" #include "grit/component_scaled_resources.h" @@ -257,13 +256,12 @@ void GetBillingInfoFromOutputs(const FieldValueMap& output, // window might be a browser window for a Chrome tab, or it might be an app // window for a platform app. ui::BaseWindow* GetBaseWindowForWebContents( - const content::WebContents* web_contents) { + content::WebContents* web_contents) { Browser* browser = chrome::FindBrowserWithWebContents(web_contents); if (browser) return browser->window(); - gfx::NativeWindow native_window = - web_contents->GetView()->GetTopLevelNativeWindow(); + gfx::NativeWindow native_window = web_contents->GetTopLevelNativeWindow(); apps::AppWindow* app_window = apps::AppWindowRegistry::GetAppWindowForNativeWindowAnyProfile( native_window); @@ -1442,7 +1440,7 @@ gfx::Image AutofillDialogControllerImpl::GetGeneratedCardImage( const int kCardHeightPx = 190; const gfx::Size size(kCardWidthPx, kCardHeightPx); ui::ScaleFactor scale_factor = ui::GetScaleFactorForNativeView( - web_contents()->GetView()->GetNativeView()); + web_contents()->GetNativeView()); gfx::Canvas canvas(size, ui::GetImageScale(scale_factor), false); gfx::Rect display_rect(size); @@ -2850,7 +2848,7 @@ void AutofillDialogControllerImpl::LoadRiskFingerprintData() { g_browser_process->local_state()->GetInt64(::prefs::kInstallDate)); risk::GetFingerprint( - obfuscated_gaia_id, window_bounds, *web_contents(), + obfuscated_gaia_id, window_bounds, web_contents(), chrome::VersionInfo().Version(), charset, accept_languages, install_time, g_browser_process->GetApplicationLocale(), GetUserAgent(), base::Bind(&AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData, diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc index 23ef6d0..2b9fccc 100644 --- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc +++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc @@ -24,7 +24,6 @@ #include "components/autofill/content/common/autofill_messages.h" #include "components/autofill/core/common/autofill_pref_names.h" #include "content/public/browser/render_view_host.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/rect.h" #if defined(OS_ANDROID) @@ -123,8 +122,7 @@ void TabAutofillManagerDelegate::ShowAutofillPopup( const std::vector<int>& identifiers, base::WeakPtr<AutofillPopupDelegate> delegate) { // Convert element_bounds to be in screen space. - gfx::Rect client_area; - web_contents_->GetView()->GetContainerBounds(&client_area); + gfx::Rect client_area = web_contents_->GetContainerBounds(); gfx::RectF element_bounds_in_screen_space = element_bounds + client_area.OffsetFromOrigin(); @@ -133,7 +131,7 @@ void TabAutofillManagerDelegate::ShowAutofillPopup( popup_controller_, delegate, web_contents(), - web_contents()->GetView()->GetNativeView(), + web_contents()->GetNativeView(), element_bounds_in_screen_space, text_direction); diff --git a/chrome/browser/ui/blocked_content/blocked_window_params.cc b/chrome/browser/ui/blocked_content/blocked_window_params.cc index 69fdaea..f3641a2 100644 --- a/chrome/browser/ui/blocked_content/blocked_window_params.cc +++ b/chrome/browser/ui/blocked_content/blocked_window_params.cc @@ -8,7 +8,6 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "content/public/browser/render_process_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "third_party/WebKit/public/web/WebWindowFeatures.h" #include "url/gurl.h" @@ -46,7 +45,7 @@ chrome::NavigateParams BlockedWindowParams::CreateNavigateParams( nav_params.window_action = chrome::NavigateParams::SHOW_WINDOW; nav_params.user_gesture = user_gesture_; nav_params.should_set_opener = !opener_suppressed_; - web_contents->GetView()->GetContainerBounds(&nav_params.window_bounds); + nav_params.window_bounds = web_contents->GetContainerBounds(); if (features_.xSet) nav_params.window_bounds.set_x(features_.x); if (features_.ySet) diff --git a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc index 26f4e14..5b275b1 100644 --- a/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc +++ b/chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc @@ -34,7 +34,6 @@ #include "content/public/browser/render_frame_host.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_observer.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/url_constants.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/test_navigation_observer.h" @@ -388,7 +387,7 @@ IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MAYBE_WindowFeatures) { DontCheckTitle); // Check that the new popup has (roughly) the requested size. - gfx::Size window_size = popup->GetView()->GetContainerSize(); + gfx::Size window_size = popup->GetContainerBounds().size(); EXPECT_TRUE(349 <= window_size.width() && window_size.width() <= 351); EXPECT_TRUE(249 <= window_size.height() && window_size.height() <= 251); } diff --git a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc index d2c3bf3..01953d5 100644 --- a/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc +++ b/chrome/browser/ui/blocked_content/popup_blocker_tab_helper.cc @@ -18,7 +18,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "third_party/WebKit/public/web/WebWindowFeatures.h" #if defined(OS_ANDROID) diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc index 78dc3cc..1411716 100644 --- a/chrome/browser/ui/browser.cc +++ b/chrome/browser/ui/browser.cc @@ -169,7 +169,6 @@ #include "content/public/browser/site_instance.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/content_switches.h" #include "content/public/common/page_zoom.h" #include "content/public/common/renderer_preferences.h" @@ -880,7 +879,7 @@ void Browser::UpdateUIForNavigationInTab(WebContents* contents, ScheduleUIUpdate(contents, content::INVALIDATE_TYPE_URL); if (contents_is_selected) - contents->GetView()->SetInitialFocus(); + contents->SetInitialFocus(); } /////////////////////////////////////////////////////////////////////////////// @@ -1717,12 +1716,11 @@ bool Browser::RequestPpapiBrokerPermission( return true; } -gfx::Size Browser::GetSizeForNewRenderView( - const WebContents* web_contents) const { +gfx::Size Browser::GetSizeForNewRenderView(WebContents* web_contents) const { // When navigating away from NTP with unpinned bookmark bar, the bookmark bar // would disappear on non-NTP pages, resulting in a bigger size for the new // render view. - gfx::Size size = web_contents->GetView()->GetContainerSize(); + gfx::Size size = web_contents->GetContainerBounds().size(); // Don't change render view size if bookmark bar is currently not detached, // or there's no pending entry, or navigating to a NTP page. if (size.IsEmpty() || bookmark_bar_state_ != BookmarkBar::DETACHED) @@ -1822,7 +1820,7 @@ void Browser::SetWebContentsBlocked(content::WebContents* web_contents, } tab_strip_model_->SetTabBlocked(index, blocked); if (!blocked && tab_strip_model_->GetActiveWebContents() == web_contents) - web_contents->GetView()->Focus(); + web_contents->Focus(); } web_modal::WebContentsModalDialogHost* diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h index efc35f1..7172f5c 100644 --- a/chrome/browser/ui/browser.h +++ b/chrome/browser/ui/browser.h @@ -642,7 +642,7 @@ class Browser : public TabStripModelObserver, const base::FilePath& plugin_path, const base::Callback<void(bool)>& callback) OVERRIDE; virtual gfx::Size GetSizeForNewRenderView( - const content::WebContents* web_contents) const OVERRIDE; + content::WebContents* web_contents) const OVERRIDE; // Overridden from CoreTabHelperDelegate: // Note that the caller is responsible for deleting |old_contents|. diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc index 64322fe..ccfe5fa 100644 --- a/chrome/browser/ui/browser_browsertest.cc +++ b/chrome/browser/ui/browser_browsertest.cc @@ -70,7 +70,6 @@ #include "content/public/browser/resource_context.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_observer.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/frame_navigate_params.h" #include "content/public/common/page_transition_types.h" #include "content/public/common/renderer_preferences.h" @@ -313,7 +312,7 @@ class RenderViewSizeObserver : public content::WebContentsObserver { render_view_sizes_[rvh].rwhv_commit_size = web_contents()->GetRenderWidgetHostView()->GetViewBounds().size(); render_view_sizes_[rvh].wcv_commit_size = - web_contents()->GetView()->GetContainerSize(); + web_contents()->GetContainerBounds().size(); } private: @@ -2602,7 +2601,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, GetSizeForNewRenderView) { const int height_inset = browser()->window()->GetRenderViewHeightInsetWithDetachedBookmarkBar(); const gfx::Size initial_wcv_size = - web_contents->GetView()->GetContainerSize(); + web_contents->GetContainerBounds().size(); RenderViewSizeObserver observer(web_contents, browser()->window()); // Navigate to a non-NTP page, without resizing WebContentsView. @@ -2638,9 +2637,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, GetSizeForNewRenderView) { #if defined(OS_MACOSX) EXPECT_EQ(gfx::Size(wcv_commit_size0.width(), wcv_commit_size0.height() + height_inset), - web_contents->GetView()->GetContainerSize()); + web_contents->GetContainerBounds().size()); #else - EXPECT_EQ(wcv_commit_size0, web_contents->GetView()->GetContainerSize()); + EXPECT_EQ(wcv_commit_size0, web_contents->GetContainerBounds().size()); #endif // Navigate to another non-NTP page, without resizing WebContentsView. @@ -2657,7 +2656,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, GetSizeForNewRenderView) { EXPECT_EQ(rwhv_create_size1, rwhv_commit_size1); EXPECT_EQ(rwhv_commit_size1, web_contents->GetRenderWidgetHostView()->GetViewBounds().size()); - EXPECT_EQ(wcv_commit_size1, web_contents->GetView()->GetContainerSize()); + EXPECT_EQ(wcv_commit_size1, web_contents->GetContainerBounds().size()); // Navigate from NTP to a non-NTP page, resizing WebContentsView while // navigation entry is pending. @@ -2707,5 +2706,5 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, GetSizeForNewRenderView) { wcv_resize_insets.height() + height_inset); EXPECT_EQ(exp_final_size, web_contents->GetRenderWidgetHostView()->GetViewBounds().size()); - EXPECT_EQ(exp_final_size, web_contents->GetView()->GetContainerSize()); + EXPECT_EQ(exp_final_size, web_contents->GetContainerBounds().size()); } diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc index 34db678..f24bec6 100644 --- a/chrome/browser/ui/browser_commands.cc +++ b/chrome/browser/ui/browser_commands.cc @@ -71,7 +71,6 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/renderer_preferences.h" #include "content/public/common/url_constants.h" #include "content/public/common/url_utils.h" @@ -232,7 +231,7 @@ void ReloadInternal(Browser* browser, WebContents* new_tab = GetTabAndRevertIfNecessary(browser, disposition); new_tab->UserGestureDone(); if (!new_tab->FocusLocationBarByDefault()) - new_tab->GetView()->Focus(); + new_tab->Focus(); if (ignore_cache) new_tab->GetController().ReloadIgnoringCache(true); else @@ -555,8 +554,7 @@ void NewTab(Browser* browser) { if (browser->is_type_tabbed()) { AddTabAt(browser, GURL(), -1, true); - browser->tab_strip_model()->GetActiveWebContents()->GetView()-> - RestoreFocus(); + browser->tab_strip_model()->GetActiveWebContents()->RestoreFocus(); } else { ScopedTabbedBrowserDisplayer displayer(browser->profile(), browser->host_desktop_type()); @@ -566,7 +564,7 @@ void NewTab(Browser* browser) { // The call to AddBlankTabAt above did not set the focus to the tab as its // window was not active, so we have to do it explicitly. // See http://crbug.com/6380. - b->tab_strip_model()->GetActiveWebContents()->GetView()->RestoreFocus(); + b->tab_strip_model()->GetActiveWebContents()->RestoreFocus(); } } diff --git a/chrome/browser/ui/browser_focus_uitest.cc b/chrome/browser/ui/browser_focus_uitest.cc index 4d1d1c3..7c95050 100644 --- a/chrome/browser/ui/browser_focus_uitest.cc +++ b/chrome/browser/ui/browser_focus_uitest.cc @@ -33,7 +33,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/test/browser_test_utils.h" #include "net/test/embedded_test_server/embedded_test_server.h" @@ -287,7 +286,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, DISABLED_TabsRememberFocus) { // Activate the location bar or the page. if (kFocusPage[i][j]) { - browser()->tab_strip_model()->GetWebContentsAt(j)->GetView()->Focus(); + browser()->tab_strip_model()->GetWebContentsAt(j)->Focus(); } else { chrome::FocusLocationBar(browser()); } diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc index 7bac258..d1d8e92 100644 --- a/chrome/browser/ui/browser_instant_controller.cc +++ b/chrome/browser/ui/browser_instant_controller.cc @@ -25,7 +25,6 @@ #include "content/public/browser/render_process_host.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" using base::UserMetricsAction; diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc index 2d65644..39cf2b5 100644 --- a/chrome/browser/ui/browser_navigator.cc +++ b/chrome/browser/ui/browser_navigator.cc @@ -39,7 +39,6 @@ #include "content/public/browser/notification_service.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_registry.h" #include "extensions/common/extension.h" #include "extensions/common/extension_set.h" @@ -340,7 +339,7 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params, tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url)); if (params.source_contents) { create_params.initial_size = - params.source_contents->GetView()->GetContainerSize(); + params.source_contents->GetContainerBounds().size(); if (params.should_set_opener) create_params.opener = params.source_contents; } @@ -661,7 +660,7 @@ void Navigate(NavigateParams* params) { (params->disposition == NEW_FOREGROUND_TAB || params->disposition == NEW_WINDOW) && (params->tabstrip_add_types & TabStripModel::ADD_INHERIT_OPENER)) - params->source_contents->GetView()->Focus(); + params->source_contents->Focus(); if (params->source_contents == params->target_contents || (swapped_in_prerender && params->disposition == CURRENT_TAB)) { diff --git a/chrome/browser/ui/browser_navigator_browsertest.cc b/chrome/browser/ui/browser_navigator_browsertest.cc index 9a8e237..4af97b9 100644 --- a/chrome/browser/ui/browser_navigator_browsertest.cc +++ b/chrome/browser/ui/browser_navigator_browsertest.cc @@ -6,6 +6,7 @@ #include "base/command_line.h" #include "base/prefs/pref_service.h" +#include "base/strings/string_util.h" #include "base/strings/utf_string_conversions.h" #include "chrome/app/chrome_command_ids.h" #include "chrome/browser/prefs/incognito_mode_prefs.h" @@ -26,8 +27,6 @@ #include "content/public/browser/notification_service.h" #include "content/public/browser/notification_types.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" -#include "ipc/ipc_message.h" using content::WebContents; @@ -131,7 +130,7 @@ WebContents* BrowserNavigatorTest::CreateWebContents() { browser()->tab_strip_model()->GetActiveWebContents(); if (base_web_contents) { create_params.initial_size = - base_web_contents->GetView()->GetContainerSize(); + base_web_contents->GetContainerBounds().size(); } return WebContents::Create(create_params); } @@ -736,7 +735,7 @@ IN_PROC_BROWSER_TEST_F(BrowserNavigatorTest, DISABLED_TargetContents_Popup) { // All platforms should respect size however provided width > 400 (Mac has a // minimum window width of 400). EXPECT_EQ(p.window_bounds.size(), - p.target_contents->GetView()->GetContainerSize()); + p.target_contents->GetContainerBounds().size()); // We should have two windows, the new popup and the browser() provided by the // framework. diff --git a/chrome/browser/ui/browser_tabrestore.cc b/chrome/browser/ui/browser_tabrestore.cc index 38a9a93..abe591c 100644 --- a/chrome/browser/ui/browser_tabrestore.cc +++ b/chrome/browser/ui/browser_tabrestore.cc @@ -17,7 +17,6 @@ #include "content/public/browser/navigation_entry.h" #include "content/public/browser/session_storage_namespace.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" using content::WebContents; using content::NavigationController; @@ -62,7 +61,7 @@ WebContents* CreateRestoredTab( browser->tab_strip_model()->GetActiveWebContents(); if (base_web_contents) { create_params.initial_size = - base_web_contents->GetView()->GetContainerSize(); + base_web_contents->GetContainerBounds().size(); } WebContents* web_contents = content::WebContents::CreateWithSessionStorage( create_params, diff --git a/chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.cc b/chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.cc index da6396e..33fd605 100644 --- a/chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.cc +++ b/chrome/browser/ui/chrome_web_modal_dialog_manager_delegate.cc @@ -6,7 +6,6 @@ #include "chrome/browser/platform_util.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" ChromeWebModalDialogManagerDelegate::ChromeWebModalDialogManagerDelegate() { } @@ -16,5 +15,5 @@ ChromeWebModalDialogManagerDelegate::~ChromeWebModalDialogManagerDelegate() { bool ChromeWebModalDialogManagerDelegate::IsWebContentsVisible( content::WebContents* web_contents) { - return platform_util::IsVisible(web_contents->GetView()->GetNativeView()); + return platform_util::IsVisible(web_contents->GetNativeView()); } diff --git a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm index f91c580..ecd390e 100644 --- a/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm +++ b/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm @@ -18,7 +18,6 @@ #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/common/extension.h" #include "third_party/skia/include/core/SkRegion.h" #include "ui/gfx/skia_util.h" @@ -349,7 +348,7 @@ NativeAppWindowCocoa::NativeAppWindowCocoa( window_controller_.reset( [[NativeAppWindowController alloc] initWithWindow:window.release()]); - NSView* view = WebContents()->GetView()->GetNativeView(); + NSView* view = WebContents()->GetNativeView(); [view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable]; InstallView(); @@ -387,7 +386,7 @@ NSUInteger NativeAppWindowCocoa::GetWindowStyleMask() const { } void NativeAppWindowCocoa::InstallView() { - NSView* view = WebContents()->GetView()->GetNativeView(); + NSView* view = WebContents()->GetNativeView(); if (has_frame_) { [view setFrame:[[window() contentView] bounds]]; [[window() contentView] addSubview:view]; @@ -420,7 +419,7 @@ void NativeAppWindowCocoa::InstallView() { } void NativeAppWindowCocoa::UninstallView() { - NSView* view = WebContents()->GetView()->GetNativeView(); + NSView* view = WebContents()->GetNativeView(); [view removeFromSuperview]; } @@ -666,7 +665,7 @@ void NativeAppWindowCocoa::UpdateDraggableRegionViews() { // All ControlRegionViews should be added as children of the WebContentsView, // because WebContentsView will be removed and re-added when entering and // leaving fullscreen mode. - NSView* webView = WebContents()->GetView()->GetNativeView(); + NSView* webView = WebContents()->GetNativeView(); NSInteger webViewWidth = NSWidth([webView bounds]); NSInteger webViewHeight = NSHeight([webView bounds]); @@ -716,7 +715,7 @@ bool NativeAppWindowCocoa::IsAlwaysOnTop() const { void NativeAppWindowCocoa::RenderViewCreated(content::RenderViewHost* rvh) { if (IsActive()) - WebContents()->GetView()->RestoreFocus(); + WebContents()->RestoreFocus(); } bool NativeAppWindowCocoa::IsFrameless() const { @@ -795,7 +794,7 @@ void NativeAppWindowCocoa::WindowDidBecomeKey() { rwhv->SetActive(true); app_window_->OnNativeWindowActivated(); - WebContents()->GetView()->RestoreFocus(); + WebContents()->RestoreFocus(); } void NativeAppWindowCocoa::WindowDidResignKey() { @@ -806,7 +805,7 @@ void NativeAppWindowCocoa::WindowDidResignKey() { if ([NSApp isActive] && ([NSApp keyWindow] == window())) return; - WebContents()->GetView()->StoreFocus(); + WebContents()->StoreFocus(); content::RenderWidgetHostView* rwhv = WebContents()->GetRenderWidgetHostView(); diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm index 459c488..546dd98 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa_browsertest.mm @@ -15,7 +15,6 @@ #include "components/autofill/core/browser/autofill_test_utils.h" #include "components/autofill/core/common/form_data.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/test/test_utils.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm index b5e42db..05215d8 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.mm @@ -20,7 +20,6 @@ #import "chrome/browser/ui/cocoa/autofill/autofill_textfield.h" #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #import "ui/base/cocoa/flipped_view.h" #include "ui/base/cocoa/window_size_constants.h" @@ -213,8 +212,7 @@ const CGFloat kMinimumContentsHeight = 101; - (CGFloat)maxHeight { NSRect dialogFrameRect = [[self window] frame]; - NSRect browserFrameRect = - [webContents_->GetView()->GetTopLevelNativeWindow() frame]; + NSRect browserFrameRect = [webContents_->GetTopLevelNativeWindow() frame]; dialogFrameRect.size.height = NSMaxY(dialogFrameRect) - NSMinY(browserFrameRect); dialogFrameRect = [[self window] contentRectForFrameRect:dialogFrameRect]; diff --git a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm index 92fd47e..7293c4b 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm @@ -17,7 +17,6 @@ #include "components/autofill/content/browser/wallet/wallet_service_url.h" #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" namespace { @@ -77,7 +76,7 @@ void CocoaSignInDelegate::HandleKeyboardEvent( webContents_.reset( content::WebContents::Create( content::WebContents::CreateParams(dialog_->delegate()->profile()))); - NSView* webContentView = webContents_->GetView()->GetNativeView(); + NSView* webContentView = webContents_->GetNativeView(); [self setView:webContentView]; } diff --git a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm index 29780df..48ea1bd 100644 --- a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm +++ b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container_unittest.mm @@ -12,7 +12,6 @@ #include "chrome/test/base/testing_profile.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "testing/gtest/include/gtest/gtest.h" #include "testing/platform_test.h" #import "ui/gfx/test/ui_cocoa_test_helper.h" @@ -69,7 +68,7 @@ TEST_F(AutofillSignInContainerTest, Subviews) { // isKindOfClass would be the better choice, but // WebContentsViewCocoaClass is defined in content, and not public. bool hasWebView =[[container_ view] isEqual: - [container_ webContents]->GetView()->GetNativeView()]; + [container_ webContents]->GetNativeView()]; EXPECT_TRUE(hasWebView); } diff --git a/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm b/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm index 4ce5514..3176b3b 100644 --- a/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm +++ b/chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm @@ -15,7 +15,6 @@ #import "chrome/browser/ui/cocoa/info_bubble_window.h" #include "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h" #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" -#include "content/public/browser/web_contents_view.h" #include "skia/ext/skia_utils_mac.h" #include "ui/base/cocoa/window_size_constants.h" #include "ui/native_theme/native_theme.h" @@ -195,7 +194,7 @@ GeneratedCreditCardBubbleCocoa::~GeneratedCreditCardBubbleCocoa() {} void GeneratedCreditCardBubbleCocoa::Show() { DCHECK(controller_.get()); NSView* browser_view = - controller_->web_contents()->GetView()->GetNativeView(); + controller_->web_contents()->GetNativeView(); NSWindow* parent_window = [browser_view window]; LocationBarViewMac* location_bar = [[parent_window windowController] locationBarBridge]; diff --git a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm index 2ac24ae..06bcd7a 100644 --- a/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm +++ b/chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa.mm @@ -16,7 +16,6 @@ #import "chrome/browser/ui/cocoa/info_bubble_window.h" #import "chrome/browser/ui/cocoa/toolbar/toolbar_controller.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "skia/ext/skia_utils_mac.h" #import "ui/base/cocoa/controls/hyperlink_button_cell.h" #include "ui/base/cocoa/window_size_constants.h" @@ -199,8 +198,7 @@ NewCreditCardBubbleCocoa::~NewCreditCardBubbleCocoa() { } void NewCreditCardBubbleCocoa::Show() { - NSView* browser_view = - controller_->web_contents()->GetView()->GetNativeView(); + NSView* browser_view = controller_->web_contents()->GetNativeView(); NSWindow* parent_window = [browser_view window]; BrowserWindowController* bwc = [BrowserWindowController browserWindowControllerForWindow:parent_window]; diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm index eeba838..64c9972 100644 --- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm +++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm @@ -51,7 +51,6 @@ #include "components/bookmarks/core/browser/bookmark_utils.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_registry.h" #include "extensions/common/extension.h" #include "extensions/common/extension_set.h" diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm index 106d1ba..e503c92 100644 --- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm +++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm @@ -54,7 +54,6 @@ #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util_mac.h" @@ -74,7 +73,7 @@ namespace { NSPoint GetPointForBubble(content::WebContents* web_contents, int x_offset, int y_offset) { - NSView* view = web_contents->GetView()->GetNativeView(); + NSView* view = web_contents->GetNativeView(); NSRect bounds = [view bounds]; NSPoint point; point.x = NSMinX(bounds) + x_offset; diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm index 5fd720a..efb847c 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller.mm @@ -84,7 +84,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "grit/locale_settings.h" diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm index 403c00e..b8620ea 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm @@ -34,7 +34,6 @@ #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/testing_profile.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #import "testing/gtest_mac.h" namespace { @@ -356,17 +355,17 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, // visible. IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest, AllowOverlappingViewsHistoryOverlay) { - content::WebContentsView* web_contents_view = - browser()->tab_strip_model()->GetActiveWebContents()->GetView(); - EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews()); + content::WebContents* web_contents = + browser()->tab_strip_model()->GetActiveWebContents(); + EXPECT_TRUE(web_contents->GetAllowOverlappingViews()); base::scoped_nsobject<HistoryOverlayController> overlay( [[HistoryOverlayController alloc] initForMode:kHistoryOverlayModeBack]); - [overlay showPanelForView:web_contents_view->GetNativeView()]; - EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews()); + [overlay showPanelForView:web_contents->GetNativeView()]; + EXPECT_TRUE(web_contents->GetAllowOverlappingViews()); overlay.reset(); - EXPECT_TRUE(web_contents_view->GetAllowOverlappingViews()); + EXPECT_TRUE(web_contents->GetAllowOverlappingViews()); } // Tests that status bubble's base frame does move when devTools are docked. diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm index 65c4c4a..3ca8021 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm @@ -41,7 +41,6 @@ #include "chrome/common/pref_names.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #import "ui/base/cocoa/focus_tracker.h" #include "ui/base/ui_base_types.h" @@ -999,12 +998,12 @@ willPositionSheet:(NSWindow*)sheet // transitioning between composited and non-composited mode. // http://crbug.com/279472 allowOverlappingViews = YES; - contents->GetView()->SetAllowOverlappingViews(allowOverlappingViews); + contents->SetAllowOverlappingViews(allowOverlappingViews); DevToolsWindow* devToolsWindow = DevToolsWindow::GetDockedInstanceForInspectedTab(contents); if (devToolsWindow) { - devToolsWindow->web_contents()->GetView()-> + devToolsWindow->web_contents()-> SetAllowOverlappingViews(allowOverlappingViews); } } diff --git a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm index ca4d5b1..4f83ff5 100644 --- a/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm +++ b/chrome/browser/ui/cocoa/certificate_viewer_mac_browsertest.mm @@ -11,7 +11,6 @@ #include "chrome/test/base/in_process_browser_test.h" #include "components/web_modal/web_contents_modal_dialog_manager.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/test/test_utils.h" #include "net/base/test_data_directory.h" #include "net/cert/x509_certificate.h" @@ -34,7 +33,7 @@ IN_PROC_BROWSER_TEST_F(SSLCertificateViewerCocoaTest, Basic) { ASSERT_TRUE(cert.get()); content::WebContents* web_contents = browser()->tab_strip_model()->GetActiveWebContents(); - gfx::NativeWindow window = web_contents->GetView()->GetTopLevelNativeWindow(); + gfx::NativeWindow window = web_contents->GetTopLevelNativeWindow(); WebContentsModalDialogManager* web_contents_modal_dialog_manager = WebContentsModalDialogManager::FromWebContents(web_contents); EXPECT_FALSE(web_contents_modal_dialog_manager->IsDialogActive()); diff --git a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm index 36529a9..9ec3864 100644 --- a/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm +++ b/chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm @@ -11,7 +11,6 @@ #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_custom_window.h" #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/size.h" #include "ui/web_dialogs/web_dialog_delegate.h" #include "ui/web_dialogs/web_dialog_ui.h" @@ -115,9 +114,8 @@ ConstrainedWebDialogDelegateViewMac::ConstrainedWebDialogDelegateViewMac( window_.reset( [[ConstrainedWindowCustomWindow alloc] initWithContentRect:frame]); - [GetWebContents()->GetView()->GetNativeView() setFrame:frame]; - [[window_ contentView] - addSubview:GetWebContents()->GetView()->GetNativeView()]; + [GetWebContents()->GetNativeView() setFrame:frame]; + [[window_ contentView] addSubview:GetWebContents()->GetNativeView()]; base::scoped_nsobject<CustomConstrainedWindowSheet> sheet( [[CustomConstrainedWindowSheet alloc] initWithCustomWindow:window_]); diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm index c3a2b4f4..92a7b68 100644 --- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm +++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm @@ -13,7 +13,6 @@ #include "components/web_modal/web_contents_modal_dialog_manager.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" using web_modal::WebContentsModalDialogManager; using web_modal::NativeWebContentsModalDialog; @@ -90,5 +89,5 @@ NSWindow* ConstrainedWindowMac::GetParentWindow() const { if (browser) return browser->window()->GetNativeWindow(); - return web_contents_->GetView()->GetTopLevelNativeWindow(); + return web_contents_->GetTopLevelNativeWindow(); } diff --git a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm index 76593a3..021c33e 100644 --- a/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm +++ b/chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm @@ -13,7 +13,6 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/in_process_browser_test.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "testing/gmock/include/gmock/gmock.h" #include "url/gurl.h" @@ -100,7 +99,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, ShowInUninitializedTab) { content::WebContents* tab2 = browser()->tab_strip_model()->GetWebContentsAt(2); ASSERT_TRUE(tab2); - EXPECT_FALSE([tab2->GetView()->GetNativeView() superview]); + EXPECT_FALSE([tab2->GetNativeView() superview]); // Show dialog and verify that it's not visible yet. NiceMock<ConstrainedWindowDelegateMock> delegate; @@ -109,7 +108,7 @@ IN_PROC_BROWSER_TEST_F(ConstrainedWindowMacTest, ShowInUninitializedTab) { // Activate the tab and verify that the constrained window is shown. browser()->tab_strip_model()->ActivateTabAt(2, true); - EXPECT_TRUE([tab2->GetView()->GetNativeView() superview]); + EXPECT_TRUE([tab2->GetNativeView() superview]); EXPECT_TRUE([sheet_window_ isVisible]); EXPECT_EQ(1.0, [sheet_window_ alphaValue]); diff --git a/chrome/browser/ui/cocoa/dev_tools_controller.mm b/chrome/browser/ui/cocoa/dev_tools_controller.mm index 1d291de..5d65f1e4 100644 --- a/chrome/browser/ui/cocoa/dev_tools_controller.mm +++ b/chrome/browser/ui/cocoa/dev_tools_controller.mm @@ -15,7 +15,6 @@ #import "chrome/browser/ui/cocoa/view_id_util.h" #include "chrome/common/pref_names.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/base/cocoa/base_view.h" #include "ui/base/cocoa/focus_tracker.h" #include "ui/gfx/mac/scoped_ns_disable_screen_updates.h" @@ -132,8 +131,8 @@ using content::WebContents; if (devToolsWindow_) { const DevToolsContentsResizingStrategy& strategy = devToolsWindow_->GetContentsResizingStrategy(); - devToolsWindow_->web_contents()->GetView()->SetOverlayView( - contents->GetView(), + devToolsWindow_->web_contents()->SetOverlayView( + contents, gfx::Point(strategy.insets().left(), strategy.insets().top())); [devToolsContainerView_ setContentsResizingStrategy:strategy]; } else { @@ -154,15 +153,14 @@ using content::WebContents; // |devToolsView| is a WebContentsViewCocoa object, whose ViewID was // set to VIEW_ID_TAB_CONTAINER initially, so we need to change it to // VIEW_ID_DEV_TOOLS_DOCKED here. - NSView* devToolsView = - devToolsWindow_->web_contents()->GetView()->GetNativeView(); + NSView* devToolsView = devToolsWindow_->web_contents()->GetNativeView(); view_id_util::SetID(devToolsView, VIEW_ID_DEV_TOOLS_DOCKED); [devToolsContainerView_ showDevTools:devToolsView]; } - (void)hideDevToolsView { - devToolsWindow_->web_contents()->GetView()->RemoveOverlayView(); + devToolsWindow_->web_contents()->RemoveOverlayView(); [devToolsContainerView_ hideDevTools]; [focusTracker_ restoreFocusInWindow:[devToolsContainerView_ window]]; focusTracker_.reset(); diff --git a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm index ad93cce..c850488 100644 --- a/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm +++ b/chrome/browser/ui/cocoa/dev_tools_controller_browsertest.mm @@ -14,7 +14,6 @@ #include "chrome/common/url_constants.h" #include "chrome/test/base/in_process_browser_test.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" class DevToolsControllerTest : public InProcessBrowserTest { public: @@ -35,17 +34,15 @@ IN_PROC_BROWSER_TEST_F(DevToolsControllerTest, AllowOverlappingViews) { browser()->tab_strip_model()->GetActiveWebContents(); DevToolsWindow* dev_tools = DevToolsWindow::GetDockedInstanceForInspectedTab(web_contents); - content::WebContentsView* dev_tools_view = - dev_tools->web_contents()->GetView(); // Without the find bar. - EXPECT_TRUE(dev_tools_view->GetAllowOverlappingViews()); + EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews()); // With the find bar. browser()->GetFindBarController()->find_bar()->Show(false); - EXPECT_TRUE(dev_tools_view->GetAllowOverlappingViews()); + EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews()); // Without the find bar. browser()->GetFindBarController()->find_bar()->Hide(false); - EXPECT_TRUE(dev_tools_view->GetAllowOverlappingViews()); + EXPECT_TRUE(dev_tools->web_contents()->GetAllowOverlappingViews()); } diff --git a/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm b/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm index 48f937d..2e5270ce 100644 --- a/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm +++ b/chrome/browser/ui/cocoa/download/download_started_animation_mac.mm @@ -14,7 +14,6 @@ #include "base/logging.h" #import "chrome/browser/ui/cocoa/animatable_image.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/theme_resources.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h" #include "third_party/skia/include/utils/mac/SkCGUtils.h" @@ -49,8 +48,7 @@ class DownloadAnimationWebObserver; // against the left edge, and three times the download image's height from // the bottom of the tab, assuming there is enough room. If there isn't // enough, don't show the animation and let the shelf speak for itself. - gfx::Rect bounds; - webContents->GetView()->GetContainerBounds(&bounds); + gfx::Rect bounds = webContents->GetContainerBounds(); imageWidth_ = [image size].width; CGFloat imageHeight = [image size].height; @@ -60,7 +58,7 @@ class DownloadAnimationWebObserver; return nil; } - NSView* tabContentsView = webContents->GetView()->GetNativeView(); + NSView* tabContentsView = webContents->GetNativeView(); NSWindow* parentWindow = [tabContentsView window]; if (!parentWindow) { // The tab is no longer frontmost. diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm index b776789..f0a61c2 100644 --- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm +++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm @@ -9,7 +9,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_host.h" #include "extensions/common/view_type.h" @@ -36,7 +35,7 @@ void ExtensionViewMac::Init() { } gfx::NativeView ExtensionViewMac::native_view() { - return extension_host_->host_contents()->GetView()->GetNativeView(); + return extension_host_->host_contents()->GetNativeView(); } content::RenderViewHost* ExtensionViewMac::render_view_host() const { diff --git a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm index fd7123b..b328234 100644 --- a/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm +++ b/chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm @@ -24,7 +24,6 @@ #include "chrome/browser/ui/find_bar/find_tab_helper.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #import "third_party/google_toolbox_for_mac/src/AppKit/GTMNSAnimation+Duration.h" #import "ui/base/cocoa/find_pasteboard.h" #import "ui/base/cocoa/focus_tracker.h" @@ -328,7 +327,7 @@ const float kRightEdgeOffset = 25; if (!(focusTracker_.get() && [focusTracker_ restoreFocusInWindow:[findBarView_ window]])) { // Fall back to giving focus to the tab contents. - findBarBridge_->GetFindBarController()->web_contents()->GetView()->Focus(); + findBarBridge_->GetFindBarController()->web_contents()->Focus(); } focusTracker_.reset(nil); } @@ -541,7 +540,7 @@ const float kRightEdgeOffset = 25; return frame.origin.x; // Get the size of the container. - gfx::Rect containerRect(contents->GetView()->GetContainerSize()); + gfx::Rect containerRect(contents->GetContainerBounds().size()); // Position the FindBar on the top right corner. viewRect.set_x( diff --git a/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm b/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm index 496478d..2c46ba3 100644 --- a/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm +++ b/chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm @@ -17,7 +17,6 @@ #include "chrome/browser/ui/cocoa/infobars/infobar_cocoa.h" #import "chrome/browser/ui/cocoa/menu_button.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/common/constants.h" #include "extensions/common/extension.h" #include "extensions/common/extension_icon_set.h" diff --git a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm index ef8f353..8337fcf 100644 --- a/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm +++ b/chrome/browser/ui/cocoa/panels/panel_window_controller_cocoa.mm @@ -33,7 +33,6 @@ #include "chrome/browser/ui/toolbar/encoding_menu_controller.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/ui_resources.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/image/image.h" @@ -231,7 +230,7 @@ const double kWidthOfMouseResizeArea = 15.0; NSRect contentFrame = [self contentRectForFrameRect:[[self window] frame]]; contentFrame.origin = NSZeroPoint; - NSView* contentView = webContents->GetView()->GetNativeView(); + NSView* contentView = webContents->GetNativeView(); if (!NSEqualRects([contentView frame], contentFrame)) [contentView setFrame:contentFrame]; } @@ -331,7 +330,7 @@ const double kWidthOfMouseResizeArea = 15.0; } - (void)webContentsInserted:(WebContents*)contents { - NSView* view = contents->GetView()->GetNativeView(); + NSView* view = contents->GetNativeView(); [[[self window] contentView] addSubview:view]; [view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable]; @@ -339,7 +338,7 @@ const double kWidthOfMouseResizeArea = 15.0; } - (void)webContentsDetached:(WebContents*)contents { - [contents->GetView()->GetNativeView() removeFromSuperview]; + [contents->GetNativeView() removeFromSuperview]; } - (PanelTitlebarViewCocoa*)titlebarView { @@ -691,7 +690,7 @@ const double kWidthOfMouseResizeArea = 15.0; content::WebContents* webContents = panel->GetWebContents(); if (!webContents) return; - NSView* contentView = webContents->GetView()->GetNativeView(); + NSView* contentView = webContents->GetNativeView(); if (NSHeight([self contentRectForFrameRect:[[self window] frame]]) <= 0) { // No need to retain the view before it is removed from its superview // because WebContentsView keeps a reference to this view. diff --git a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm index dfb5158..f5f6f26 100644 --- a/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm +++ b/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm @@ -42,7 +42,6 @@ #include "components/signin/core/browser/signin_manager.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "google_apis/gaia/oauth2_token_service.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" @@ -1372,7 +1371,7 @@ class ActiveProfileObserverBridge : public AvatarMenuObserver, content::Referrer(), content::PAGE_TRANSITION_AUTO_TOPLEVEL, std::string()); - NSView* webview = webContents_->GetView()->GetNativeView(); + NSView* webview = webContents_->GetNativeView(); [webview setFrameSize:NSMakeSize(kFixedGaiaViewWidth, kFixedGaiaViewHeight)]; [container addSubview:webview]; yOffset = NSMaxY([webview frame]); diff --git a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm index 89a0cb5..3087ac4 100644 --- a/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm +++ b/chrome/browser/ui/cocoa/profiles/user_manager_mac.mm @@ -8,7 +8,6 @@ #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ui/browser_dialogs.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util_mac.h" @@ -83,7 +82,7 @@ void HideUserManager() { // Initialize the web view. webContents_.reset(content::WebContents::Create( content::WebContents::CreateParams(profile))); - window.contentView = webContents_->GetView()->GetNativeView(); + window.contentView = webContents_->GetNativeView(); DCHECK(window.contentView); [[NSNotificationCenter defaultCenter] diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm index e1e228a..f08ed53 100644 --- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm +++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa.mm @@ -15,7 +15,6 @@ #import "chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "net/cert/x509_certificate.h" #include "net/cert/x509_util_mac.h" diff --git a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm index fe81885..c9db177 100644 --- a/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm +++ b/chrome/browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm @@ -15,7 +15,6 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "components/web_modal/web_contents_modal_dialog_manager.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/test/test_utils.h" #include "ui/base/cocoa/window_size_constants.h" diff --git a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm index 5fdc5be..3e6d73c 100644 --- a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm +++ b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm @@ -10,7 +10,6 @@ #include "chrome/browser/ui/tab_contents/chrome_web_contents_view_delegate.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" ChromeWebContentsViewDelegateMac::ChromeWebContentsViewDelegateMac( content::WebContents* web_contents) diff --git a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm index 0511375..50b743a 100644 --- a/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm +++ b/chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.mm @@ -5,7 +5,6 @@ #import "chrome/browser/ui/cocoa/tab_contents/overlayable_contents_controller.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" @implementation OverlayableContentsController diff --git a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm index df5da7a..70732b0 100644 --- a/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm +++ b/chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm @@ -8,7 +8,6 @@ #include "base/mac/mac_util.h" #import "chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" namespace chrome { @@ -42,7 +41,7 @@ void SadTabCocoa::Close() { webContents_ = webContents; if (webContents_) { // NULL in unit_tests. - NSView* ns_view = webContents_->GetView()->GetNativeView(); + NSView* ns_view = webContents_->GetNativeView(); [[self view] setAutoresizingMask: (NSViewWidthSizable | NSViewHeightSizable)]; [ns_view addSubview:[self view]]; diff --git a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm index e0b033b32..b49b82d 100644 --- a/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm +++ b/chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm @@ -17,7 +17,6 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_observer.h" -#include "content/public/browser/web_contents_view.h" #include "ui/base/cocoa/animation_utils.h" #include "ui/base/ui_base_switches.h" #include "ui/gfx/geometry/rect.h" @@ -222,7 +221,7 @@ class FullscreenObserver : public WebContentsObserver { contentsNativeView = fullscreenView->GetNativeView(); } else { isEmbeddingFullscreenWidget_ = NO; - contentsNativeView = contents_->GetView()->GetNativeView(); + contentsNativeView = contents_->GetNativeView(); } [contentsNativeView setFrame:[self frameForContentsView]]; if ([subviews count] == 0) { @@ -242,7 +241,7 @@ class FullscreenObserver : public WebContentsObserver { // transitioning between composited and non-composited mode. // http://crbug.com/279472 if (!fullscreenView) - contents_->GetView()->SetAllowOverlappingViews(true); + contents_->SetAllowOverlappingViews(true); } - (void)changeWebContents:(WebContents*)newContents { diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm index 36c20f0..b89ffb1 100644 --- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm +++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm @@ -57,7 +57,6 @@ #include "content/public/browser/navigation_controller.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" #include "grit/ui_resources.h" @@ -1311,7 +1310,7 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) { // Called before |contents| is deactivated. - (void)tabDeactivatedWithContents:(content::WebContents*)contents { - contents->GetView()->StoreFocus(); + contents->StoreFocus(); } // Called when a notification is received from the model to select a particular @@ -1357,7 +1356,7 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) { if (newContents) { newContents->WasShown(); - newContents->GetView()->RestoreFocus(); + newContents->RestoreFocus(); } } @@ -2235,5 +2234,5 @@ NSView* GetSheetParentViewForWebContents(WebContents* web_contents) { // // Changing it? Do not forget to modify // -[TabStripController swapInTabAtIndex:] too. - return [web_contents->GetView()->GetNativeView() superview]; + return [web_contents->GetNativeView() superview]; } diff --git a/chrome/browser/ui/cocoa/web_dialog_window_controller.mm b/chrome/browser/ui/cocoa/web_dialog_window_controller.mm index db0be89..8c31923 100644 --- a/chrome/browser/ui/cocoa/web_dialog_window_controller.mm +++ b/chrome/browser/ui/cocoa/web_dialog_window_controller.mm @@ -13,7 +13,6 @@ #include "chrome/browser/ui/webui/chrome_web_contents_handler.h" #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui_message_handler.h" #include "ui/events/keycodes/keyboard_codes.h" #include "ui/gfx/size.h" @@ -344,7 +343,7 @@ void WebDialogWindowDelegateBridge::HandleKeyboardEvent( - (void)loadDialogContents { webContents_.reset(WebContents::Create( WebContents::CreateParams(delegate_->browser_context()))); - [[self window] setContentView:webContents_->GetView()->GetNativeView()]; + [[self window] setContentView:webContents_->GetNativeView()]; webContents_->SetDelegate(delegate_.get()); // This must be done before loading the page; see the comments in diff --git a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm index 3984236..1d67b3c 100644 --- a/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm +++ b/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm @@ -10,7 +10,6 @@ #import "chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.h" #import "chrome/browser/ui/website_settings/permission_bubble_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" PermissionBubbleCocoa::PermissionBubbleCocoa(NSWindow* parent_window) : parent_window_(parent_window), delegate_(NULL), bubbleController_(nil) {} diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc index b96c1ab..f5b8f16 100644 --- a/chrome/browser/ui/extensions/application_launch.cc +++ b/chrome/browser/ui/extensions/application_launch.cc @@ -33,7 +33,6 @@ #include "chrome/common/url_constants.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/renderer_preferences.h" #include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_registry.h" @@ -217,7 +216,7 @@ WebContents* OpenApplicationWindow(const AppLaunchParams& params) { // TODO(jcampan): http://crbug.com/8123 we should not need to set the initial // focus explicitly. - web_contents->GetView()->SetInitialFocus(); + web_contents->SetInitialFocus(); return web_contents; } diff --git a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc index 4f0bf21..1a2ab5d 100644 --- a/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc +++ b/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc @@ -36,14 +36,12 @@ #include "content/public/browser/notification_types.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/test/browser_test_utils.h" #include "net/base/filename_util.h" #include "ui/base/accelerators/accelerator.h" #include "ui/events/keycodes/keyboard_codes.h" #if defined(OS_WIN) -#include "content/public/browser/web_contents_view.h" #include "ui/aura/window.h" #include "ui/aura/window_tree_host.h" #endif @@ -1597,8 +1595,7 @@ IN_PROC_BROWSER_TEST_F(FindInPageControllerTest, WindowedNPAPIPluginHidden) { EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle()); // Now get the region of the plugin before the find bar is shown. - HWND hwnd = - tab->GetView()->GetNativeView()->GetHost()->GetAcceleratedWidget(); + HWND hwnd = tab->GetNativeView()->GetHost()->GetAcceleratedWidget(); HWND child = NULL; EnumChildWindows(hwnd, EnumerateChildren,reinterpret_cast<LPARAM>(&child)); diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller.cc b/chrome/browser/ui/fullscreen/fullscreen_controller.cc index a99b0e3..53d83b1 100644 --- a/chrome/browser/ui/fullscreen/fullscreen_controller.cc +++ b/chrome/browser/ui/fullscreen/fullscreen_controller.cc @@ -27,7 +27,6 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/common/extension.h" #if defined(OS_MACOSX) diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc index d7dd1cb..e065327 100644 --- a/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc +++ b/chrome/browser/ui/fullscreen/fullscreen_controller_state_unittest.cc @@ -11,7 +11,6 @@ #include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/browser_with_test_window_test.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/url_constants.h" #include "testing/gtest/include/gtest/gtest.h" @@ -525,7 +524,7 @@ TEST_F(FullscreenControllerStateUnitTest, OneCapturedFullscreenedTab) { // TODO(miu): Need to make an adjustment to content::WebContentsViewMac for // the following to work: #if !defined(OS_MACOSX) - EXPECT_EQ(kCaptureSize, first_tab->GetView()->GetViewBounds().size()); + EXPECT_EQ(kCaptureSize, first_tab->GetViewBounds().size()); #endif // Switch back to the first tab and exit fullscreen. diff --git a/chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc b/chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc index 5800fcf..345a9e8 100644 --- a/chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc +++ b/chrome/browser/ui/omnibox/omnibox_current_page_delegate_impl.cc @@ -19,7 +19,6 @@ #include "chrome/browser/ui/search/search_tab_helper.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/base/window_open_disposition.h" #include "url/gurl.h" @@ -101,8 +100,7 @@ void OmniboxCurrentPageDelegateImpl::OnFocusChanged( void OmniboxCurrentPageDelegateImpl::DoPrerender( const AutocompleteMatch& match) { content::WebContents* web_contents = controller_->GetWebContents(); - gfx::Rect container_bounds; - web_contents->GetView()->GetContainerBounds(&container_bounds); + gfx::Rect container_bounds = web_contents->GetContainerBounds(); InstantSearchPrerenderer* prerenderer = InstantSearchPrerenderer::GetForProfile(profile_); diff --git a/chrome/browser/ui/sad_tab_helper.cc b/chrome/browser/ui/sad_tab_helper.cc index 8ad27ec..ab8a6e0 100644 --- a/chrome/browser/ui/sad_tab_helper.cc +++ b/chrome/browser/ui/sad_tab_helper.cc @@ -8,7 +8,6 @@ #include "chrome/browser/browser_shutdown.h" #include "chrome/browser/ui/sad_tab.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" DEFINE_WEB_CONTENTS_USER_DATA_KEY(SadTabHelper); diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc index 396904b..7361475 100644 --- a/chrome/browser/ui/search/instant_controller.cc +++ b/chrome/browser/ui/search/instant_controller.cc @@ -31,7 +31,6 @@ #include "content/public/browser/render_process_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "net/base/escape.h" #include "net/base/network_change_notifier.h" #include "url/gurl.h" @@ -91,7 +90,7 @@ bool InstantController::SubmitQuery(const base::string16& search_terms) { // page. (NOTE: in particular, we do not send the query to NTPs.) SearchTabHelper::FromWebContents(instant_tab_->contents())->Submit( search_terms); - instant_tab_->contents()->GetView()->Focus(); + instant_tab_->contents()->Focus(); EnsureSearchTermsAreSet(instant_tab_->contents(), search_terms); return true; } diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc index bdb18dd..b479686 100644 --- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc +++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc @@ -68,7 +68,6 @@ #include "content/public/browser/site_instance.h" #include "content/public/browser/url_data_source.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/bindings_policy.h" #include "content/public/test/browser_test_utils.h" #include "content/public/test/test_utils.h" diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc index e9c9779..4bc6991 100644 --- a/chrome/browser/ui/search/search_tab_helper.cc +++ b/chrome/browser/ui/search/search_tab_helper.cc @@ -39,7 +39,6 @@ #include "content/public/browser/render_process_host.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/page_transition_types.h" #include "content/public/common/referrer.h" #include "grit/generated_resources.h" @@ -432,7 +431,7 @@ void SearchTabHelper::FocusOmnibox(OmniboxFocusState state) { // from changing the omnibox value and closing the popup without user // interaction. if (!omnibox->model()->popup_model()->IsOpen()) - web_contents()->GetView()->Focus(); + web_contents()->Focus(); break; } #endif diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc index f281cc0..2caa700 100644 --- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc +++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc @@ -88,7 +88,6 @@ #include "content/public/browser/notification_registrar.h" #include "content/public/browser/storage_partition.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_prefs.h" #include "extensions/browser/extension_registry.h" #include "extensions/browser/extension_system.h" diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc index 82c0af5..d0510b6 100644 --- a/chrome/browser/ui/sync/one_click_signin_helper.cc +++ b/chrome/browser/ui/sync/one_click_signin_helper.cc @@ -74,7 +74,6 @@ #include "content/public/browser/render_process_host.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/frame_navigate_params.h" #include "content/public/common/page_transition_types.h" #include "google_apis/gaia/gaia_auth_util.h" diff --git a/chrome/browser/ui/tabs/tab_strip_model.cc b/chrome/browser/ui/tabs/tab_strip_model.cc index 02c2ccd..06ac829 100644 --- a/chrome/browser/ui/tabs/tab_strip_model.cc +++ b/chrome/browser/ui/tabs/tab_strip_model.cc @@ -26,8 +26,6 @@ #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_observer.h" -#include "content/public/browser/web_contents_view.h" - using base::UserMetricsAction; using content::WebContents; @@ -840,7 +838,7 @@ void TabStripModel::AddWebContents(WebContents* contents, if (WebContents* old_contents = GetActiveWebContents()) { if ((add_types & ADD_ACTIVE) == 0) { apps::ResizeWebContents(contents, - old_contents->GetView()->GetContainerSize()); + old_contents->GetContainerBounds().size()); } } } diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc index 7a38f8e..6168bef 100644 --- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc +++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc @@ -25,7 +25,6 @@ #include "content/public/browser/native_web_keyboard_event.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/theme_resources.h" #include "grit/ui_resources.h" #include "third_party/skia/include/core/SkColor.h" @@ -1257,7 +1256,7 @@ void AutofillDialogViews::Show() { // Listen for size changes on the browser. views::Widget* browser_widget = views::Widget::GetTopLevelWidgetForNativeView( - delegate_->GetWebContents()->GetView()->GetNativeView()); + delegate_->GetWebContents()->GetNativeView()); observer_.Add(browser_widget); // Listen for unhandled mouse presses on the non-client view. diff --git a/chrome/browser/ui/views/color_chooser_aura.cc b/chrome/browser/ui/views/color_chooser_aura.cc index 720f90c..f8d7602 100644 --- a/chrome/browser/ui/views/color_chooser_aura.cc +++ b/chrome/browser/ui/views/color_chooser_aura.cc @@ -8,7 +8,6 @@ #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_window.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/views/color_chooser/color_chooser_view.h" #include "ui/views/widget/widget.h" @@ -17,7 +16,7 @@ ColorChooserAura::ColorChooserAura(content::WebContents* web_contents, : web_contents_(web_contents) { view_ = new views::ColorChooserView(this, initial_color); widget_ = views::Widget::CreateWindowWithParent( - view_, web_contents->GetView()->GetTopLevelNativeWindow()); + view_, web_contents->GetTopLevelNativeWindow()); widget_->Show(); } diff --git a/chrome/browser/ui/views/color_chooser_win.cc b/chrome/browser/ui/views/color_chooser_win.cc index 0fde020..d4f07c1 100644 --- a/chrome/browser/ui/views/color_chooser_win.cc +++ b/chrome/browser/ui/views/color_chooser_win.cc @@ -12,7 +12,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/views/color_chooser/color_chooser_listener.h" #if defined(USE_ASH) @@ -104,7 +103,7 @@ namespace chrome { content::ColorChooser* ShowColorChooser(content::WebContents* web_contents, SkColor initial_color) { #if defined(USE_ASH) - gfx::NativeView native_view = web_contents->GetView()->GetNativeView(); + gfx::NativeView native_view = web_contents->GetNativeView(); if (GetHostDesktopTypeForNativeView(native_view) == HOST_DESKTOP_TYPE_ASH) return ColorChooserAura::Open(web_contents, initial_color); #endif diff --git a/chrome/browser/ui/views/download/download_started_animation_views.cc b/chrome/browser/ui/views/download/download_started_animation_views.cc index fcde0a2..aaa37ca 100644 --- a/chrome/browser/ui/views/download/download_started_animation_views.cc +++ b/chrome/browser/ui/views/download/download_started_animation_views.cc @@ -5,7 +5,6 @@ #include "chrome/browser/download/download_started_animation.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/theme_resources.h" #include "ui/base/resource/resource_bundle.h" #include "ui/gfx/animation/linear_animation.h" @@ -67,7 +66,7 @@ DownloadStartedAnimationViews::DownloadStartedAnimationViews( // If we're too small to show the download image, then don't bother - // the shelf will be enough. - web_contents->GetView()->GetContainerBounds(&web_contents_bounds_); + web_contents_bounds_= web_contents->GetContainerBounds(); if (web_contents_bounds_.height() < kDownloadImage->height()) return; @@ -78,7 +77,7 @@ DownloadStartedAnimationViews::DownloadStartedAnimationViews( views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP); params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW; params.accept_events = false; - params.parent = web_contents->GetView()->GetNativeView(); + params.parent = web_contents->GetNativeView(); popup_->Init(params); popup_->SetOpacity(0x00); popup_->SetContentsView(this); diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc index 1d8aec9..ba2c1c7 100644 --- a/chrome/browser/ui/views/extensions/extension_dialog.cc +++ b/chrome/browser/ui/views/extensions/extension_dialog.cc @@ -15,7 +15,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/base/base_window.h" #include "ui/gfx/screen.h" #include "ui/views/background.h" @@ -78,7 +77,7 @@ ExtensionDialog* ExtensionDialog::Show( host->view()->SetVisible(true); // Ensure the DOM JavaScript can respond immediately to keyboard shortcuts. - host->host_contents()->GetView()->Focus(); + host->host_contents()->Focus(); return dialog; } diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc index dcacc5a..5ae93cc 100644 --- a/chrome/browser/ui/views/extensions/extension_popup.cc +++ b/chrome/browser/ui/views/extensions/extension_popup.cc @@ -23,7 +23,6 @@ #include "content/public/browser/notification_source.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/insets.h" #include "ui/views/layout/fill_layout.h" #include "ui/views/widget/widget.h" @@ -251,7 +250,7 @@ void ExtensionPopup::ShowBubble() { GetWidget()->Show(); // Focus on the host contents when the bubble is first shown. - host()->host_contents()->GetView()->Focus(); + host()->host_contents()->Focus(); if (inspect_with_devtools_) { DevToolsWindow::OpenDevToolsWindow(host()->render_view_host(), diff --git a/chrome/browser/ui/views/extensions/extension_view_views.cc b/chrome/browser/ui/views/extensions/extension_view_views.cc index b7c7e59..77a1263 100644 --- a/chrome/browser/ui/views/extensions/extension_view_views.cc +++ b/chrome/browser/ui/views/extensions/extension_view_views.cc @@ -9,7 +9,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_host.h" #include "extensions/common/view_type.h" #include "ui/events/event.h" @@ -134,13 +133,13 @@ void ExtensionViewViews::PreferredSizeChanged() { } void ExtensionViewViews::OnFocus() { - host()->host_contents()->GetView()->Focus(); + host()->host_contents()->Focus(); } void ExtensionViewViews::CreateWidgetHostView() { DCHECK(!initialized_); initialized_ = true; - Attach(host_->host_contents()->GetView()->GetNativeView()); + Attach(host_->host_contents()->GetNativeView()); host_->CreateRenderViewSoon(); SetVisible(false); } diff --git a/chrome/browser/ui/views/external_protocol_dialog.cc b/chrome/browser/ui/views/external_protocol_dialog.cc index bab86c7..9883404 100644 --- a/chrome/browser/ui/views/external_protocol_dialog.cc +++ b/chrome/browser/ui/views/external_protocol_dialog.cc @@ -12,7 +12,6 @@ #include "chrome/browser/ui/external_protocol_dialog_delegate.h" #include "chrome/browser/ui/views/constrained_window_views.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -137,6 +136,6 @@ ExternalProtocolDialog::ExternalProtocolDialog( render_process_host_id_, routing_id_); gfx::NativeWindow parent_window = NULL; if (web_contents) - parent_window = web_contents->GetView()->GetTopLevelNativeWindow(); + parent_window = web_contents->GetTopLevelNativeWindow(); CreateBrowserModalDialogViews(this, parent_window)->Show(); } diff --git a/chrome/browser/ui/views/find_bar_host.cc b/chrome/browser/ui/views/find_bar_host.cc index 284f848..636e587 100644 --- a/chrome/browser/ui/views/find_bar_host.cc +++ b/chrome/browser/ui/views/find_bar_host.cc @@ -13,7 +13,6 @@ #include "chrome/browser/ui/views/frame/browser_view.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/events/event.h" #include "ui/events/keycodes/keyboard_codes.h" #include "ui/views/focus/external_focus_tracker.h" @@ -169,7 +168,7 @@ bool FindBarHost::IsFindBarVisible() { void FindBarHost::RestoreSavedFocus() { if (focus_tracker() == NULL) { // TODO(brettw): Focus() should be on WebContentsView. - find_bar_controller_->web_contents()->GetView()->Focus(); + find_bar_controller_->web_contents()->Focus(); } else { focus_tracker()->FocusLastFocusedExternalView(); } @@ -366,8 +365,7 @@ void FindBarHost::OnVisibilityChanged() { void FindBarHost::GetWidgetPositionNative(gfx::Rect* avoid_overlapping_rect) { gfx::Rect frame_rect = host()->GetTopLevelWidget()->GetWindowBoundsInScreen(); - content::WebContentsView* tab_view = - find_bar_controller_->web_contents()->GetView(); - gfx::Rect webcontents_rect = tab_view->GetViewBounds(); + gfx::Rect webcontents_rect = + find_bar_controller_->web_contents()->GetViewBounds(); avoid_overlapping_rect->Offset(0, webcontents_rect.y() - frame_rect.y()); } diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index 3e7e974..af452fb 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -107,7 +107,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/content_switches.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" @@ -832,7 +831,7 @@ void BrowserView::OnActiveTabChanged(content::WebContents* old_contents, GetWidget()->IsVisible()) { // We only restore focus if our window is visible, to avoid invoking blur // handlers when we are eventually shown. - new_contents->GetView()->RestoreFocus(); + new_contents->RestoreFocus(); } // Update all the UI bits. @@ -942,7 +941,7 @@ bool BrowserView::IsInMetroSnapMode() const { void BrowserView::RestoreFocus() { WebContents* selected_web_contents = GetActiveWebContents(); if (selected_web_contents) - selected_web_contents->GetView()->RestoreFocus(); + selected_web_contents->RestoreFocus(); } void BrowserView::SetWindowSwitcherButton(views::Button* button) { @@ -1428,12 +1427,12 @@ void BrowserView::TabInsertedAt(WebContents* contents, // window yet. Per http://crbug/342672 add them now since drawing the // WebContents requires root window specific data - information about // the screen the WebContents is drawn on, for example. - if (!contents->GetView()->GetNativeView()->GetRootWindow()) { - aura::Window* window = contents->GetView()->GetNativeView(); + if (!contents->GetNativeView()->GetRootWindow()) { + aura::Window* window = contents->GetNativeView(); aura::Window* root_window = GetNativeWindow()->GetRootWindow(); aura::client::ParentWindowWithContext( window, root_window, root_window->GetBoundsInScreen()); - DCHECK(contents->GetView()->GetNativeView()->GetRootWindow()); + DCHECK(contents->GetNativeView()->GetRootWindow()); } web_contents_close_handler_->TabInserted(); @@ -1467,7 +1466,7 @@ void BrowserView::TabDeactivated(WebContents* contents) { // Some reports seem to show that the focus manager and/or focused view can // be garbage at that point, it is not clear why. if (!contents->IsBeingDestroyed()) - contents->GetView()->StoreFocus(); + contents->StoreFocus(); } void BrowserView::TabStripEmpty() { @@ -2503,7 +2502,7 @@ void BrowserView::DoCutCopyPaste(void (WebContents::*method)(), bool BrowserView::DoCutCopyPasteForWebContents( WebContents* contents, void (WebContents::*method)()) { - gfx::NativeView native_view = contents->GetView()->GetContentNativeView(); + gfx::NativeView native_view = contents->GetContentNativeView(); if (!native_view) return false; if (native_view->HasFocus()) { diff --git a/chrome/browser/ui/views/frame/contents_web_view.cc b/chrome/browser/ui/views/frame/contents_web_view.cc index 82576ca..234873c 100644 --- a/chrome/browser/ui/views/frame/contents_web_view.cc +++ b/chrome/browser/ui/views/frame/contents_web_view.cc @@ -7,7 +7,6 @@ #include "chrome/browser/themes/theme_properties.h" #include "chrome/browser/ui/views/status_bubble_views.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/aura/window.h" #include "ui/base/theme_provider.h" #include "ui/compositor/layer_tree_owner.h" @@ -84,8 +83,7 @@ void ContentsWebView::OnLayerRecreated(ui::Layer* old_layer, void ContentsWebView::CloneWebContentsLayer() { if (!web_contents()) return; - cloned_layer_tree_ = wm::RecreateLayers( - web_contents()->GetView()->GetNativeView()); + cloned_layer_tree_ = wm::RecreateLayers(web_contents()->GetNativeView()); if (!cloned_layer_tree_ || !cloned_layer_tree_->root()) { cloned_layer_tree_.reset(); return; diff --git a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc index 6a81264..d7f12d2 100644 --- a/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc +++ b/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc @@ -13,7 +13,6 @@ #include "chrome/browser/ui/views/tabs/tab_strip.h" #include "content/public/browser/notification_service.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/aura/window.h" #include "ui/views/view.h" #include "ui/views/widget/widget.h" diff --git a/chrome/browser/ui/views/hung_renderer_view.cc b/chrome/browser/ui/views/hung_renderer_view.cc index a663391..bb9b873 100644 --- a/chrome/browser/ui/views/hung_renderer_view.cc +++ b/chrome/browser/ui/views/hung_renderer_view.cc @@ -21,7 +21,6 @@ #include "content/public/browser/render_process_host.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/result_codes.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" @@ -197,7 +196,7 @@ HungRendererDialogView* HungRendererDialogView::GetInstance() { // static bool HungRendererDialogView::IsFrameActive(WebContents* contents) { gfx::NativeView frame_view = - platform_util::GetTopLevel(contents->GetView()->GetNativeView()); + platform_util::GetTopLevel(contents->GetNativeView()); return platform_util::IsWindowActive(frame_view); } @@ -244,7 +243,7 @@ void HungRendererDialogView::ShowForWebContents(WebContents* contents) { } gfx::NativeView frame_view = - platform_util::GetTopLevel(contents->GetView()->GetNativeView()); + platform_util::GetTopLevel(contents->GetNativeView()); views::Widget* insert_after = views::Widget::GetWidgetForNativeView(frame_view); if (insert_after) @@ -441,7 +440,7 @@ void ShowHungRendererDialog(WebContents* contents) { return; gfx::NativeView toplevel_view = - platform_util::GetTopLevel(contents->GetView()->GetNativeView()); + platform_util::GetTopLevel(contents->GetNativeView()); // Don't show the dialog if there is no root window for the renderer, because // it's invisible to the user (happens when the renderer is for prerendering // for example). diff --git a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc index c39b2d5..87a14eb 100644 --- a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc +++ b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc @@ -20,7 +20,6 @@ #include "ui/base/ui_base_switches.h" #if defined(OS_WIN) -#include "content/public/browser/web_contents_view.h" #include "ui/aura/window.h" #include "ui/aura/window_tree_host.h" #endif @@ -113,8 +112,7 @@ IN_PROC_BROWSER_TEST_F(StarViewTestNoDWM, WindowedNPAPIPluginHidden) { EXPECT_EQ(expected_title, title_watcher.WaitAndGetTitle()); // Now get the region of the plugin before the star view is shown. - HWND hwnd = tab->GetView()->GetNativeView()->GetHost()-> - GetAcceleratedWidget(); + HWND hwnd = tab->GetNativeView()->GetHost()->GetAcceleratedWidget(); HWND child = NULL; EnumChildWindows(hwnd, EnumerateChildren,reinterpret_cast<LPARAM>(&child)); diff --git a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc index 3ebdb82..80367b8 100644 --- a/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc +++ b/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc @@ -15,7 +15,6 @@ #include "chrome/browser/ui/views/location_bar/zoom_view.h" #include "chrome/browser/ui/zoom/zoom_controller.h" #include "content/public/browser/notification_source.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/resource/resource_bundle.h" @@ -73,8 +72,7 @@ void ZoomBubbleView::ShowBubble(content::WebContents* web_contents, // If we do not have an anchor view, parent the bubble to the content area. if (!anchor_to_view) { - zoom_bubble_->set_parent_window( - web_contents->GetView()->GetTopLevelNativeWindow()); + zoom_bubble_->set_parent_window(web_contents->GetTopLevelNativeWindow()); } views::BubbleDelegateView::CreateBubble(zoom_bubble_); diff --git a/chrome/browser/ui/views/panels/panel_view.cc b/chrome/browser/ui/views/panels/panel_view.cc index 017cfbe..4224926 100644 --- a/chrome/browser/ui/views/panels/panel_view.cc +++ b/chrome/browser/ui/views/panels/panel_view.cc @@ -20,7 +20,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/image/image.h" #include "ui/gfx/path.h" #include "ui/gfx/screen.h" @@ -997,7 +996,7 @@ void PanelView::OnWidgetActivationChanged(views::Widget* widget, bool active) { if (focused_) { content::WebContents* web_contents = panel_->GetWebContents(); if (web_contents) - web_contents->GetView()->RestoreFocus(); + web_contents->RestoreFocus(); } } diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc index 0c3f0e0..654c114 100644 --- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc +++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc @@ -15,7 +15,6 @@ #include "chrome/browser/ui/views/passwords/manage_password_item_view.h" #include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h" #include "content/public/browser/notification_source.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" #include "ui/base/models/combobox_model.h" @@ -101,7 +100,7 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents, if (is_fullscreen) { manage_passwords_bubble_->set_parent_window( - web_contents->GetView()->GetTopLevelNativeWindow()); + web_contents->GetTopLevelNativeWindow()); } views::BubbleDelegateView::CreateBubble(manage_passwords_bubble_); diff --git a/chrome/browser/ui/views/profiles/user_manager_view.cc b/chrome/browser/ui/views/profiles/user_manager_view.cc index c0eb030..4f0be31 100644 --- a/chrome/browser/ui/views/profiles/user_manager_view.cc +++ b/chrome/browser/ui/views/profiles/user_manager_view.cc @@ -14,7 +14,6 @@ #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/views/auto_keep_alive.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" #include "ui/views/controls/webview/webview.h" diff --git a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc index c6187f9..d879b71 100644 --- a/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc +++ b/chrome/browser/ui/views/renderer_context_menu/render_view_context_menu_views.cc @@ -10,7 +10,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "ui/base/accelerators/accelerator.h" #include "ui/base/l10n/l10n_util.h" diff --git a/chrome/browser/ui/views/sad_tab_view.cc b/chrome/browser/ui/views/sad_tab_view.cc index 913025a..0c7a205 100644 --- a/chrome/browser/ui/views/sad_tab_view.cc +++ b/chrome/browser/ui/views/sad_tab_view.cc @@ -16,7 +16,6 @@ #include "chrome/common/url_constants.h" #include "content/public/browser/navigation_controller.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -239,7 +238,7 @@ void SadTabView::Show() { // It is not possible to create a native_widget_win that has no parent in // and later re-parent it. // TODO(avi): This is a cheat. Can this be made cleaner? - sad_tab_params.parent = web_contents_->GetView()->GetNativeView(); + sad_tab_params.parent = web_contents_->GetNativeView(); set_owned_by_client(); @@ -248,9 +247,8 @@ void SadTabView::Show() { sad_tab->SetContentsView(this); views::Widget::ReparentNativeView(sad_tab->GetNativeView(), - web_contents_->GetView()->GetNativeView()); - gfx::Rect bounds; - web_contents_->GetView()->GetContainerBounds(&bounds); + web_contents_->GetNativeView()); + gfx::Rect bounds = web_contents_->GetContainerBounds(); sad_tab->SetBounds(gfx::Rect(bounds.size())); } diff --git a/chrome/browser/ui/views/ssl_client_certificate_selector.cc b/chrome/browser/ui/views/ssl_client_certificate_selector.cc index 9175e8f..08eefd9 100644 --- a/chrome/browser/ui/views/ssl_client_certificate_selector.cc +++ b/chrome/browser/ui/views/ssl_client_certificate_selector.cc @@ -14,7 +14,6 @@ #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "net/cert/x509_certificate.h" #include "net/ssl/ssl_cert_request_info.h" @@ -267,7 +266,7 @@ void SSLClientCertificateSelector::ButtonPressed( net::X509Certificate* cert = GetSelectedCert(); if (cert) ShowCertificateViewer(web_contents_, - web_contents_->GetView()->GetTopLevelNativeWindow(), + web_contents_->GetTopLevelNativeWindow(), cert); } } diff --git a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc index 07f6ec9e..b1c19ee 100644 --- a/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc +++ b/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc @@ -16,7 +16,6 @@ #include "components/web_modal/web_contents_modal_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "google_apis/gaia/gaia_auth_util.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" diff --git a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc index 1b56ee4..1b9d752 100644 --- a/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc +++ b/chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc @@ -17,7 +17,6 @@ #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "ui/aura/client/screen_position_client.h" #include "ui/aura/window.h" #include "ui/views/focus/focus_manager.h" @@ -190,7 +189,7 @@ void ChromeWebContentsViewDelegateViews::SizeChanged(const gfx::Size& size) { aura::Window* ChromeWebContentsViewDelegateViews::GetActiveNativeView() { return web_contents_->GetFullscreenRenderWidgetHostView() ? web_contents_->GetFullscreenRenderWidgetHostView()->GetNativeView() : - web_contents_->GetView()->GetNativeView(); + web_contents_->GetNativeView(); } views::Widget* ChromeWebContentsViewDelegateViews::GetTopLevelWidget() { @@ -208,7 +207,7 @@ void ChromeWebContentsViewDelegateViews::SetInitialFocus() { if (web_contents_->GetDelegate()) web_contents_->GetDelegate()->SetFocusToLocationBar(false); } else { - web_contents_->GetView()->Focus(); + web_contents_->Focus(); } } diff --git a/chrome/browser/ui/views/tabs/tab_drag_controller.cc b/chrome/browser/ui/views/tabs/tab_drag_controller.cc index 624c229..54f836d1 100644 --- a/chrome/browser/ui/views/tabs/tab_drag_controller.cc +++ b/chrome/browser/ui/views/tabs/tab_drag_controller.cc @@ -33,7 +33,6 @@ #include "content/public/browser/notification_types.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "extensions/browser/extension_function_dispatcher.h" #include "ui/aura/env.h" #include "ui/base/resource/resource_bundle.h" @@ -589,7 +588,7 @@ void TabDragController::RestoreFocus() { if (is_dragging_new_browser_) { content::WebContents* active_contents = source_dragged_contents(); if (active_contents && !active_contents->FocusLocationBarByDefault()) - active_contents->GetView()->Focus(); + active_contents->Focus(); } return; } diff --git a/chrome/browser/ui/views/toolbar/toolbar_view.cc b/chrome/browser/ui/views/toolbar/toolbar_view.cc index 2f03229..a271814 100644 --- a/chrome/browser/ui/views/toolbar/toolbar_view.cc +++ b/chrome/browser/ui/views/toolbar/toolbar_view.cc @@ -54,7 +54,6 @@ #include "content/public/browser/render_view_host.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" #include "grit/theme_resources.h" diff --git a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc index 5f88794..d2c1198 100644 --- a/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc +++ b/chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc @@ -10,7 +10,6 @@ #include "components/web_modal/single_web_contents_dialog_manager.h" #include "components/web_modal/web_contents_modal_dialog_host.h" #include "components/web_modal/web_contents_modal_dialog_manager.h" -#include "content/public/browser/web_contents_view.h" #include "ui/gfx/point.h" #include "ui/gfx/size.h" #include "ui/views/border.h" diff --git a/chrome/browser/ui/views/web_dialog_view_browsertest.cc b/chrome/browser/ui/views/web_dialog_view_browsertest.cc index 1e4fb26..e2c010d 100644 --- a/chrome/browser/ui/views/web_dialog_view_browsertest.cc +++ b/chrome/browser/ui/views/web_dialog_view_browsertest.cc @@ -18,7 +18,6 @@ #include "content/public/browser/browser_context.h" #include "content/public/browser/render_widget_host_view.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" #include "ui/views/controls/webview/web_dialog_view.h" @@ -109,7 +108,7 @@ IN_PROC_BROWSER_TEST_F(WebDialogBrowserTest, MAYBE_SizeWindow) { browser()->tab_strip_model()->GetActiveWebContents(); ASSERT_TRUE(web_contents != NULL); views::Widget::CreateWindowWithParent( - view, web_contents->GetView()->GetTopLevelNativeWindow()); + view, web_contents->GetTopLevelNativeWindow()); view->GetWidget()->Show(); // TestWebDialogView should quit current message loop on size change. diff --git a/chrome/browser/ui/webui/app_list/start_page_handler.cc b/chrome/browser/ui/webui/app_list/start_page_handler.cc index 8987645..930b75b 100644 --- a/chrome/browser/ui/webui/app_list/start_page_handler.cc +++ b/chrome/browser/ui/webui/app_list/start_page_handler.cc @@ -23,7 +23,6 @@ #include "chrome/common/pref_names.h" #include "content/public/browser/notification_details.h" #include "content/public/browser/notification_source.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "extensions/browser/extension_system.h" #include "extensions/common/extension.h" @@ -194,8 +193,8 @@ void StartPageHandler::HandleLaunchApp(const base::ListValue* args) { AppListControllerDelegate* controller = AppListService::Get( chrome::GetHostDesktopTypeForNativeView( - web_ui()->GetWebContents()->GetView()->GetNativeView())) - ->GetControllerDelegate(); + web_ui()->GetWebContents()->GetNativeView()))-> + GetControllerDelegate(); controller->ActivateApp(profile, app, AppListControllerDelegate::LAUNCH_FROM_APP_LIST, diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc index 2290e17..84ec86f 100644 --- a/chrome/browser/ui/webui/downloads_dom_handler.cc +++ b/chrome/browser/ui/webui/downloads_dom_handler.cc @@ -43,7 +43,6 @@ #include "content/public/browser/url_data_source.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "extensions/browser/extension_system.h" #include "grit/generated_resources.h" @@ -385,7 +384,7 @@ void DownloadsDOMHandler::HandleDrag(const base::ListValue* args) { gfx::Image* icon = g_browser_process->icon_manager()->LookupIconFromFilepath( file->GetTargetFilePath(), IconLoader::NORMAL); - gfx::NativeView view = web_contents->GetView()->GetNativeView(); + gfx::NativeView view = web_contents->GetNativeView(); { // Enable nested tasks during DnD, while |DragDownload()| blocks. base::MessageLoop::ScopedNestableTaskAllower allow( diff --git a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc index eb597ef..6e43177 100644 --- a/chrome/browser/ui/webui/extensions/extension_loader_handler.cc +++ b/chrome/browser/ui/webui/extensions/extension_loader_handler.cc @@ -19,7 +19,6 @@ #include "content/public/browser/browser_thread.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "content/public/browser/web_ui_data_source.h" #include "extensions/browser/extension_system.h" @@ -113,8 +112,7 @@ void ExtensionLoaderHandler::FileHelper::ChooseFile() { NULL, kFileTypeIndex, base::FilePath::StringType(), - loader_handler_->web_ui()-> - GetWebContents()->GetView()->GetTopLevelNativeWindow(), + loader_handler_->web_ui()->GetWebContents()->GetTopLevelNativeWindow(), NULL); content::RecordComputedAction("Options_LoadUnpackedExtension"); diff --git a/chrome/browser/ui/webui/extensions/install_extension_handler.cc b/chrome/browser/ui/webui/extensions/install_extension_handler.cc index d503e65..3a5ba35 100644 --- a/chrome/browser/ui/webui/extensions/install_extension_handler.cc +++ b/chrome/browser/ui/webui/extensions/install_extension_handler.cc @@ -13,7 +13,6 @@ #include "chrome/browser/extensions/unpacked_installer.h" #include "chrome/browser/profiles/profile.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "content/public/browser/web_ui_data_source.h" #include "content/public/common/drop_data.h" @@ -63,7 +62,7 @@ void InstallExtensionHandler::RegisterMessages() { void InstallExtensionHandler::HandleStartDragMessage( const base::ListValue* args) { content::DropData* drop_data = - web_ui()->GetWebContents()->GetView()->GetDropData(); + web_ui()->GetWebContents()->GetDropData(); if (!drop_data) { DLOG(ERROR) << "No current drop data."; return; diff --git a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc index 717fb51..e7de840 100644 --- a/chrome/browser/ui/webui/extensions/pack_extension_handler.cc +++ b/chrome/browser/ui/webui/extensions/pack_extension_handler.cc @@ -9,7 +9,6 @@ #include "chrome/browser/extensions/extension_creator.h" #include "chrome/browser/ui/chrome_select_file_policy.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "content/public/browser/web_ui_data_source.h" #include "grit/generated_resources.h" @@ -195,7 +194,7 @@ void PackExtensionHandler::HandleSelectFilePathMessage( &info, file_type_index, base::FilePath::StringType(), - web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(), + web_ui()->GetWebContents()->GetTopLevelNativeWindow(), NULL); } diff --git a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc index 74d7650..a2d593f 100644 --- a/chrome/browser/ui/webui/ntp/foreign_session_handler.cc +++ b/chrome/browser/ui/webui/ntp/foreign_session_handler.cc @@ -31,7 +31,6 @@ #include "content/public/browser/notification_source.h" #include "content/public/browser/url_data_source.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -114,7 +113,7 @@ void ForeignSessionHandler::OpenForeignSessionWindows( iter_begin + 1; chrome::HostDesktopType host_desktop_type = chrome::GetHostDesktopTypeForNativeView( - web_ui->GetWebContents()->GetView()->GetNativeView()); + web_ui->GetWebContents()->GetNativeView()); SessionRestore::RestoreForeignSessionWindows( Profile::FromWebUI(web_ui), host_desktop_type, iter_begin, iter_end); } diff --git a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc index 0121b91..edd653e 100644 --- a/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc +++ b/chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc @@ -14,7 +14,6 @@ #include "chrome/browser/ui/webui/ntp/new_tab_ui.h" #include "chrome/common/url_constants.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "ui/base/webui/web_ui_util.h" @@ -86,7 +85,7 @@ void RecentlyClosedTabsHandler::HandleReopenTab(const base::ListValue* args) { return; chrome::HostDesktopType host_desktop_type = chrome::GetHostDesktopTypeForNativeView( - web_ui()->GetWebContents()->GetView()->GetNativeView()); + web_ui()->GetWebContents()->GetNativeView()); WindowOpenDisposition disposition = webui::GetDispositionFromClick(args, 2); tab_restore_service_->RestoreEntryById(delegate, static_cast<int>(session_to_restore), diff --git a/chrome/browser/ui/webui/options/advanced_options_utils_win.cc b/chrome/browser/ui/webui/options/advanced_options_utils_win.cc index ac1ca82..de9080e 100644 --- a/chrome/browser/ui/webui/options/advanced_options_utils_win.cc +++ b/chrome/browser/ui/webui/options/advanced_options_utils_win.cc @@ -15,7 +15,6 @@ #include "chrome/browser/browser_process.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "ui/views/win/hwnd_util.h" using content::BrowserThread; @@ -62,7 +61,7 @@ void AdvancedOptionsUtilities::ShowManageSSLCertificates( CRYPTUI_CERT_MGR_STRUCT cert_mgr = { 0 }; cert_mgr.dwSize = sizeof(CRYPTUI_CERT_MGR_STRUCT); cert_mgr.hwndParent = views::HWNDForNativeWindow( - web_contents->GetView()->GetTopLevelNativeWindow()); + web_contents->GetTopLevelNativeWindow()); ::CryptUIDlgCertMgr(&cert_mgr); } diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc index 3b0907e..f334475 100644 --- a/chrome/browser/ui/webui/options/browser_options_handler.cc +++ b/chrome/browser/ui/webui/options/browser_options_handler.cc @@ -82,7 +82,6 @@ #include "content/public/browser/url_data_source.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/common/page_zoom.h" #include "google_apis/gaia/gaia_auth_util.h" #include "google_apis/gaia/google_service_auth_error.h" @@ -1362,7 +1361,7 @@ void BrowserOptionsHandler::HandleSelectDownloadLocation( &info, 0, base::FilePath::StringType(), - web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(), + web_ui()->GetWebContents()->GetTopLevelNativeWindow(), NULL); } diff --git a/chrome/browser/ui/webui/options/certificate_manager_handler.cc b/chrome/browser/ui/webui/options/certificate_manager_handler.cc index a94fd71..f5d3573 100644 --- a/chrome/browser/ui/webui/options/certificate_manager_handler.cc +++ b/chrome/browser/ui/webui/options/certificate_manager_handler.cc @@ -26,7 +26,6 @@ #include "chrome/browser/ui/webui/certificate_viewer_webui.h" #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "grit/generated_resources.h" #include "net/base/crypto_module.h" #include "net/base/net_errors.h" @@ -1154,7 +1153,7 @@ void CertificateManagerHandler::ShowImportErrors( } gfx::NativeWindow CertificateManagerHandler::GetParentWindow() const { - return web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(); + return web_ui()->GetWebContents()->GetTopLevelNativeWindow(); } } // namespace options diff --git a/chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc index f78d184..de42877 100644 --- a/chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc +++ b/chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc @@ -11,7 +11,6 @@ #include "chromeos/dbus/dbus_thread_manager.h" #include "chromeos/dbus/system_clock_client.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "grit/generated_resources.h" #include "ui/base/l10n/l10n_util.h" @@ -73,7 +72,7 @@ void DateTimeOptionsHandler::HandleShowSetTime(const base::ListValue* args) { // Make sure the clock status hasn't changed since the button was clicked. if (can_set_time_) { SetTimeDialog::ShowDialog( - web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow()); + web_ui()->GetWebContents()->GetTopLevelNativeWindow()); } } diff --git a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc index 9dd7a057..f236d88 100644 --- a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc +++ b/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc @@ -54,7 +54,6 @@ #include "content/public/browser/notification_service.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "grit/ash_resources.h" #include "grit/locale_settings.h" @@ -1639,7 +1638,7 @@ void InternetOptionsHandler::PopulateDictionaryDetailsCallback( } gfx::NativeWindow InternetOptionsHandler::GetNativeWindow() const { - return web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(); + return web_ui()->GetWebContents()->GetTopLevelNativeWindow(); } void InternetOptionsHandler::NetworkCommandCallback( diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc index b3125a6..9ad56cd 100644 --- a/chrome/browser/ui/webui/options/password_manager_handler.cc +++ b/chrome/browser/ui/webui/options/password_manager_handler.cc @@ -21,7 +21,6 @@ #include "content/public/browser/notification_source.h" #include "content/public/browser/user_metrics.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "grit/chromium_strings.h" #include "grit/generated_resources.h" @@ -41,7 +40,7 @@ Profile* PasswordManagerHandler::GetProfile() { #if !defined(OS_ANDROID) gfx::NativeWindow PasswordManagerHandler::GetNativeWindow() { - return web_ui()->GetWebContents()->GetView()->GetTopLevelNativeWindow(); + return web_ui()->GetWebContents()->GetTopLevelNativeWindow(); } #endif diff --git a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc index 6534f82..7b4a5b3 100644 --- a/chrome/browser/ui/webui/print_preview/print_preview_handler.cc +++ b/chrome/browser/ui/webui/print_preview/print_preview_handler.cc @@ -58,7 +58,6 @@ #include "content/public/browser/navigation_entry.h" #include "content/public/browser/render_view_host.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "google_apis/gaia/oauth2_token_service.h" #include "printing/backend/print_backend.h" @@ -829,7 +828,7 @@ void PrintPreviewHandler::PrintToPdf() { PostPrintToPdfTask(); } else if (!select_file_dialog_.get() || !select_file_dialog_->IsRunning(platform_util::GetTopLevel( - preview_web_contents()->GetView()->GetNativeView()))) { + preview_web_contents()->GetNativeView()))) { PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>( web_ui()->GetController()); // Pre-populating select file dialog with print job title. @@ -938,7 +937,7 @@ void PrintPreviewHandler::PrintWithCloudPrintDialog() { } gfx::NativeWindow modal_parent = platform_util::GetTopLevel( - preview_web_contents()->GetView()->GetNativeView()); + preview_web_contents()->GetNativeView()); print_dialog_cloud::CreatePrintDialogForBytes( preview_web_contents()->GetBrowserContext(), modal_parent, @@ -1234,8 +1233,7 @@ void PrintPreviewHandler::SelectFile(const base::FilePath& default_filename) { &file_type_info, 0, base::FilePath::StringType(), - platform_util::GetTopLevel( - preview_web_contents()->GetView()->GetNativeView()), + platform_util::GetTopLevel(preview_web_contents()->GetNativeView()), NULL); } diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc index 959aa48..6a968d9 100644 --- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc +++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc @@ -519,7 +519,7 @@ void PrintPreviewUI::OnDidPreviewPage(int page_number, base::FundamentalValue ui_identifier(id_); base::FundamentalValue request_id(preview_request_id); if (g_testing_delegate) - g_testing_delegate->DidRenderPreviewPage(*web_ui()->GetWebContents()); + g_testing_delegate->DidRenderPreviewPage(web_ui()->GetWebContents()); web_ui()->CallJavascriptFunction( "onDidPreviewPage", number, ui_identifier, request_id); if (g_testing_delegate && g_testing_delegate->IsAutoCancelEnabled()) diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.h b/chrome/browser/ui/webui/print_preview/print_preview_ui.h index 5d68c3b..7f32261 100644 --- a/chrome/browser/ui/webui/print_preview/print_preview_ui.h +++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.h @@ -149,8 +149,7 @@ class PrintPreviewUI : public ConstrainedWebDialogUI { public: virtual bool IsAutoCancelEnabled() = 0; virtual void DidGetPreviewPageCount(int page_count) = 0; - virtual void DidRenderPreviewPage( - const content::WebContents& preview_dialog) = 0; + virtual void DidRenderPreviewPage(content::WebContents* preview_dialog) = 0; }; static void SetDelegateForTesting(TestingDelegate* delegate); diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc index b0fe640..c3845c8 100644 --- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc +++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc @@ -25,7 +25,6 @@ #include "content/public/test/test_utils.h" #if defined(OS_WIN) -#include "content/public/browser/web_contents_view.h" #include "ui/aura/window.h" #include "ui/aura/window_tree_host.h" #endif @@ -159,8 +158,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, WindowedNPAPIPluginHidden) { // Now get the region of the plugin before and after the print preview is // shown. They should be different. - HWND hwnd = tab->GetView()->GetNativeView()->GetHost()-> - GetAcceleratedWidget(); + HWND hwnd = tab->GetNativeView()->GetHost()->GetAcceleratedWidget(); HWND child = NULL; EnumChildWindows(hwnd, EnumerateChildren,reinterpret_cast<LPARAM>(&child)); diff --git a/chrome/browser/ui/webui/set_as_default_browser_ui.cc b/chrome/browser/ui/webui/set_as_default_browser_ui.cc index dbaa853..6dbcd99 100644 --- a/chrome/browser/ui/webui/set_as_default_browser_ui.cc +++ b/chrome/browser/ui/webui/set_as_default_browser_ui.cc @@ -31,7 +31,6 @@ #include "content/public/browser/browser_thread.h" #include "content/public/browser/web_contents.h" #include "content/public/browser/web_contents_delegate.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "content/public/browser/web_ui_data_source.h" #include "content/public/browser/web_ui_message_handler.h" @@ -352,7 +351,7 @@ void SetAsDefaultBrowserDialogImpl::OnDialogClosed( browser_->tab_strip_model()->GetActiveWebContents(); window->Show(); if (contents) - contents->GetView()->SetInitialFocus(); + contents->SetInitialFocus(); } } diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc index 492559c..594aff0 100644 --- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc +++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc @@ -20,7 +20,6 @@ #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/singleton_tabs.h" #include "content/public/browser/web_contents.h" -#include "content/public/browser/web_contents_view.h" #include "content/public/browser/web_ui.h" #include "google_apis/gaia/gaia_auth_fetcher.h" #include "google_apis/gaia/gaia_constants.h" @@ -202,7 +201,7 @@ void UserManagerScreenHandler::HandleInitialize(const base::ListValue* args) { SendUserList(); web_ui()->CallJavascriptFunction("cr.ui.Oobe.showUserManagerScreen"); desktop_type_ = chrome::GetHostDesktopTypeForNativeView( - web_ui()->GetWebContents()->GetView()->GetNativeView()); + web_ui()->GetWebContents()->GetNativeView()); } void UserManagerScreenHandler::HandleAddUser(const base::ListValue* args) { |