diff options
author | flackr@chromium.org <flackr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-25 17:54:36 +0000 |
---|---|---|
committer | flackr@chromium.org <flackr@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-03-25 17:54:36 +0000 |
commit | 0bf53d21ec308f35a8adcaf0d093a4959deae5c1 (patch) | |
tree | 6c8d54b4425fc58392106036f4aeebf2700f59ea /chrome/browser/ui | |
parent | dd204dc2d0055e511cba23bae525829156058ab4 (diff) | |
download | chromium_src-0bf53d21ec308f35a8adcaf0d093a4959deae5c1.zip chromium_src-0bf53d21ec308f35a8adcaf0d093a4959deae5c1.tar.gz chromium_src-0bf53d21ec308f35a8adcaf0d093a4959deae5c1.tar.bz2 |
Revert 190431 "Inconsistent use of [x] close panel icon"
> Inconsistent use of [x] close panel icon
> The close button in download pane should be the tab close button asset : tab_close_*.png
> (this was originally reported as part of BUG=173251).
>
> By the same logic the same smaller bitmap with red hover background should be used for all infobars
> such as translate bar, save password bar, etc. It should also be used for find-in-page bar on all
> platforms (Mac was missed with the previous implementation).
>
> The close button in the chrome UI and Web UI bubbles was left the same as before (this needs to be regression-tested).
>
> Code was rearranged to make explicit the disrepancy between the IDR_CLOSE_BAR and IDR_CLOSE_BUBBLE.
> IDR_TAB_CLOSE was renamed IDR_CLOSE_1.
> IDR_CLOSE_BAR was renamed IDR_CLOSE_2.
> png files were also renamed.
>
> BUG=217094
> TEST=Open any page that downloads an attachment such as gmail email with an attachment or a page with images. Download an image or an attachment. Verify that the close button in download bar at the bottom of the screen has a red circular background when mouse hovers over it - same as the close tab button.
>
> TEST=Open find-in-page (Ctrl+F) box on Mac, Linux and Windows and check that the close button is same as tab close (has a red circular background when mouse hovers over it).
>
> TEST=Open any infobar (translate / save password) on both ChromeOS and linux and check that the close button is same as tab close (has a red circular background when mouse hovers over it). Opening a non-English news page is usually the easiest way.
>
> TEST=Trigger chrome to show a toolbar bubble such as extension installed bubble that shows when an extension is installed from chrome web store (see bitmaps in comments attached to BUG=217094). Confirm that the close buttons in those bubbles are NOT changed from before the change (they should NOT have the red circular background when mouse hovers over).
>
> Review URL: https://codereview.chromium.org/12634025
TBR=flackr@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190432 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui')
22 files changed, 69 insertions, 77 deletions
diff --git a/chrome/browser/ui/cocoa/hover_close_button.mm b/chrome/browser/ui/cocoa/hover_close_button.mm index 3c2a952..374500b 100644 --- a/chrome/browser/ui/cocoa/hover_close_button.mm +++ b/chrome/browser/ui/cocoa/hover_close_button.mm @@ -160,16 +160,16 @@ NSString* const kFadeOutValueKeyPath = @"fadeOutValue"; } - (NSImage*)imageForHoverState:(HoverState)hoverState { - int imageID = IDR_CLOSE_1; + int imageID = IDR_TAB_CLOSE; switch (hoverState) { case kHoverStateNone: - imageID = IDR_CLOSE_1; + imageID = IDR_TAB_CLOSE; break; case kHoverStateMouseOver: - imageID = IDR_CLOSE_1_H; + imageID = IDR_TAB_CLOSE_H; break; case kHoverStateMouseDown: - imageID = IDR_CLOSE_1_P; + imageID = IDR_TAB_CLOSE_P; break; } ui::ResourceBundle& bundle = ui::ResourceBundle::GetSharedInstance(); diff --git a/chrome/browser/ui/gtk/confirm_bubble_gtk.cc b/chrome/browser/ui/gtk/confirm_bubble_gtk.cc index c00463d..7822767 100644 --- a/chrome/browser/ui/gtk/confirm_bubble_gtk.cc +++ b/chrome/browser/ui/gtk/confirm_bubble_gtk.cc @@ -81,7 +81,7 @@ void ConfirmBubbleGtk::Show() { gtk_box_pack_start(GTK_BOX(row), title_label, FALSE, FALSE, 0); gtk_box_pack_start(GTK_BOX(row), gtk_label_new(NULL), TRUE, TRUE, 0); - close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_service)); + close_button_.reset(CustomDrawButton::CloseButton(theme_service)); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnCloseButtonThunk), this); gtk_box_pack_end(GTK_BOX(row), close_button_->widget(), FALSE, FALSE, 0); diff --git a/chrome/browser/ui/gtk/custom_button.cc b/chrome/browser/ui/gtk/custom_button.cc index 0c7ce85..2b41351 100644 --- a/chrome/browser/ui/gtk/custom_button.cc +++ b/chrome/browser/ui/gtk/custom_button.cc @@ -355,20 +355,10 @@ gboolean CustomDrawButton::OnCustomExpose(GtkWidget* sender, } // static -CustomDrawButton* CustomDrawButton::CloseButtonBar( +CustomDrawButton* CustomDrawButton::CloseButton( GtkThemeService* theme_provider) { - CustomDrawButton* button = new CustomDrawButton(theme_provider, - IDR_CLOSE_1, IDR_CLOSE_1_P, IDR_CLOSE_1_H, 0, - GTK_STOCK_CLOSE, GTK_ICON_SIZE_MENU); - return button; -} - -// static -CustomDrawButton* CustomDrawButton::CloseButtonBubble( - GtkThemeService* theme_provider) { - CustomDrawButton* button = new CustomDrawButton(theme_provider, - IDR_CLOSE_2, IDR_CLOSE_2_P, IDR_CLOSE_2_H, 0, - GTK_STOCK_CLOSE, GTK_ICON_SIZE_MENU); + CustomDrawButton* button = new CustomDrawButton(theme_provider, IDR_CLOSE_BAR, + IDR_CLOSE_BAR_P, IDR_CLOSE_BAR_H, 0, GTK_STOCK_CLOSE, GTK_ICON_SIZE_MENU); return button; } diff --git a/chrome/browser/ui/gtk/custom_button.h b/chrome/browser/ui/gtk/custom_button.h index c10ba1e..cf9b076 100644 --- a/chrome/browser/ui/gtk/custom_button.h +++ b/chrome/browser/ui/gtk/custom_button.h @@ -197,14 +197,9 @@ class CustomDrawButton : public content::NotificationObserver { const content::NotificationSource& source, const content::NotificationDetails& details) OVERRIDE; - // Returns a standard close button used for infobars and shelves (smaller - // with red hover). - // Pass a |theme_provider| to use Gtk icons in Gtk rendering mode. - static CustomDrawButton* CloseButtonBar(GtkThemeService* theme_provider); - - // Returns a standard close button used for bubbles (larger). - // Pass a |theme_provider| to use Gtk icons in Gtk rendering mode. - static CustomDrawButton* CloseButtonBubble(GtkThemeService* theme_provider); + // Returns a standard close button. Pass a |theme_provider| to use Gtk icons + // in Gtk rendering mode. + static CustomDrawButton* CloseButton(GtkThemeService* theme_provider); private: // Sets the button to themed or not. diff --git a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc index 90df4b3..d5a2aa5 100644 --- a/chrome/browser/ui/gtk/download/download_shelf_gtk.cc +++ b/chrome/browser/ui/gtk/download/download_shelf_gtk.cc @@ -120,7 +120,7 @@ DownloadShelfGtk::DownloadShelfGtk(Browser* browser, GtkWidget* parent) gtk_container_add(GTK_CONTAINER(shelf_.get()), vbox); // Create and pack the close button. - close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_)); + close_button_.reset(CustomDrawButton::CloseButton(theme_service_)); gtk_util::CenterWidgetInHBox(outer_hbox, close_button_->widget(), true, 0); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnButtonClickThunk), this); diff --git a/chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc b/chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc index 29c03ee..792642b 100644 --- a/chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc +++ b/chrome/browser/ui/gtk/extensions/bundle_installed_bubble_gtk.cc @@ -85,7 +85,7 @@ void BundleInstalledBubbleGtk::ShowInternal(const BundleInstaller* bundle) { // Close button GtkWidget* close_column = gtk_vbox_new(FALSE, 0); gtk_box_pack_start(GTK_BOX(bubble_content), close_column, FALSE, FALSE, 0); - close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_provider)); + close_button_.reset(CustomDrawButton::CloseButton(theme_provider)); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnButtonClick), this); gtk_box_pack_start(GTK_BOX(close_column), close_button_->widget(), diff --git a/chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc b/chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc index 32fc317..1ceea2e 100644 --- a/chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc +++ b/chrome/browser/ui/gtk/extensions/extension_installed_bubble_gtk.cc @@ -320,7 +320,7 @@ void ExtensionInstalledBubbleGtk::ShowInternal() { // Create and pack the close button. GtkWidget* close_column = gtk_vbox_new(FALSE, 0); gtk_box_pack_start(GTK_BOX(bubble_content), close_column, FALSE, FALSE, 0); - close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_provider)); + close_button_.reset(CustomDrawButton::CloseButton(theme_provider)); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnButtonClick), this); gtk_box_pack_start(GTK_BOX(close_column), close_button_->widget(), diff --git a/chrome/browser/ui/gtk/find_bar_gtk.cc b/chrome/browser/ui/gtk/find_bar_gtk.cc index ef3d70d..6e71775 100644 --- a/chrome/browser/ui/gtk/find_bar_gtk.cc +++ b/chrome/browser/ui/gtk/find_bar_gtk.cc @@ -248,7 +248,10 @@ void FindBarGtk::InitWidgets() { 0, false, true, NULL)); GtkWidget* close_alignment = gtk_alignment_new(0, 0.6, 1, 0); - close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_)); + close_button_.reset(new CustomDrawButton( + theme_service_, IDR_TAB_CLOSE, + IDR_TAB_CLOSE_P, IDR_TAB_CLOSE_H, IDR_TAB_CLOSE, + GTK_STOCK_CLOSE, GTK_ICON_SIZE_MENU)); gtk_container_add(GTK_CONTAINER(close_alignment), close_button_->widget()); gtk_box_pack_end(GTK_BOX(hbox), close_alignment, FALSE, FALSE, kCloseButtonPadding); @@ -558,8 +561,8 @@ void FindBarGtk::Observe(int type, ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); close_button_->SetBackground( theme_service_->GetColor(ThemeProperties::COLOR_TAB_TEXT), - rb.GetImageNamed(IDR_CLOSE_1).AsBitmap(), - rb.GetImageNamed(IDR_CLOSE_1).AsBitmap()); + rb.GetImageNamed(IDR_TAB_CLOSE).AsBitmap(), + rb.GetImageNamed(IDR_TAB_CLOSE).AsBitmap()); } UpdateMatchLabelAppearance(match_label_failure_); diff --git a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc index d933b007..a5eae474 100644 --- a/chrome/browser/ui/gtk/infobars/infobar_gtk.cc +++ b/chrome/browser/ui/gtk/infobars/infobar_gtk.cc @@ -83,7 +83,7 @@ InfoBarGtk::InfoBarGtk(InfoBarService* owner, InfoBarDelegate* delegate) gtk_box_pack_start(GTK_BOX(hbox_), image, FALSE, FALSE, 0); } - close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_)); + close_button_.reset(CustomDrawButton::CloseButton(theme_service_)); gtk_util::CenterWidgetInHBox(hbox_, close_button_->widget(), true, 0); signals_->Connect(close_button_->widget(), "clicked", G_CALLBACK(OnCloseButtonThunk), this); diff --git a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc index 80da5f5..e6bc666 100644 --- a/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc +++ b/chrome/browser/ui/gtk/notifications/balloon_view_gtk.cc @@ -268,11 +268,14 @@ void BalloonViewImpl::Show(Balloon* balloon) { ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); // Create a button to dismiss the balloon and add it to the toolbar. - close_button_.reset(CustomDrawButton::CloseButtonBar(theme_service_)); + close_button_.reset(new CustomDrawButton(IDR_TAB_CLOSE, + IDR_TAB_CLOSE_P, + IDR_TAB_CLOSE_H, + IDR_TAB_CLOSE)); close_button_->SetBackground( SK_ColorBLACK, - rb.GetImageNamed(IDR_CLOSE_1).AsBitmap(), - rb.GetImageNamed(IDR_CLOSE_1_MASK).AsBitmap()); + rb.GetImageNamed(IDR_TAB_CLOSE).AsBitmap(), + rb.GetImageNamed(IDR_TAB_CLOSE_MASK).AsBitmap()); gtk_widget_set_tooltip_text(close_button_->widget(), dismiss_text.c_str()); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnCloseButtonThunk), this); diff --git a/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc b/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc index 5e840de..6b656f34 100644 --- a/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc +++ b/chrome/browser/ui/gtk/one_click_signin_bubble_gtk.cc @@ -153,7 +153,7 @@ void OneClickSigninBubbleGtk::InitializeWidgets( pango_attr_weight_new(PANGO_WEIGHT_BOLD)); gtk_label_set_attributes(GTK_LABEL(header_label_), attributes); pango_attr_list_unref(attributes); - close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_provider)); + close_button_.reset(CustomDrawButton::CloseButton(theme_provider)); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnClickCloseButtonThunk), this); } diff --git a/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc b/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc index 54b984d..9a3a844 100644 --- a/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc +++ b/chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc @@ -820,8 +820,8 @@ void TabRendererGtk::Layout() { close_button_color_ = tab_text_color; ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); close_button_->SetBackground(close_button_color_, - rb.GetImageNamed(IDR_CLOSE_1).AsBitmap(), - rb.GetImageNamed(IDR_CLOSE_1_MASK).AsBitmap()); + rb.GetImageNamed(IDR_TAB_CLOSE).AsBitmap(), + rb.GetImageNamed(IDR_TAB_CLOSE_MASK).AsBitmap()); } } } else { @@ -1140,7 +1140,8 @@ bool TabRendererGtk::ShouldShowCloseBox() const { } CustomDrawButton* TabRendererGtk::MakeCloseButton() { - CustomDrawButton* button = CustomDrawButton::CloseButtonBar(theme_service_); + CustomDrawButton* button = new CustomDrawButton(IDR_TAB_CLOSE, + IDR_TAB_CLOSE_P, IDR_TAB_CLOSE_H, IDR_TAB_CLOSE); button->ForceChromeTheme(); g_signal_connect(button->widget(), "clicked", @@ -1245,7 +1246,7 @@ void TabRendererGtk::InitResources() { IDR_TAB_INACTIVE_LEFT).ToGdkPixbuf(); tab_inactive_l_height_ = gdk_pixbuf_get_height(tab_inactive_l); - GdkPixbuf* tab_close = rb.GetNativeImageNamed(IDR_CLOSE_1).ToGdkPixbuf(); + GdkPixbuf* tab_close = rb.GetNativeImageNamed(IDR_TAB_CLOSE).ToGdkPixbuf(); close_button_width_ = gdk_pixbuf_get_width(tab_close); close_button_height_ = gdk_pixbuf_get_height(tab_close); diff --git a/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc b/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc index 5c8b7f2..4f6dff9 100644 --- a/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc +++ b/chrome/browser/ui/gtk/website_settings/website_settings_popup_gtk.cc @@ -489,7 +489,7 @@ void WebsiteSettingsPopupGtk::SetIdentityInfo( gtk_label_set_attributes(GTK_LABEL(identity_label), attributes); pango_attr_list_unref(attributes); gtk_box_pack_start(GTK_BOX(hbox), identity_label, FALSE, FALSE, 0); - close_button_.reset(CustomDrawButton::CloseButtonBubble(theme_service_)); + close_button_.reset(CustomDrawButton::CloseButton(theme_service_)); g_signal_connect(close_button_->widget(), "clicked", G_CALLBACK(OnCloseButtonClickedThunk), this); gtk_box_pack_start(GTK_BOX(hbox), close_button_->widget(), FALSE, FALSE, 0); diff --git a/chrome/browser/ui/views/download/download_shelf_view.cc b/chrome/browser/ui/views/download/download_shelf_view.cc index ec700de..5f1ad43 100644 --- a/chrome/browser/ui/views/download/download_shelf_view.cc +++ b/chrome/browser/ui/views/download/download_shelf_view.cc @@ -320,11 +320,11 @@ void DownloadShelfView::ViewHierarchyChanged(bool is_add, close_button_ = new views::ImageButton(this); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_1)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR)); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_H)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_H)); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_P)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_P)); close_button_->SetAccessibleName( l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE)); AddChildView(close_button_); @@ -370,8 +370,8 @@ void DownloadShelfView::UpdateColorsFromTheme() { GetThemeProvider()->GetColor(ThemeProperties::COLOR_BOOKMARK_TEXT)); close_button_->SetBackground( GetThemeProvider()->GetColor(ThemeProperties::COLOR_TAB_TEXT), - rb.GetImageSkiaNamed(IDR_CLOSE_1), - rb.GetImageSkiaNamed(IDR_CLOSE_1_MASK)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR), + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_MASK)); } } diff --git a/chrome/browser/ui/views/extensions/bundle_installed_bubble.cc b/chrome/browser/ui/views/extensions/bundle_installed_bubble.cc index f458561..5256b59 100644 --- a/chrome/browser/ui/views/extensions/bundle_installed_bubble.cc +++ b/chrome/browser/ui/views/extensions/bundle_installed_bubble.cc @@ -123,11 +123,11 @@ class BundleInstalledBubble : public views::BubbleDelegateView, views::ImageButton* button = new views::ImageButton(listener); button->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_2)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR)); button->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_2_H)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_H)); button->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_2_P)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_P)); layout->AddView(button); } diff --git a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc index 3fd85eb..baccb1f 100644 --- a/chrome/browser/ui/views/extensions/extension_installed_bubble.cc +++ b/chrome/browser/ui/views/extensions/extension_installed_bubble.cc @@ -236,11 +236,11 @@ class InstalledBubbleContent : public views::View, // Add the Close button (for all flavors). close_button_ = new views::ImageButton(this); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_2)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR)); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_2_H)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_H)); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_2_P)); + rb.GetImageSkiaNamed(IDR_CLOSE_BAR_P)); AddChildView(close_button_); } diff --git a/chrome/browser/ui/views/find_bar_view.cc b/chrome/browser/ui/views/find_bar_view.cc index 3732c60..cff5935 100644 --- a/chrome/browser/ui/views/find_bar_view.cc +++ b/chrome/browser/ui/views/find_bar_view.cc @@ -136,11 +136,11 @@ FindBarView::FindBarView(FindBarHost* host) close_button_->set_tag(CLOSE_TAG); close_button_->set_focusable(true); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_1)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE)); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_H)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_H)); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_P)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_P)); close_button_->SetTooltipText( l10n_util::GetStringUTF16(IDS_FIND_IN_PAGE_CLOSE_TOOLTIP)); close_button_->SetAccessibleName( @@ -520,7 +520,7 @@ void FindBarView::OnThemeChanged() { if (GetThemeProvider()) { close_button_->SetBackground( GetThemeProvider()->GetColor(ThemeProperties::COLOR_TAB_TEXT), - rb.GetImageSkiaNamed(IDR_CLOSE_1), - rb.GetImageSkiaNamed(IDR_CLOSE_1_MASK)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE), + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_MASK)); } } diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc index 898b189..c400ff8 100644 --- a/chrome/browser/ui/views/infobars/infobar_view.cc +++ b/chrome/browser/ui/views/infobars/infobar_view.cc @@ -227,11 +227,11 @@ void InfoBarView::ViewHierarchyChanged(bool is_add, View* parent, View* child) { close_button_ = new views::ImageButton(this); ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageNamed(IDR_CLOSE_1).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR).ToImageSkia()); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageNamed(IDR_CLOSE_1_H).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_H).ToImageSkia()); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageNamed(IDR_CLOSE_1_P).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_P).ToImageSkia()); close_button_->SetAccessibleName( l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE)); close_button_->set_focusable(true); diff --git a/chrome/browser/ui/views/notifications/balloon_view_views.cc b/chrome/browser/ui/views/notifications/balloon_view_views.cc index 967922e..7ff2ada 100644 --- a/chrome/browser/ui/views/notifications/balloon_view_views.cc +++ b/chrome/browser/ui/views/notifications/balloon_view_views.cc @@ -357,15 +357,15 @@ void BalloonViewImpl::Show(Balloon* balloon) { frame_container_->SetAlwaysOnTop(true); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_1)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE)); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_H)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_H)); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_P)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_P)); close_button_->SetBoundsRect(GetCloseButtonBounds()); close_button_->SetBackground(SK_ColorBLACK, - rb.GetImageSkiaNamed(IDR_CLOSE_1), - rb.GetImageSkiaNamed(IDR_CLOSE_1_MASK)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE), + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_MASK)); options_menu_button_->SetIcon(*rb.GetImageSkiaNamed(IDR_BALLOON_WRENCH)); options_menu_button_->SetHoverIcon( diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc index 0058507..d3a14cc 100644 --- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc +++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc @@ -110,11 +110,11 @@ void OneClickSigninDialogView::InitContent(views::GridLayout* layout) { close_button_ = new views::ImageButton(this); close_button_->SetImage(views::ImageButton::STATE_NORMAL, - rb.GetImageNamed(IDR_CLOSE_2).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR).ToImageSkia()); close_button_->SetImage(views::ImageButton::STATE_HOVERED, - rb.GetImageNamed(IDR_CLOSE_2_H).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_H).ToImageSkia()); close_button_->SetImage(views::ImageButton::STATE_PRESSED, - rb.GetImageNamed(IDR_CLOSE_2_P).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_P).ToImageSkia()); layout->AddView(close_button_); } diff --git a/chrome/browser/ui/views/tabs/tab.cc b/chrome/browser/ui/views/tabs/tab.cc index fdc40c1..33625db 100644 --- a/chrome/browser/ui/views/tabs/tab.cc +++ b/chrome/browser/ui/views/tabs/tab.cc @@ -461,11 +461,11 @@ Tab::Tab(TabController* controller) close_button_ = new TabCloseButton(this); ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); close_button_->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageSkiaNamed(IDR_CLOSE_1)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE)); close_button_->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_H)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_H)); close_button_->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageSkiaNamed(IDR_CLOSE_1_P)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_P)); close_button_->SetAccessibleName( l10n_util::GetStringUTF16(IDS_ACCNAME_CLOSE)); // Disable animation so that the red danger sign shows up immediately @@ -1090,8 +1090,8 @@ void Tab::PaintTab(gfx::Canvas* canvas) { close_button_color_ = title_color; ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); close_button_->SetBackground(close_button_color_, - rb.GetImageSkiaNamed(IDR_CLOSE_1), - rb.GetImageSkiaNamed(IDR_CLOSE_1_MASK)); + rb.GetImageSkiaNamed(IDR_TAB_CLOSE), + rb.GetImageSkiaNamed(IDR_TAB_CLOSE_MASK)); } } diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc index 0a5ad26..d993e09 100644 --- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc +++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc @@ -181,11 +181,11 @@ PopupHeaderView::PopupHeaderView(views::ButtonListener* close_button_listener) new views::ImageButton(close_button_listener); ResourceBundle& rb = ResourceBundle::GetSharedInstance(); close_button->SetImage(views::CustomButton::STATE_NORMAL, - rb.GetImageNamed(IDR_CLOSE_2).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR).ToImageSkia()); close_button->SetImage(views::CustomButton::STATE_HOVERED, - rb.GetImageNamed(IDR_CLOSE_2_H).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_H).ToImageSkia()); close_button->SetImage(views::CustomButton::STATE_PRESSED, - rb.GetImageNamed(IDR_CLOSE_2_P).ToImageSkia()); + rb.GetImageNamed(IDR_CLOSE_BAR_P).ToImageSkia()); layout->AddView(close_button, 1, 1, views::GridLayout::TRAILING, views::GridLayout::LEADING); |