summaryrefslogtreecommitdiffstats
path: root/chrome/browser/ui
diff options
context:
space:
mode:
authorjoaodasilva@chromium.org <joaodasilva@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-06 12:52:15 +0000
committerjoaodasilva@chromium.org <joaodasilva@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-09-06 12:52:15 +0000
commit335c0f18fe2fef97117e7a11ad6c540ac864745e (patch)
tree6423bf27935b69051c8b5ab1cd0a88f41b565fa6 /chrome/browser/ui
parentb4449206da3e3272bb7d91b16c484fc4c2f2a7d3 (diff)
downloadchromium_src-335c0f18fe2fef97117e7a11ad6c540ac864745e.zip
chromium_src-335c0f18fe2fef97117e7a11ad6c540ac864745e.tar.gz
chromium_src-335c0f18fe2fef97117e7a11ad6c540ac864745e.tar.bz2
Plugged potential leak in ExtensionSettingsHandler::IconLoader.
This might be the cause of http://goo.gl/Smp62 BUG=None TEST=None Review URL: http://codereview.chromium.org/7828089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99727 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/ui')
-rw-r--r--chrome/browser/ui/webui/options/extension_settings_handler.cc3
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/browser/ui/webui/options/extension_settings_handler.cc b/chrome/browser/ui/webui/options/extension_settings_handler.cc
index 4fb7156..ac8e232 100644
--- a/chrome/browser/ui/webui/options/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/extension_settings_handler.cc
@@ -153,9 +153,10 @@ void ExtensionSettingsHandler::IconLoader::ReportResultOnUIThread(
DictionaryValue* json) {
if (handler_)
handler_->OnIconsLoaded(json);
+ else
+ delete json;
}
-
///////////////////////////////////////////////////////////////////////////////
//
// ExtensionSettingsHandler