summaryrefslogtreecommitdiffstats
path: root/chrome/browser/upgrade_detector.cc
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-14 16:04:05 +0000
committermark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2011-04-14 16:04:05 +0000
commit055cceb1b4ca2b25b94b7e5e6d71c4d86d904e36 (patch)
treed9979fbde7626dcb8365b69933ea2037ad06f064 /chrome/browser/upgrade_detector.cc
parent394dc47a52388ab922ff23bf422948a7e1c3274c (diff)
downloadchromium_src-055cceb1b4ca2b25b94b7e5e6d71c4d86d904e36.zip
chromium_src-055cceb1b4ca2b25b94b7e5e6d71c4d86d904e36.tar.gz
chromium_src-055cceb1b4ca2b25b94b7e5e6d71c4d86d904e36.tar.bz2
Remove code rendered pointless by r65322.
Since r65322 MessagePump::ScheduleDelayedWork, which is the underlying implementation for PostDelayedTask, operates on TimeTicks instead of Time units. The TimeTicks timebase is stopped during system sleep. Consequently, since that revision, any work that is scheduled through this interface is now expected to be dispatched after a period of TimeTicks, meaning that it will be further delayed by system sleep. MessagePumpCFRunLoopBase::PowerStateNotification had been used to force an attempt to process queued delayed work upon system wakeup. This had the result of dispatching any work whose expected fire time had occurred while the system was asleep, if any, and of resetting the CFRunLoopTimer properly following a change in the offset between the two timebases. Since r65322, there is only a single timebase and no offset, so PowerStateNotification's dispatch attempt was pointless and would never result in delayed work being dispatched or the CFRunLoopTimer being reset to fire at a time other than what it had already been to fire at. IORegisterForSystemPower may be blocked by the sandbox in some processes on some OS releases, and its use in such circumstances might result in messages about its failure being logged. Since this code no longer has any effect, it can be dropped without perceptible impact, and these alleged log messages will allegedly disappear. BUG=74055 TEST=FutureCat Console.app Also run the tests from http://codereview.chromium.org/342011. The behavior post-r65322 may have changed from the expectations listed in that change, but the behavior should not change at all between the post-r65322 code and this change. Review URL: http://codereview.chromium.org/6831009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81597 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/upgrade_detector.cc')
0 files changed, 0 insertions, 0 deletions